Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 772043003: Make CSSToStyleMap static. (Closed)

Created:
6 years ago by andersr
Modified:
6 years ago
Reviewers:
Timothy Loh
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-reviews-css, ed+blinkwatch_opera.com, dstockwell, dglazkov+blink, Steve Block, apavlov+blink_chromium.org, darktears, Eric Willigers, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make CSSToStyleMap static. CSSToStyleMap currently exists as a member on StyleResolverState---wasting space and polluting StyleResolverState with getters, initializers, etc. for no good reason. We may as well pass the StyleResolverState as a parameter, since that is always available in all cases where CSSToStyleMap is used. Note that CSSToStyleMap is currently used for three things, and for each of those things the generated code will expect functions with a certain signature: * FillLayers (state is passed). * Animations (state is not passed). * NinePieceImages (state is passed). R=timloh@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -101 lines) Patch
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.h View 2 chunks +16 lines, -38 lines 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.cpp View 18 chunks +36 lines, -46 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolverState.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/css/resolver/StyleResolverState.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
andersr
6 years ago (2014-12-02 17:14:57 UTC) #1
Timothy Loh
On 2014/12/02 17:14:57, andersr wrote: lgtm
6 years ago (2014-12-02 21:59:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772043003/1
6 years ago (2014-12-03 09:29:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772043003/1
6 years ago (2014-12-03 09:30:04 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-03 10:50:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186408

Powered by Google App Engine
This is Rietveld 408576698