Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 772003002: Migrate DeviceUtils.EnableRoot to adb_wrapper (Closed)

Created:
6 years ago by perezju
Modified:
6 years ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Migrate DeviceUtils.EnableRoot to adb_wrapper The new implemention is simply based on adb.Root, which already throws an exception when the command is not successful. BUG=267773 Committed: https://crrev.com/63919c1ae931d28cda16030573cc607ebae76a8a Cr-Commit-Position: refs/heads/master@{#306401}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M build/android/pylib/device/device_utils.py View 1 chunk +5 lines, -3 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 1 chunk +10 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
perezju
This one should be pretty straightforward
6 years ago (2014-12-02 12:12:15 UTC) #2
jbudorick
lgtm
6 years ago (2014-12-02 15:20:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772003002/1
6 years ago (2014-12-02 16:10:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-02 16:57:19 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-02 16:58:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63919c1ae931d28cda16030573cc607ebae76a8a
Cr-Commit-Position: refs/heads/master@{#306401}

Powered by Google App Engine
This is Rietveld 408576698