Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 771903003: Updated the omnibox on Android to color URLs correctly (Closed)

Created:
6 years ago by sashab
Modified:
6 years ago
Reviewers:
Ted C
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, benwells
Base URL:
https://chromium.googlesource.com/chromium/src.git@url_coloring_unittests
Project:
chromium
Visibility:
Public.

Description

Updated the omnibox on Android to color URLs correctly Updated the URL coloring logic on Android to color the light-grey portions of URLs (currently #969696 100% opacity) to #333333 50% opacity on light backgrounds and #ffffff 50% opacity on dark backgrounds. Also updated the URL coloring tests to reflect this. Based on crrev.com/751423003. BUG=430771 Committed: https://crrev.com/0ecb56c7474db0b57c50102adc0ee3815a0182f3 Cr-Commit-Position: refs/heads/master@{#306558} Committed: https://crrev.com/0dfc8d3d98d03e9e78fbad471be247792ad04fa2 Cr-Commit-Position: refs/heads/master@{#306700}

Patch Set 1 #

Patch Set 2 : Added backwards compatible changes. #

Patch Set 3 : Fixed small bug in testShortSecureHTTPSUrlWithLightColors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -30 lines) Patch
M chrome/android/java/res/values/colors.xml View 1 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java View 1 6 chunks +25 lines, -9 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java View 1 2 9 chunks +23 lines, -19 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
sashab
6 years ago (2014-12-02 04:50:56 UTC) #2
Ted C
lgtm
6 years ago (2014-12-02 18:14:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/771903003/1
6 years ago (2014-12-02 23:59:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/88948) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/93558) android_aosp ...
6 years ago (2014-12-03 00:04:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/771903003/20001
6 years ago (2014-12-03 04:13:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-03 05:33:52 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0ecb56c7474db0b57c50102adc0ee3815a0182f3 Cr-Commit-Position: refs/heads/master@{#306558}
6 years ago (2014-12-03 05:35:30 UTC) #11
jbudorick
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/749283006/ by jbudorick@chromium.org. ...
6 years ago (2014-12-03 19:30:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/771903003/40001
6 years ago (2014-12-03 22:17:44 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-03 22:53:14 UTC) #15
commit-bot: I haz the power
6 years ago (2014-12-03 22:54:00 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0dfc8d3d98d03e9e78fbad471be247792ad04fa2
Cr-Commit-Position: refs/heads/master@{#306700}

Powered by Google App Engine
This is Rietveld 408576698