Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 771723002: Add support for decoding WebP images (Closed)

Created:
6 years ago by sdefresne
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@chrome-browser-state
Project:
chromium
Visibility:
Public.

Description

Add support for decoding WebP images Add a wrapper around libwebp to decompress WebP images and re-encode them to uncompressed TIFF (if small enough) or JPEG/PNG (dependending on image features). BUG=436897 Committed: https://crrev.com/987f84d0d84d4e59b36ce8532ddcaf174f1346cd Cr-Commit-Position: refs/heads/master@{#308069}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comments #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+632 lines, -0 lines) Patch
M ios/ios_tests_unit.gyp View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
M ios/web/DEPS View 4 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/ios_web.gyp View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download
A ios/web/public/webp_decoder.h View 1 1 chunk +83 lines, -0 lines 0 comments Download
A ios/web/public/webp_decoder.mm View 1 chunk +251 lines, -0 lines 0 comments Download
A ios/web/public/webp_decoder_unittest.mm View 1 chunk +263 lines, -0 lines 0 comments Download
A ios/web/test/data/test.jpg View Binary file 0 comments Download
A ios/web/test/data/test.webp View Binary file 0 comments Download
A ios/web/test/data/test_alpha.png View Binary file 0 comments Download
A ios/web/test/data/test_alpha.webp View Binary file 0 comments Download
A ios/web/test/data/test_small.tiff View Binary file 0 comments Download
A ios/web/test/data/test_small.webp View Binary file 0 comments Download

Messages

Total messages: 27 (10 generated)
sdefresne
droger: Please take a look eugenebut: OWNERS of //ios/web fbarchard: OWNERS of new dependency on ...
6 years ago (2014-12-01 17:16:25 UTC) #1
sdefresne
-eugenebut, +stuartmorgan: OWNERS of //ios/web
6 years ago (2014-12-01 17:18:19 UTC) #3
stuartmorgan
Mostly-rubber-stamp LGTM since it's direct upstreaming. One header nit though. https://codereview.chromium.org/771723002/diff/1/ios/web/public/webp_decoder.h File ios/web/public/webp_decoder.h (right): https://codereview.chromium.org/771723002/diff/1/ios/web/public/webp_decoder.h#newcode69 ...
6 years ago (2014-12-01 18:04:03 UTC) #4
droger
lgtm
6 years ago (2014-12-01 18:15:14 UTC) #5
sdefresne
TBR-ing the dependency on //third_party/libwebp according to the comment in //third_party/OWNERS.
6 years ago (2014-12-02 08:45:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/771723002/20001
6 years ago (2014-12-02 08:45:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/88530) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/38004) android_arm64_dbg_recipe ...
6 years ago (2014-12-02 08:49:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/771723002/40001
6 years ago (2014-12-02 09:02:06 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/98635) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/88536) win_gpu ...
6 years ago (2014-12-02 09:05:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/771723002/60001
6 years ago (2014-12-02 10:27:12 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/32587)
6 years ago (2014-12-02 10:35:13 UTC) #18
sdefresne
fbarchard: can you review the new dependency on third_party/libwebp?
6 years ago (2014-12-10 10:02:40 UTC) #21
fbarchard
lgtm Consider GN support.
6 years ago (2014-12-10 18:24:56 UTC) #22
sdefresne
On 2014/12/10 at 18:24:56, fbarchard wrote: > lgtm > Consider GN support. Thank you for ...
6 years ago (2014-12-10 18:33:30 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/771723002/80001
6 years ago (2014-12-12 09:52:36 UTC) #25
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years ago (2014-12-12 14:36:11 UTC) #26
commit-bot: I haz the power
6 years ago (2014-12-12 14:36:48 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/987f84d0d84d4e59b36ce8532ddcaf174f1346cd
Cr-Commit-Position: refs/heads/master@{#308069}

Powered by Google App Engine
This is Rietveld 408576698