[turbofan] Make context specialization into a reducer.

[turbofan] Make context specialization into a reducer.

R=bmeurer@chromium.org
BUG=

[Benedikt Meurer, 2014-12-01 17:51:57]

https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
File src/compiler/js-context-specialization.cc (right):

https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
src/compiler/js-context-specialization.cc:39: return Reducer::NoChange();
Remove Reducer:: prefix.

https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
src/compiler/js-context-specialization.cc:54: return Reducer::NoChange();
Remove Reducer:: prefix.

https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
src/compiler/js-context-specialization.cc:61: return Reducer::Changed(node);
Remove Reducer:: prefix.

https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
src/compiler/js-context-specialization.cc:79: return Reducer::Replace(constant);
Remove Reducer:: prefix.

https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
src/compiler/js-context-specialization.cc:89: return Reducer::NoChange();
Remove Reducer:: prefix.

https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
src/compiler/js-context-specialization.cc:96: return Reducer::NoChange();
Remove Reducer:: prefix.

https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
src/compiler/js-context-specialization.cc:110: return Reducer::Changed(node);
Remove Reducer:: prefix.

https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
File src/compiler/js-context-specialization.h (right):

https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
src/compiler/js-context-specialization.h:24: virtual Reduction Reduce(Node*
node) OVERRIDE;
According to the style guide there should be at most one of virtual, FINAL,
OVERRIDE per function. So in this case, remove virtual and OVERRIDE and add
FINAL instead.

[titzer, 2014-12-02 09:30:34]

On 2014/12/01 17:51:57, Benedikt Meurer wrote:
>
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
> File src/compiler/js-context-specialization.cc (right):
> 
>
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
> src/compiler/js-context-specialization.cc:39: return Reducer::NoChange();
> Remove Reducer:: prefix.
> 
>
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
> src/compiler/js-context-specialization.cc:54: return Reducer::NoChange();
> Remove Reducer:: prefix.
> 
>
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
> src/compiler/js-context-specialization.cc:61: return Reducer::Changed(node);
> Remove Reducer:: prefix.
> 
>
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
> src/compiler/js-context-specialization.cc:79: return
Reducer::Replace(constant);
> Remove Reducer:: prefix.
> 
>
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
> src/compiler/js-context-specialization.cc:89: return Reducer::NoChange();
> Remove Reducer:: prefix.
> 
>
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
> src/compiler/js-context-specialization.cc:96: return Reducer::NoChange();
> Remove Reducer:: prefix.
> 
>
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
> src/compiler/js-context-specialization.cc:110: return Reducer::Changed(node);
> Remove Reducer:: prefix.
> 

Done.

>
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
> File src/compiler/js-context-specialization.h (right):
> 
>
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-spec...
> src/compiler/js-context-specialization.h:24: virtual Reduction Reduce(Node*
> node) OVERRIDE;
> According to the style guide there should be at most one of virtual, FINAL,
> OVERRIDE per function. So in this case, remove virtual and OVERRIDE and add
> FINAL instead.

Acknowledged, but all the other reducers are wrong too. I'll just keep it
consistent and then we can fix them all at once.

[Benedikt Meurer, 2014-12-02 09:32:46]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2014-12-02 09:32:46]

lgtm

[commit-bot: I haz the power, 2014-12-02 09:33:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/771713002/20001

[commit-bot: I haz the power, 2014-12-02 10:02:44]

Committed patchset #2 (id:20001)