Issue 7717011: Get rid of static TabContentsView::Create function since the interface is in content, but the imp...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7717011: Get rid of static TabContentsView::Create function since the interface is in content, but the imp... (Closed)

Created:
9 years, 4 months ago by jam

Modified:
9 years, 4 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Get rid of static TabContentsView::Create function since the interface is in content, but the implementations are in chrome. Instead ask the embedder to create a TabContentsView. BUG=76697 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98059

Patch Set 1 : '' #

Total comments: 1

Patch Set 2 : stupid gcc error #

Patch Set 3 : Fix SiteInstanceTest #

Patch Set 4 : Fix mac build #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -18 lines)			Patch
M	chrome/browser/chrome_content_browser_client.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View	1	3 chunks	+26 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view_gtk.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view_mac.h	View	1 2 3	2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view_mac.mm	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/tab_contents/tab_contents_view_touch.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	content/browser/content_browser_client.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	content/browser/mock_content_browser_client.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/mock_content_browser_client.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/browser/site_instance_unittest.cc	View	1 2	3 chunks	+13 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

9 years, 4 months ago (2011-08-23 22:46:08 UTC) #2

LGTM with nit

http://codereview.chromium.org/7717011/diff/5002/content/browser/tab_contents...
File content/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/7717011/diff/5002/content/browser/tab_contents...
content/browser/tab_contents/tab_contents.cc:173:
content::GetContentClient()->browser()->CreateTabContentsView(this))),
indent

Expand Messages | Collapse Messages