Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 771583002: Expose aria-pressed as STATE_SYSTEM_PRESSED on windows (Closed)

Created:
6 years ago by shreeramk
Modified:
6 years ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Expose aria-pressed as STATE_SYSTEM_PRESSED on windows According to specs http://rawgit.com/w3c/aria/master/core-aam/core-aam.html aria-pressed {true, mixed} should set STATE_SYSTEM_PRESSED and false should clear STATE_SYSTEM_PRESSED This CL depends on https://codereview.chromium.org/767183002/ BUG=171625 Committed: https://crrev.com/2ba7beabd74e52c5b9624097220cc7506ffb0f50 Cr-Commit-Position: refs/heads/master@{#308073}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -17 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M content/test/data/accessibility/aria-button-expected-win.txt View 1 chunk +5 lines, -6 lines 0 comments Download
M content/test/data/accessibility/aria-pressed-expected-win.txt View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
shreeramk
Please review. Thanks!
6 years ago (2014-12-11 06:36:22 UTC) #2
dmazzoni
lgtm
6 years ago (2014-12-11 23:27:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/771583002/40001
6 years ago (2014-12-12 04:12:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/771583002/60001
6 years ago (2014-12-12 10:45:37 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-12 14:38:43 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-12 14:40:18 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2ba7beabd74e52c5b9624097220cc7506ffb0f50
Cr-Commit-Position: refs/heads/master@{#308073}

Powered by Google App Engine
This is Rietveld 408576698