Improve the logic for hiding the multi-window resize handle

Improve the logic for hiding the multi-window resize handle

Improvements:
- The resize handle no longer hides when a user moves the mouse along the shared
  window edge
- The resize handle no longer hides when a user moves the mouse over the resize
  shadow
- Removed call to redundant MultiWindowResizeController::DelayedHide()

BUG=None
TEST=MultiWindowResizeControllerTest.IsOverWindows

Committed: https://crrev.com/ca6988df595e520e353722bbf5361c4dc0d0ee86
Cr-Commit-Position: refs/heads/master@{#306874}

[pkotwicz, 2014-12-01 04:46:28]

pkotwicz@chromium.org changed reviewers:
+ flackr@chromium.org

[pkotwicz, 2014-12-01 04:46:29]

flackr@ PTAL

[flackr, 2014-12-01 20:19:36]

https://codereview.chromium.org/771543002/diff/1/ash/wm/workspace/multi_windo...
File ash/wm/workspace/multi_window_resize_controller.cc (right):

https://codereview.chromium.org/771543002/diff/1/ash/wm/workspace/multi_windo...
ash/wm/workspace/multi_window_resize_controller.cc:543: ui::EventTarget*
event_handler = static_cast<ui::EventTarget*>(root)
Perhaps cast straight to aura::Window*?

https://codereview.chromium.org/771543002/diff/1/ash/wm/workspace/multi_windo...
ash/wm/workspace/multi_window_resize_controller.cc:556: }
If it only has to be over one of the window's resizer components doesn't this
mean the multi window resizer could still be visible if i horizontally resize
only one of the windows after it has become visible?

https://codereview.chromium.org/771543002/diff/1/ash/wm/workspace/multi_windo...
File ash/wm/workspace/multi_window_resize_controller_unittest.cc (right):

https://codereview.chromium.org/771543002/diff/1/ash/wm/workspace/multi_windo...
ash/wm/workspace/multi_window_resize_controller_unittest.cc:205:
IsOverWindows(gfx::Point(100 + kResizeOutsideBoundsSize - 1, 150)));
This last expect is probably redundant given kResizeOutsideBoundsSize must be
greater than kResizeInsideBoundsSize, but no strong feeling about removing.

[pkotwicz, 2014-12-02 01:22:08]

Rob, can you please take another look?

https://codereview.chromium.org/771543002/diff/1/ash/wm/workspace/multi_windo...
File ash/wm/workspace/multi_window_resize_controller.cc (right):

https://codereview.chromium.org/771543002/diff/1/ash/wm/workspace/multi_windo...
ash/wm/workspace/multi_window_resize_controller.cc:543: ui::EventTarget*
event_handler = static_cast<ui::EventTarget*>(root)
I don't understand what you are saying. aura::Window::GetEventTargeter() is
private.

Yes, aura::Window::GetEventHandlerForPoint() exists, but it returns the wrong
result.

https://codereview.chromium.org/771543002/diff/1/ash/wm/workspace/multi_windo...
ash/wm/workspace/multi_window_resize_controller.cc:556: }
Yes, you are right. Fixing http://crbug.com/437125 is important.

[flackr, 2014-12-02 14:39:49]

lgtm

https://codereview.chromium.org/771543002/diff/1/ash/wm/workspace/multi_windo...
File ash/wm/workspace/multi_window_resize_controller.cc (right):

https://codereview.chromium.org/771543002/diff/1/ash/wm/workspace/multi_windo...
ash/wm/workspace/multi_window_resize_controller.cc:543: ui::EventTarget*
event_handler = static_cast<ui::EventTarget*>(root)
On 2014/12/02 01:22:08, pkotwicz wrote:
> I don't understand what you are saying. aura::Window::GetEventTargeter() is
> private.
> 
> Yes, aura::Window::GetEventHandlerForPoint() exists, but it returns the wrong
> result.

I just meant static_cast<aura::Window*> the result instead of
static_cast<ui::EventTarget*> since it's being used to compare to other
aura::Window*'s, not that it affects the correctness.

[pkotwicz, 2014-12-04 19:01:55]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-12-04 19:02:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/771543002/1

[pkotwicz, 2014-12-04 19:06:23]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2014-12-04 19:07:16]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-12-04 19:08:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/771543002/20001

[commit-bot: I haz the power, 2014-12-04 20:02:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-04 20:04:39]

Patchset 2 (id:??) landed as
https://crrev.com/ca6988df595e520e353722bbf5361c4dc0d0ee86
Cr-Commit-Position: refs/heads/master@{#306874}

[pkotwicz, 2014-12-05 03:03:47]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/776343003/ by pkotwicz@chromium.org.

The reason for reverting is: This CL broke:
FullscreenControllerInteractiveTest.EscapingMouseLock
FullscreenControllerInteractiveTest.TestTabExitsMouseLockOnGoBack
FullscreenControllerInteractiveTest.TestTabExitsMouseLockOnNavigation
.