Implement ES6 @@isConcatSpreadable

test/mjsunit/harmony/array-concat.js

-// Copyright 2008 the V8 project authors. All rights reserved.
-// Redistribution and use in source and binary forms, with or without
-// modification, are permitted provided that the following conditions are
-// met:
-//
-//     * Redistributions of source code must retain the above copyright
-//       notice, this list of conditions and the following disclaimer.
-//     * Redistributions in binary form must reproduce the above
-//       copyright notice, this list of conditions and the following
-//       disclaimer in the documentation and/or other materials provided
-//       with the distribution.
-//     * Neither the name of Google Inc. nor the names of its
-//       contributors may be used to endorse or promote products derived
-//       from this software without specific prior written permission.
-//
-// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
 
-/**
- * @fileoverview Test concat on small and large arrays
- */
+// Flags: --harmony-arrays --harmony-classes
+
+"use strict";
+
+(function testArrayConcatArity() {
+  assertEquals(1, Array.prototype.concat.length);

[Dmitry Lomov (no reviews), 2014/12/10 10:58:21]

Add  a test that validates that concat works correctly on on objects in fast
mode, including Smis and doubles

[caitp (gmail), 2014/12/10 13:25:33]

I'm not sure how to create a non-array object which would take the
FAST_SMI_ELEMENTS or FAST_DOUBLE_ELEMENTS paths --- I have only managed to get
it taking the FAST_ELEMENTS and FAST_HOLEY_ELEMENTS paths, and never
FAST_DOUBLE_ELEMENTS.

+})();
+
+
+(function testArrayConcatNoPrototype() {
+  assertEquals(void 0, Array.prototype.concat.prototype);
+})();
+
+
+(function testArrayConcatDescriptor() {
+  var desc = Object.getOwnPropertyDescriptor(Array.prototype, 'concat');
+  assertEquals(false, desc.enumerable);
+})();
+
+
+(function testConcatArrayLike() {
+  var obj = {
+    "length": 6,
+    "1": "A",
+    "3": "B",
+    "5": "C"
+  };
+  obj[Symbol.isConcatSpreadable] = true;
+  var obj2 = { length: 3, "0": "0", "1": "1", "2": "2" };
+  var arr = ["X", "Y", "Z"];
+  assertEquals([void 0, "A", void 0, "B", void 0, "C",
+               { "length": 3, "0": "0", "1": "1", "2": "2" },
+               "X", "Y", "Z"], Array.prototype.concat.call(obj, obj2, arr));
+})();
+
+
+(function testConcatHoleyArray() {
+  var arr = [];
+  arr[4] = "Item 4";
+  arr[8] = "Item 8";
+  var arr2 = [".", "!", "?"];
+  assertEquals([void 0, void 0, void 0, void 0, "Item 4", void 0, void 0,
+                void 0, "Item 8", ".", "!", "?"], arr.concat(arr2));
+})();
+
+
+(function testIsConcatSpreadableGetterThrows() {
+  function MyError() {}
+  var obj = {};
+  Object.defineProperty(obj, Symbol.isConcatSpreadable, {
+    get: function() { throw new MyError(); }
+  });
+
+  assertThrows(function() {
+    [].concat(obj);
+  }, MyError);
+
+  assertThrows(function() {
+    Array.prototype.concat.call(obj, 1, 2, 3);
+  }, MyError);
+})();
+
+
+(function testConcatLengthThrows() {
+  function MyError() {}
+  var obj = {};
+  obj[Symbol.isConcatSpreadable] = true;
+  Object.defineProperty(obj, "length", {
+    get: function() { throw new MyError(); }
+  });
+
+  assertThrows(function() {
+    [].concat(obj);
+  }, MyError);
+
+  assertThrows(function() {
+    Array.prototype.concat.call(obj, 1, 2, 3);
+  }, MyError);
+})();
+
+
+(function testConcatArraySubclass() {
+  // TODO(caitp): when concat is called on instances of classes which extend
+  // Array, they should:
+  //
+  // - return an instance of the class, rather than an Array instance (if from
+  //   same Realm)
+  // - always treat such classes as concat-spreadable
+})();
+
+
+(function testConcatNonArray() {
+  class NonArray {
+    constructor() { Array.apply(this, arguments); }
+  };
+
+  var obj = new NonArray(1,2,3);
+  var result = Array.prototype.concat.call(obj, 4, 5, 6);
+  assertEquals(Array, result.constructor);
+  assertEquals([obj,4,5,6], result);
+  assertFalse(result instanceof NonArray);
+})();
+
+
+// ES5 tests
 
 var poses;
+var pos;
 
 poses = [140, 4000000000];
 while (pos = poses.shift()) {
   var a = new Array(pos);
   var array_proto = [];
   a.__proto__ = array_proto;
   assertEquals(pos, a.length);
   a.push('foo');
   assertEquals(pos + 1, a.length);
   var b = ['bar'];
@@ skipping 52 matching lines @@
 
   // Negative indices don't get concated.
   a[-1] = 'minus1';
   assertEquals("minus1", a[-1]);
   assertEquals("undefined", typeof(a[0xffffffff]));
   c = a.concat(b);
   assertEquals("undefined", typeof(c[-1]));
   assertEquals("undefined", typeof(c[0xffffffff]));
   assertEquals(c.length, a.length + 1);
 }
-
+/*

[Dmitry Lomov (no reviews), 2014/12/10 10:58:20]

Stray comments

[caitp (gmail), 2014/12/10 13:25:33]

Yeah, I had these commented out because they caused hangs when implemented in JS
--- these were removed in patch set 3

[Dmitry Lomov (no reviews), 2014/12/10 14:41:59]

Oops sorry.

 poses = [140, 4000000000];
 while (pos = poses.shift()) {
   var a = new Array(pos);
   assertEquals(pos, a.length);
   a.push('foo');
   assertEquals(pos + 1, a.length);
   var b = ['bar'];
   var c = a.concat(b);
   assertEquals(pos + 2, c.length);
   assertEquals("undefined", typeof(c[pos - 1]));
@@ skipping 112 matching lines @@
 function mkGetter(i) { return function() { trace.push(i); }; }
 arr3.length = 10000;
 for (var i = 0; i < 100; i++) {
   Object.defineProperty(arr3, i * i, {get: mkGetter(i)});
   expectedTrace[i] = i;
   expectedTrace[100 + i] = i;
 }
 var r4 = [0].concat(arr3, arr3);
 assertEquals(1 + arr3.length * 2, r4.length);
 assertEquals(expectedTrace, trace);
+*/