Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 771353004: Make sure Legacy HWND is created and has proper bounds on bounds change. (Closed)

Created:
6 years ago by dmazzoni
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@legacy_fix_ondestroy
Project:
chromium
Visibility:
Public.

Description

Make sure Legacy HWND is created and has proper bounds on bounds change. BUG=436218 Committed: https://crrev.com/ffd2bddecb7349d0595dd87e802e08e37f18dc28 Cr-Commit-Position: refs/heads/master@{#307160}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +11 lines, -0 lines 2 comments Download

Messages

Total messages: 11 (3 generated)
dmazzoni
6 years ago (2014-12-05 18:12:12 UTC) #2
ananta
lgtm https://codereview.chromium.org/771353004/diff/1/content/browser/web_contents/web_contents_view_aura.cc File content/browser/web_contents/web_contents_view_aura.cc (right): https://codereview.chromium.org/771353004/diff/1/content/browser/web_contents/web_contents_view_aura.cc#newcode1485 content/browser/web_contents/web_contents_view_aura.cc:1485: CHECK(parent_hwnd); Please verify if this does not crash ...
6 years ago (2014-12-05 19:58:02 UTC) #3
dmazzoni
Thanks! Please check out the other legacy HWND code review I sent, too. https://codereview.chromium.org/771353004/diff/1/content/browser/web_contents/web_contents_view_aura.cc File ...
6 years ago (2014-12-05 20:56:06 UTC) #4
dmazzoni
+avi for owners review
6 years ago (2014-12-05 21:12:24 UTC) #6
Avi (use Gerrit)
lgtm Um, OK?
6 years ago (2014-12-05 22:03:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/771353004/1
6 years ago (2014-12-06 05:38:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-06 06:17:11 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-06 06:17:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffd2bddecb7349d0595dd87e802e08e37f18dc28
Cr-Commit-Position: refs/heads/master@{#307160}

Powered by Google App Engine
This is Rietveld 408576698