Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 77133005: Use wildcard for libcxxabi file list (Closed)

Created:
7 years, 1 month ago by Mark Seaborn
Modified:
7 years, 1 month ago
Reviewers:
JF
CC:
native-client-reviews_googlegroups.com
Base URL:
https://git.chromium.org/git/native_client/pnacl-libcxx.git@master
Visibility:
Public.

Description

Use wildcard for libcxxabi file list This will make it easier to update libcxxabi without requiring an awkward cross-repo change when the list of source files changes. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3696 TEST=build libc++ (PNaCl toolchain trybots) Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-libcxx.git;a=commit;h=611cf8f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -19 lines) Patch
M lib/CMakeLists.txt View 1 chunk +3 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Seaborn
7 years, 1 month ago (2013-11-20 20:49:05 UTC) #1
JF
lgtm Just to clarify, the 17 *.cpp files are the only ones currently in the ...
7 years, 1 month ago (2013-11-20 20:54:22 UTC) #2
Mark Seaborn
On 20 November 2013 12:54, <jfb@chromium.org> wrote: > lgtm > > Just to clarify, the ...
7 years, 1 month ago (2013-11-20 22:01:52 UTC) #3
Mark Seaborn
7 years, 1 month ago (2013-11-20 22:14:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r611cf8f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698