Issue 771323006: Make it possible to turn on OBJECT_PRINT without DEBUG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 771323006: Make it possible to turn on OBJECT_PRINT without DEBUG (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)

Modified:
6 years ago

Reviewers:
Michael Achenbach

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

Make it possible to turn on OBJECT_PRINT without DEBUG BUG=none R=machenbach@chromium.org LOG=n NOTREECHECKS=true

Patch Set 2 : updates #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -6 lines)			Patch
M	src/objects.h	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	src/objects-printer.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/transitions.h	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Achenbach

lgtm (rubber stamp) with a comment: https://codereview.chromium.org/771323006/diff/1/build/features.gypi File build/features.gypi (right): https://codereview.chromium.org/771323006/diff/1/build/features.gypi#newcode38 build/features.gypi:38: 'v8_enable_verify_heap%': 1, Why ...

6 years ago (2014-12-09 13:52:13 UTC) #2

jochen (gone - plz use gerrit)

good catch. i used that just for testing compilation locally... reverted features.gypi

6 years ago (2014-12-09 13:53:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/771323006/20001

6 years ago (2014-12-09 13:53:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 771323006: Make it possible to turn on OBJECT_PRINT without DEBUG (Closed)

Description

Patch Set 1 #

Patch Set 2 : updates #

Messages