Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 771323004: Expose Fetch API related classes to Window and WorkerGlobalScope. (Closed)

Created:
6 years ago by yhirano
Modified:
6 years ago
Reviewers:
horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, arv+blink, tzik, serviceworker-reviews, nhiroki, falken, blink-reviews-bindings_chromium.org, horo+watch_chromium.org, kinuko+serviceworker
Base URL:
https://chromium.googlesource.com/chromium/blink.git@exposed-runtime-enabled
Project:
blink
Visibility:
Public.

Description

Expose Fetch API related classes to Window and WorkerGlobalScope. Expose Request, Response and Headers to Window and WorkerGlobalScope under "GlobalFetch" runtime enabled flag. BUG=436770 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186953

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -6 lines) Patch
A LayoutTests/http/tests/fetch/request.html View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/fetch/resources/request.js View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/fetch/workers/request.html View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 2 chunks +22 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 2 chunks +22 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 2 chunks +22 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/Headers.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/serviceworkers/Request.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/serviceworkers/Response.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
yhirano
PTAL This CL depends on https://codereview.chromium.org/789473002/.
6 years ago (2014-12-09 08:07:03 UTC) #2
Jens Widell
https://codereview.chromium.org/771323004/diff/1/Source/bindings/scripts/utilities.py File Source/bindings/scripts/utilities.py (right): https://codereview.chromium.org/771323004/diff/1/Source/bindings/scripts/utilities.py#newcode182 Source/bindings/scripts/utilities.py:182: match = re.search(r'Exposed\(([^)]*)\)', file_contents, flags=re.DOTALL) Put a "\b" before ...
6 years ago (2014-12-09 09:20:54 UTC) #3
yhirano
Moved Source/bindings change to https://codereview.chromium.org/789473002/, as discussed there.
6 years ago (2014-12-09 10:14:09 UTC) #4
yhirano
Removed jl@opera.com and bashi@chromium.org from reviewers because there are not bindings change now.
6 years ago (2014-12-09 10:14:54 UTC) #6
horo
Could you please add LayoutTests which create the objects of these classes in Window and ...
6 years ago (2014-12-09 10:30:39 UTC) #7
yhirano
On 2014/12/09 10:30:39, horo wrote: > Could you please add LayoutTests which create the objects ...
6 years ago (2014-12-09 11:33:09 UTC) #8
horo
lgtm Thank you!
6 years ago (2014-12-09 11:44:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/771323004/80001
6 years ago (2014-12-11 12:16:27 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-11 15:25:59 UTC) #12
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186953

Powered by Google App Engine
This is Rietveld 408576698