Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 771323002: Remove a couple more core/ header includes from v8_inspector (Closed)

Created:
6 years ago by eseidel
Modified:
6 years ago
Reviewers:
yurys
CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove a couple more core/ header includes from v8_inspector Removed all uses of Frame in InspectorTraceEvents in the process, since none of them actually needed a Frame (since each sky instance only has one frame). I've just been burning down the list of core includes using: grep "#include" sky/engine/v8_inspector/* -h | sort | uniq | sort | grep core TBR=yurys@chromium.org BUG=435243 Committed: https://chromium.googlesource.com/external/mojo/+/d88bb922f71fe78adf5c32e4e0a2ba79e00b3e34

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -108 lines) Patch
M sky/engine/bindings/core/v8/ScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/frame/FrameView.h View 1 chunk +3 lines, -0 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 chunk +19 lines, -0 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/frame/LocalFrame.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/frame/LocalFrame.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M sky/engine/core/inspector/InspectorTraceEvents.h View 4 chunks +5 lines, -6 lines 1 comment Download
M sky/engine/core/inspector/InspectorTraceEvents.cpp View 11 chunks +9 lines, -42 lines 0 comments Download
M sky/engine/core/loader/FrameFetchContext.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/v8_inspector/AsyncCallStackTracker.cpp View 1 chunk +0 lines, -1 line 1 comment Download
M sky/engine/v8_inspector/PageDebuggerAgent.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/v8_inspector/PageScriptDebugServer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/v8_inspector/PageScriptDebugServer.cpp View 2 chunks +1 line, -13 lines 0 comments Download
M sky/engine/v8_inspector/ScriptDebugServer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/v8_inspector/ScriptDebugServer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/v8_inspector/ScriptPreprocessor.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
eseidel
6 years ago (2014-12-02 21:29:09 UTC) #1
eseidel
Committed patchset #1 (id:1) manually as d88bb922f71fe78adf5c32e4e0a2ba79e00b3e34.
6 years ago (2014-12-02 21:38:07 UTC) #2
yurys
lgtm https://codereview.chromium.org/771323002/diff/1/sky/engine/core/inspector/InspectorTraceEvents.h File sky/engine/core/inspector/InspectorTraceEvents.h (right): https://codereview.chromium.org/771323002/diff/1/sky/engine/core/inspector/InspectorTraceEvents.h#newcode28 sky/engine/core/inspector/InspectorTraceEvents.h:28: class InspectorLayoutEvent { It might make sense to ...
6 years ago (2014-12-03 07:33:36 UTC) #3
eseidel
6 years ago (2014-12-03 07:42:38 UTC) #4
Message was sent while issue was closed.
We definitely have tracing support in sky, although unclear how much of that
routes to the devtools profiling.  I think it might actually make sense to wire
up the profiling panel, I just haven't looked at doing that yet.

Powered by Google App Engine
This is Rietveld 408576698