Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 771283003: Revert of Cleanup: Update the path to vector2d_f.h header. (Closed)

Created:
6 years ago by samli
Modified:
6 years ago
Reviewers:
danakj, tfarina, sky
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, tdanderson+views_chromium.org, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org, James Su, jdduke+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Cleanup: Update the path to vector2d_f.h header. (patchset #1 id:1 of https://codereview.chromium.org/781863004/) Reason for revert: Breaks Win8 GN and Win8 GN(dbg) builders Original issue's description: > Cleanup: Update the path to vector2d_f.h header. > > The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so > we are updating the include paths to fix this. > > BUG=395370 > TEST=gfx_unittests > TBR=sky@chromium.org,danakj@chromium.org > > Committed: https://crrev.com/b486216287a3e1f30e81f70444f889d321b7819a > Cr-Commit-Position: refs/heads/master@{#306960} TBR=danakj@chromium.org,sky@chromium.org,tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=395370 Committed: https://crrev.com/0dffffd306e8e21bd027b26e947ec8b5ffcdfa51 Cr-Commit-Position: refs/heads/master@{#306962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -36 lines) Patch
M android_webview/browser/browser_view_renderer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/android/in_process/synchronous_input_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/overscroll_glow.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/android/overscroll_refresh.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/input_messages.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/public/browser/android/synchronous_compositor_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_handler_manager_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/android/window_android.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/transform.h View 1 chunk +1 line, -1 line 0 comments Download
A ui/gfx/vector2d_f.h View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
samli
Created Revert of Cleanup: Update the path to vector2d_f.h header.
6 years ago (2014-12-05 03:07:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/771283003/1
6 years ago (2014-12-05 03:08:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-05 03:09:39 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0dffffd306e8e21bd027b26e947ec8b5ffcdfa51 Cr-Commit-Position: refs/heads/master@{#306962}
6 years ago (2014-12-05 03:10:36 UTC) #4
tfarina
Samuel, could you post here the failure you think this might have caused? I'm very ...
6 years ago (2014-12-05 14:21:13 UTC) #5
tfarina
6 years ago (2014-12-05 14:22:33 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/762063006/ by tfarina@chromium.org.

The reason for reverting is: This didn't cause the issue. As noted in
https://codereview.chromium.org/781863004/#msg8.

Powered by Google App Engine
This is Rietveld 408576698