Fix focus regression in chrome://settings/editDictionary.

chrome/browser/resources/options/inline_editable_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var DeletableItem = options.DeletableItem;
   /** @const */ var DeletableItemList = options.DeletableItemList;
 
   /**
    * Creates a new list item with support for inline editing.
@@ skipping 633 matching lines @@
           element.focusedColumnIndex = focusedColumnIndex;
           element.updateLeadState();
         }
       }
     },
 
     /** @override */
     onSetDataModelComplete: function() {
       DeletableItemList.prototype.onSetDataModelComplete.call(this);
 
-      var firstItem = this.getListItemByIndex(0);
-      if (firstItem) {
-        firstItem.setStaticValuesFocusable(true);
-        firstItem.setCloseButtonFocusable(true);
-        if (firstItem.isPlaceholder)
-          firstItem.setEditableValuesFocusable(true);
+      var item = this.getInitialFocusableItem();
+      if (item) {
+        item.setStaticValuesFocusable(true);
+        item.setCloseButtonFocusable(true);
+        if (item.isPlaceholder)
+          item.setEditableValuesFocusable(true);
       }
     },
 
     /**
      * May be overridden by subclasses to disable focusing the placeholder.
      * @return {boolean} True if the placeholder element should be focused on
      *     edit commit.
      */
     shouldFocusPlaceholder: function() {
       return true;
     },
+
+    /**
+    * Override to change which item is initially focusable.
+    * @return {options.InlineEditableItem} Initially focusable item or null.
+    * @protected
+    */
+    getInitialFocusableItem: function() {

[bondd, 2014/12/02 20:35:02]

I made this a regular method instead of an ECMA 5 getter because AFAIK the
syntax for overriding a getter is messier than overriding a regular method, and
the entire point of this method is to be overridden.

[Dan Beam, 2014/12/03 01:40:33]

Acknowledged.

+      return this.getListItemByIndex(0);
+    },
   };
 
   // Export
   return {
     InlineEditableItem: InlineEditableItem,
     InlineEditableItemList: InlineEditableItemList,
   };
 });