Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 771223002: NaCl: Update revision in DEPS, r14147 -> r14158 (Closed)

Created:
6 years ago by Mark Seaborn
Modified:
6 years ago
Reviewers:
Derek Schuff
CC:
chromium-reviews, bradn, Derek Schuff, David Yen, hamaji, jvoung - send to chromium..., native-client-reviews_googlegroups.com, petarj, teravest
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r14147 -> r14158 This pulls in the following Native Client changes: r14148: (dschuff) PNaCl: Update LLVM/clang/binutils-x86 revision in pnacl/COMPONENT_REVISIONS r14149: (hamaji) Update revision for PNaCl r14144->r14148 r14150: (petarj) Fix issue in DecodeEscaping() in debug_stub test r14151: (mseaborn) Remove much of the unused parts of pnacl/build.sh r14152: (bradnelson) Nest the pnacl section of untrusted.gypi to the same level. r14153: (dyen) The cached results from toolchain_build should be deterministic. r14154: (jvoung) Add options for base dir and redirecting files to IRT open resource and use it. r14155: (dschuff) nacl-clang: use gas by default instead of the LLVM assembler r14156: (dyen) Toolchain testing within the NaCl tree now use the raw variants. r14157: (teravest) Clean up unused NaClDesc quota code. r14158: (dschuff) Revert SCons portion of r14155 BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk,linux_chromium_dbg

Patch Set 1 #

Patch Set 2 : Retry upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Mark Seaborn
6 years ago (2014-12-02 19:02:45 UTC) #2
Derek Schuff
lgtm
6 years ago (2014-12-02 19:07:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/771223002/20001
6 years ago (2014-12-02 19:14:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_rel_precise32 on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_rel_precise32/builds/271)
6 years ago (2014-12-03 02:12:16 UTC) #7
Mark Seaborn
6 years ago (2014-12-03 19:23:44 UTC) #8
This DEPS roll is causing "nacl_integration" to fail with:

Exception: Cannot find a toolchain for x86-32 in
/mnt/data/b/build/slave/linux_precise32/build/src/native_client/toolchain/linux_x86/nacl_x86_newlib_raw:
...
  File
"/mnt/data/b/build/slave/linux_precise32/build/src/native_client/site_scons/site_tools/naclsdk.py",
line 100:
    (env['TARGET_FULLARCH'], sdk_path))

Strangely, this is failing on all the trybots that run nacl_integration, but
most of the trybots are ignoring the failure.  I've filed a bug about that:
https://code.google.com/p/chromium/issues/detail?id=438703

Powered by Google App Engine
This is Rietveld 408576698