Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 771183003: MachMessageWithDeadline(): 10.6 SDK fix (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

MachMessageWithDeadline(): 10.6 SDK fix. In the pre-C++11 10.6 SDK, std::numeric_limits<>::max() is not marked constexpr and cannot be used to initialize enum elements. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/eee9de7361cc448d80653fe8e04f89b7c24c7e16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M util/mach/mach_message.h View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years ago (2014-12-02 22:20:09 UTC) #2
Robert Sesek
LGTM
6 years ago (2014-12-02 22:21:41 UTC) #3
Mark Mentovai
6 years ago (2014-12-02 23:37:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eee9de7361cc448d80653fe8e04f89b7c24c7e16 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698