Issue 771093002: Use a JS markup serializer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 771093002: Use a JS markup serializer. (Closed)

Created:
6 years ago by esprehn

Modified:
6 years ago

Reviewers:
abarth-chromium, eseidel, ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Use a JS markup serializer. This makes MarkupAccumulator and all related code into dead code. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/08c7757377517a8c67e5b8bf12744480d5dc2dd4

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -21 lines)			Patch
M	sky/engine/public/web/WebFrame.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sky/engine/web/WebLocalFrameImpl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/web/WebLocalFrameImpl.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download
A	sky/framework/dom-serializer.sky	View	1 chunk	+74 lines, -0 lines	0 comments	Download
M	sky/tests/parser/html.sky	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/tests/parser/html-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/tests/resources/dump-as-markup.sky	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sky/viewer/internals.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/viewer/internals.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download

Total messages: 5 (2 generated)

esprehn

6 years ago (2014-12-02 18:09:41 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
08c7757377517a8c67e5b8bf12744480d5dc2dd4 (presubmit successful).