Rename AppListMainViewTest::ContentsView to AppListMainViewTest::GetContentsView to fix build break

Rename AppListMainViewTest::ContentsView to AppListMainViewTest::GetContentsView to avoid build failure

The usage of unqualified ContentsView causes the build failure while using gcc 4.8 toolchain as below

ui/app_list/views/app_list_main_view_unittest.cc:157:70:
error: declaration of ‘app_list::ContentsView* app_list::test::{anonymous}::AppListMainViewTest::ContentsView()’ [-fpermissive]
   ContentsView* ContentsView() { return main_view_->contents_view(); }
                                                                      ^
In file included from ../../ui/app_list/views/app_list_main_view_unittest.cc:18:0:
ui/app_list/views/contents_view.h:45:7: error: changes meaning of ‘ContentsView’ from ‘class app_list::ContentsView’ [-fpermissive]
 class APP_LIST_EXPORT ContentsView : public views::View,

Committed: https://crrev.com/381fea549f67c655b991b77cefe2c468d81c754d
Cr-Commit-Position: refs/heads/master@{#306360}

[vivekg, 2014-12-02 04:10:52]

vivekg@chromium.org changed reviewers:
+ calamity@chromium.org, mgiuca@chromium.org, vivekg@chromium.org

[vivekg, 2014-12-02 04:10:53]

PTAL, thanks!

[Matt Giuca, 2014-12-02 04:33:37]

https://codereview.chromium.org/771063002/diff/1/ui/app_list/views/app_list_m...
File ui/app_list/views/app_list_main_view_unittest.cc (right):

https://codereview.chromium.org/771063002/diff/1/ui/app_list/views/app_list_m...
ui/app_list/views/app_list_main_view_unittest.cc:157: app_list::ContentsView*
ContentsView() { return main_view_->contents_view(); }
I'm not too sure about this, but I asked around and was told that the root cause
of this issue is not the namespacing, but the fact that ContentsView is the name
of both the method and the class.

We should *not* have to explicitly qualify this type. The correct fix (I think)
is to just rename the method. The correct name for this method is
contents_view() or GetContentsView(). I prefer contents_view() since the
accessor is reasonably simple. Would you be able to rename it and try again?

(Don't worry about renaming these other methods; there would be too many places
to update.)

[vivekg, 2014-12-02 04:56:43]

On 2014/12/02 at 04:33:37, mgiuca wrote:
>
https://codereview.chromium.org/771063002/diff/1/ui/app_list/views/app_list_m...
> File ui/app_list/views/app_list_main_view_unittest.cc (right):
> 
>
https://codereview.chromium.org/771063002/diff/1/ui/app_list/views/app_list_m...
> ui/app_list/views/app_list_main_view_unittest.cc:157: app_list::ContentsView*
ContentsView() { return main_view_->contents_view(); }
> I'm not too sure about this, but I asked around and was told that the root
cause of this issue is not the namespacing, but the fact that ContentsView is
the name of both the method and the class.

I just stumbled upon this stack overflow discussion about the similar problem.
http://stackoverflow.com/a/283463

> 
> We should *not* have to explicitly qualify this type. The correct fix (I
think) is to just rename the method. The correct name for this method is
contents_view() or GetContentsView(). I prefer contents_view() since the
accessor is reasonably simple. Would you be able to rename it and try again?
> 
> (Don't worry about renaming these other methods; there would be too many
places to update.)

Sure, will do and upload it again. Thanks!

[vivekg, 2014-12-02 05:13:43]

Uploaded a new patch, PTAL. Thanks!

[Matt Giuca, 2014-12-02 06:13:18]

https://codereview.chromium.org/771063002/diff/20001/ui/app_list/views/app_li...
File ui/app_list/views/app_list_main_view_unittest.cc (right):

https://codereview.chromium.org/771063002/diff/20001/ui/app_list/views/app_li...
ui/app_list/views/app_list_main_view_unittest.cc:301: app_list::ContentsView*
contents_view_ptr = contents_view();
I don't like the name "contents_view_ptr". It's unfortunate you had to rename
this as well.

Suggest renaming the method to GetContentsView and then this variable can remain
as contents_view.

[vivekg, 2014-12-02 06:15:38]

On 2014/12/02 at 06:13:18, mgiuca wrote:
>
https://codereview.chromium.org/771063002/diff/20001/ui/app_list/views/app_li...
> File ui/app_list/views/app_list_main_view_unittest.cc (right):
> 
>
https://codereview.chromium.org/771063002/diff/20001/ui/app_list/views/app_li...
> ui/app_list/views/app_list_main_view_unittest.cc:301: app_list::ContentsView*
contents_view_ptr = contents_view();
> I don't like the name "contents_view_ptr". It's unfortunate you had to rename
this as well.
> 
> Suggest renaming the method to GetContentsView and then this variable can
remain as contents_view.

Done, PTAL.

[Matt Giuca, 2014-12-02 06:24:56]

lgtm, thanks!

[vivekg, 2014-12-02 06:25:18]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-12-02 06:26:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/771063002/40001

[commit-bot: I haz the power, 2014-12-02 10:43:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-02 10:44:45]

Patchset 3 (id:??) landed as
https://crrev.com/381fea549f67c655b991b77cefe2c468d81c754d
Cr-Commit-Position: refs/heads/master@{#306360}