Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 771043002: Move surfaces service implementation to //services (Closed)

Created:
6 years ago by jamesr
Modified:
6 years ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -494 lines) Patch
M mojo/services/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/services/surfaces/BUILD.gn View 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/services/surfaces/DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/services/surfaces/surfaces_impl.h View 1 chunk +0 lines, -92 lines 0 comments Download
D mojo/services/surfaces/surfaces_impl.cc View 1 chunk +0 lines, -139 lines 0 comments Download
D mojo/services/surfaces/surfaces_service_application.h View 1 chunk +0 lines, -54 lines 0 comments Download
D mojo/services/surfaces/surfaces_service_application.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D mojo/services/surfaces/surfaces_service_impl.h View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/services/surfaces/surfaces_service_impl.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M services/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + services/surfaces/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/surfaces/surfaces_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/surfaces/surfaces_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/surfaces/surfaces_service_application.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + services/surfaces/surfaces_service_application.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/surfaces/surfaces_service_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/surfaces/surfaces_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
jamesr
6 years ago (2014-12-02 20:37:24 UTC) #2
sky
LGTM
6 years ago (2014-12-02 20:55:55 UTC) #3
jamesr
6 years ago (2014-12-02 21:14:07 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f52517f7e4403640695c5c0d75a3d9defc326b61 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698