Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: src/objects-inl.h

Issue 771033003: Revert of Use weak cells in map checks in polymorphic ICs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 5798 matching lines...) Expand 10 before | Expand all | Expand 10 after
5809 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_flush, kDontFlush) 5809 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_flush, kDontFlush)
5810 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_arrow, kIsArrow) 5810 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_arrow, kIsArrow)
5811 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_generator, kIsGenerator) 5811 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_generator, kIsGenerator)
5812 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_concise_method, 5812 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_concise_method,
5813 kIsConciseMethod) 5813 kIsConciseMethod)
5814 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_default_constructor, 5814 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_default_constructor,
5815 kIsDefaultConstructor) 5815 kIsDefaultConstructor)
5816 5816
5817 ACCESSORS(CodeCache, default_cache, FixedArray, kDefaultCacheOffset) 5817 ACCESSORS(CodeCache, default_cache, FixedArray, kDefaultCacheOffset)
5818 ACCESSORS(CodeCache, normal_type_cache, Object, kNormalTypeCacheOffset) 5818 ACCESSORS(CodeCache, normal_type_cache, Object, kNormalTypeCacheOffset)
5819 ACCESSORS(CodeCache, weak_cell_cache, Object, kWeakCellCacheOffset)
5820 5819
5821 ACCESSORS(PolymorphicCodeCache, cache, Object, kCacheOffset) 5820 ACCESSORS(PolymorphicCodeCache, cache, Object, kCacheOffset)
5822 5821
5823 bool Script::HasValidSource() { 5822 bool Script::HasValidSource() {
5824 Object* src = this->source(); 5823 Object* src = this->source();
5825 if (!src->IsString()) return true; 5824 if (!src->IsString()) return true;
5826 String* src_str = String::cast(src); 5825 String* src_str = String::cast(src);
5827 if (!StringShape(src_str).IsExternal()) return true; 5826 if (!StringShape(src_str).IsExternal()) return true;
5828 if (src_str->IsOneByteRepresentation()) { 5827 if (src_str->IsOneByteRepresentation()) {
5829 return ExternalOneByteString::cast(src)->resource() != NULL; 5828 return ExternalOneByteString::cast(src)->resource() != NULL;
(...skipping 1685 matching lines...) Expand 10 before | Expand all | Expand 10 after
7515 #undef READ_SHORT_FIELD 7514 #undef READ_SHORT_FIELD
7516 #undef WRITE_SHORT_FIELD 7515 #undef WRITE_SHORT_FIELD
7517 #undef READ_BYTE_FIELD 7516 #undef READ_BYTE_FIELD
7518 #undef WRITE_BYTE_FIELD 7517 #undef WRITE_BYTE_FIELD
7519 #undef NOBARRIER_READ_BYTE_FIELD 7518 #undef NOBARRIER_READ_BYTE_FIELD
7520 #undef NOBARRIER_WRITE_BYTE_FIELD 7519 #undef NOBARRIER_WRITE_BYTE_FIELD
7521 7520
7522 } } // namespace v8::internal 7521 } } // namespace v8::internal
7523 7522
7524 #endif // V8_OBJECTS_INL_H_ 7523 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698