Issue 770903004: IDL: Include DOMTypedArray.h when a dictionary has typed array members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 770903004: IDL: Include DOMTypedArray.h when a dictionary has typed array members (Closed)

Created:
6 years ago by bashi

Modified:
6 years ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

IDL: Include DOMTypedArray.h when a dictionary has typed array members impl_includes_for_type() needs to be aware of type arrays, otherwise, the code generator generates .cpp files which contain non-exist header files. BUG=321462 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186284

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -0 lines)			Patch
M	Source/bindings/scripts/v8_types.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/bindings/tests/idls/core/TestDictionary.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/tests/results/core/TestDictionary.h	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	Source/bindings/tests/results/core/V8TestDictionary.cpp	View	3 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

bashi

PTAL? I found this bug when I try to implement MIDIMessageEventInit. http://webaudio.github.io/web-midi-api/#idl-def-MIDIMessageEventInit

6 years ago (2014-12-02 05:48:08 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/770903004/1

6 years ago (2014-12-02 05:50:45 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-02 09:00:55 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186284

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages