Issue 7709020: Moving the ViewHostMsg_PDFHasUnsupportedFeature IPC message to Chrome as PDF is a chrome specific

Issue 7709020: Moving the ViewHostMsg_PDFHasUnsupportedFeature IPC message to Chrome as PDF is a chrome specific (Closed)

Created:
9 years, 4 months ago by ananta

Modified:
9 years, 4 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Moving the ViewHostMsg_PDFHasUnsupportedFeature IPC message to Chrome as PDF is a chrome specific feature. Removed the HasUnsupportedFeature method from the pepper PluginDelegate interface as it is only needed for PDF. BUG=87335 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97890

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -24 lines)			Patch
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/render_messages.h	View	1	2 chunks	+10 lines, -6 lines	0 comments	Download
M	chrome/renderer/chrome_ppb_pdf_impl.cc	View	1 2 3	2 chunks	+8 lines, -1 line	0 comments	Download
M	content/common/view_messages.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/renderer/pepper_plugin_delegate_impl.h	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/renderer/pepper_plugin_delegate_impl.cc	View	1 2 3	2 chunks	+4 lines, -5 lines	0 comments	Download
M	webkit/plugins/ppapi/mock_plugin_delegate.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/mock_plugin_delegate.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_delegate.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

http://codereview.chromium.org/7709020/diff/12/content/renderer/pepper_plugin_delegate_impl.cc File content/renderer/pepper_plugin_delegate_impl.cc (right): http://codereview.chromium.org/7709020/diff/12/content/renderer/pepper_plugin_delegate_impl.cc#newcode1476 content/renderer/pepper_plugin_delegate_impl.cc:1476: return render_view_ ? render_view_->routing_id() : 0; are you sure ...

9 years, 4 months ago (2011-08-23 02:44:30 UTC) #2

ananta

9 years, 4 months ago (2011-08-23 18:14:03 UTC) #4

http://codereview.chromium.org/7709020/diff/12/content/renderer/pepper_plugin...
File content/renderer/pepper_plugin_delegate_impl.cc (right):

http://codereview.chromium.org/7709020/diff/12/content/renderer/pepper_plugin...
content/renderer/pepper_plugin_delegate_impl.cc:1476: return render_view_ ?
render_view_->routing_id() : 0;
On 2011/08/23 02:44:30, John Abd-El-Malek wrote:
> are you sure you need to handle the NULL render_view_ case? we didn't before.
Removed the NULL check

http://codereview.chromium.org/7709020/diff/12/content/renderer/pepper_plugin...
File content/renderer/pepper_plugin_delegate_impl.h (right):

http://codereview.chromium.org/7709020/diff/12/content/renderer/pepper_plugin...
content/renderer/pepper_plugin_delegate_impl.h:306: int GetRenderViewRoutingId()
const;
On 2011/08/23 02:44:30, John Abd-El-Malek wrote:
> nit: you can just say GetRoutingId() without mentioning RenderView

Done.

Expand Messages | Collapse Messages