Issue 770843002: harmony-classes: Fix some issues with syntactic restriction on super(...).

Issue 770843002: harmony-classes: Fix some issues with syntactic restriction on super(...). (Closed)

Created:
6 years ago by Dmitry Lomov (no reviews)

Modified:
6 years ago

Reviewers:
arv, arv (Not doing code reviews)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

harmony-classes: Fix some issues with syntactic restriction on super(...). R=arv@chromium.org BUG=v8:3330 LOG=N

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -12 lines)			Patch
M	src/ast-this-access-visitor.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ast-this-access-visitor.cc	View	4 chunks	+16 lines, -9 lines	0 comments	Download
M	src/scopes.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/mjsunit/harmony/classes.js	View	2 chunks	+28 lines, -0 lines	0 comments	Download

Total messages: 9 (4 generated)

Dmitry Lomov (no reviews)

PTAL. Addressed all your comments except for message location, also fixed some issues with super ...

6 years ago (2014-12-01 18:48:24 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/770843002/1

6 years ago (2014-12-01 19:45:58 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/770843002/1

6 years ago (2014-12-01 19:50:17 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1)