Gold translator: Use IRT open_resource instead of SRPC conn to nameservice.

Gold translator: Use IRT open_resource instead of SRPC conn to nameservice.

Chrome is expected to still support both until we have
updated all users to have this newer copy of gold.

Not keeping the old codepath for transitional purposes,
so this relies on the following NaCl CL for a DEPS roll:
https://codereview.chromium.org/731423004/

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3914
R=dschuff@chromium.org, mseaborn@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/nacl-binutils.git;a=commit;h=84c8183a55ddc46a4c2be03eef840cceb83d6bcb

[jvoung (off chromium), 2014-12-01 19:12:41]

jvoung@chromium.org changed reviewers:
+ dschuff@chromium.org, mseaborn@chromium.org

[Mark Seaborn, 2014-12-01 19:26:43]

LGTM

https://codereview.chromium.org/770833002/diff/20001/gold/nacl_file.cc
File gold/nacl_file.cc (right):

https://codereview.chromium.org/770833002/diff/20001/gold/nacl_file.cc#newcode36
gold/nacl_file.cc:36: #include "native_client/src/untrusted/irt/irt.h"
I believe this can be #included as <irt.h>, which would be preferable for code
that lives in a separate repo.

https://codereview.chromium.org/770833002/diff/20001/gold/nacl_file.cc#newcode71
gold/nacl_file.cc:71: static struct nacl_irt_resource_open g_irt_resource_open;
"static" not neeed -- this is inside an anon namespace.

Style nit: maybe put this next to the other g_* variable (to keep globals at the
top)

[jvoung (off chromium), 2014-12-01 20:35:19]

https://codereview.chromium.org/770833002/diff/20001/gold/nacl_file.cc
File gold/nacl_file.cc (right):

https://codereview.chromium.org/770833002/diff/20001/gold/nacl_file.cc#newcode36
gold/nacl_file.cc:36: #include "native_client/src/untrusted/irt/irt.h"
On 2014/12/01 19:26:43, Mark Seaborn wrote:
> I believe this can be #included as <irt.h>, which would be preferable for code
> that lives in a separate repo.

Done.

https://codereview.chromium.org/770833002/diff/20001/gold/nacl_file.cc#newcode71
gold/nacl_file.cc:71: static struct nacl_irt_resource_open g_irt_resource_open;
On 2014/12/01 19:26:43, Mark Seaborn wrote:
> "static" not neeed -- this is inside an anon namespace.
> 
> Style nit: maybe put this next to the other g_* variable (to keep globals at
the
> top)

Done.

[Derek Schuff, 2014-12-01 20:51:16]

lgtm

[jvoung (off chromium), 2014-12-01 22:04:58]

Committed patchset #3 (id:40001) manually as
84c8183a55ddc46a4c2be03eef840cceb83d6bcb (presubmit successful).