Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 77083002: Add chromium side flag for enabling/disabling layer squashing. (Closed)

Created:
7 years, 1 month ago by shawnsingh
Modified:
7 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add chromium side flag for enabling/disabling layer squashing. default is off. BUG=315317 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236913

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed reviewer feedback #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M content/renderer/web_preferences.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/common/webpreferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/common/webpreferences.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
shawnsingh
PTAL, thanks. depends on https://codereview.chromium.org/75823002/ so I can do try jobs after that lands. joi@ ...
7 years, 1 month ago (2013-11-20 01:31:04 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/77083002/diff/1/content/browser/renderer_host/render_view_host_impl.cc File content/browser/renderer_host/render_view_host_impl.cc (right): https://codereview.chromium.org/77083002/diff/1/content/browser/renderer_host/render_view_host_impl.cc#newcode435 content/browser/renderer_host/render_view_host_impl.cc:435: prefs.layer_squashing_enabled = this overrides anything you've set above in ...
7 years, 1 month ago (2013-11-20 08:59:45 UTC) #2
shawnsingh
Thanks for review - new patch uploaded. https://codereview.chromium.org/77083002/diff/1/content/browser/renderer_host/render_view_host_impl.cc File content/browser/renderer_host/render_view_host_impl.cc (right): https://codereview.chromium.org/77083002/diff/1/content/browser/renderer_host/render_view_host_impl.cc#newcode435 content/browser/renderer_host/render_view_host_impl.cc:435: prefs.layer_squashing_enabled = ...
7 years, 1 month ago (2013-11-20 18:08:57 UTC) #3
Jói
//content/public LGTM.
7 years, 1 month ago (2013-11-20 18:12:18 UTC) #4
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-21 13:18:16 UTC) #5
jamesr
webkit/ lgtm
7 years ago (2013-11-22 00:01:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/77083002/260001
7 years ago (2013-11-22 23:22:42 UTC) #7
commit-bot: I haz the power
7 years ago (2013-11-23 01:46:55 UTC) #8
Message was sent while issue was closed.
Change committed as 236913

Powered by Google App Engine
This is Rietveld 408576698