Make app list search box into a Widget.

Make app list search box into a Widget.

This CL puts the app list's SearchBoxView inside a Widget in order to
correctly handle events when the custom launcher page WebContents is
behind it.

BUG=437686
Committed: https://crrev.com/2bbabbd1da1c0b1cff0144cc86d6567ccf596365
Cr-Commit-Position: refs/heads/master@{#306583}

[calamity, 2014-12-02 03:44:53]

calamity@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2014-12-02 07:55:15]

lgtm

https://codereview.chromium.org/770813004/diff/1/ui/app_list/views/app_list_v...
File ui/app_list/views/app_list_view.cc (right):

https://codereview.chromium.org/770813004/diff/1/ui/app_list/views/app_list_v...
ui/app_list/views/app_list_view.cc:160: speech_view_(NULL),
nullptr all these.

https://codereview.chromium.org/770813004/diff/1/ui/app_list/views/app_list_v...
ui/app_list/views/app_list_view.cc:408: // SearchBoxView to receive events
before the custom launcher page's
I don't really think of it as "before / after", rather "on top / underneath".
Say "This allows the SearchBoxView to be on top of the custom launcher page's
WebContents (otherwise the search box events will be captured by the
WebContents)." Or similar.

https://codereview.chromium.org/770813004/diff/1/ui/app_list/views/app_list_v...
ui/app_list/views/app_list_view.cc:605: if (search_box_widget_) {
Just checking: Can this be a DCHECK or are there situations where it is null?

[calamity, 2014-12-03 03:31:26]

https://codereview.chromium.org/770813004/diff/1/ui/app_list/views/app_list_v...
File ui/app_list/views/app_list_view.cc (right):

https://codereview.chromium.org/770813004/diff/1/ui/app_list/views/app_list_v...
ui/app_list/views/app_list_view.cc:160: speech_view_(NULL),
On 2014/12/02 07:55:14, Matt Giuca wrote:
> nullptr all these.

Done.

https://codereview.chromium.org/770813004/diff/1/ui/app_list/views/app_list_v...
ui/app_list/views/app_list_view.cc:408: // SearchBoxView to receive events
before the custom launcher page's
On 2014/12/02 07:55:14, Matt Giuca wrote:
> I don't really think of it as "before / after", rather "on top / underneath".
> Say "This allows the SearchBoxView to be on top of the custom launcher page's
> WebContents (otherwise the search box events will be captured by the
> WebContents)." Or similar.

Done.

https://codereview.chromium.org/770813004/diff/1/ui/app_list/views/app_list_v...
ui/app_list/views/app_list_view.cc:605: if (search_box_widget_) {
On 2014/12/02 07:55:14, Matt Giuca wrote:
> Just checking: Can this be a DCHECK or are there situations where it is null?

It's null on initial layout unfortunately. This is because the Widget lays out
its root view when it is created, but the search_box_widget isn't added until
later.

[calamity, 2014-12-03 03:31:30]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-12-03 03:32:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/770813004/40001

[commit-bot: I haz the power, 2014-12-03 04:30:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-03 04:30:45]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[calamity, 2014-12-03 07:16:31]

calamity@chromium.org changed reviewers:
+ plundblad@chromium.org

[calamity, 2014-12-03 07:16:32]

+plundblad for spoked_feedback_browsertest.cc OWNERS.

[calamity, 2014-12-03 07:16:39]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-12-03 07:17:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/770813004/100001

[commit-bot: I haz the power, 2014-12-03 07:21:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-03 07:21:11]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Peter Lundblad, 2014-12-03 10:14:23]

lgtm

[Matt Giuca, 2014-12-03 10:35:38]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-12-03 10:37:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/770813004/100001

[commit-bot: I haz the power, 2014-12-03 10:38:35]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-12-03 10:39:13]

Patchset 6 (id:??) landed as
https://crrev.com/2bbabbd1da1c0b1cff0144cc86d6567ccf596365
Cr-Commit-Position: refs/heads/master@{#306583}