Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: Source/WebCore/ChangeLog

Side-by-side diff isn't available for this file because of its large size.
Issue 7708013: Merge 93042 - Web Inspector: [V8] crash upon stepIn while not on pause. (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/835/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | Source/WebCore/inspector/InspectorDebuggerAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/ChangeLog
===================================================================
--- Source/WebCore/ChangeLog (revision 93524)
+++ Source/WebCore/ChangeLog (working copy)
@@ -1,3 +1,2579 @@
+2011-08-15 Pavel Feldman <pfeldman@google.com>
+
+ Web Inspector: [V8] crash upon stepIn while not on pause.
+ https://bugs.webkit.org/show_bug.cgi?id=66221
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/InspectorDebuggerAgent.cpp:
+ (WebCore::InspectorDebuggerAgent::resume):
+ (WebCore::InspectorDebuggerAgent::stepOver):
+ (WebCore::InspectorDebuggerAgent::stepInto):
+ (WebCore::InspectorDebuggerAgent::stepOut):
+ (WebCore::InspectorDebuggerAgent::assertPaused):
+ * inspector/InspectorDebuggerAgent.h:
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype._stepOverClicked):
+ (WebInspector.ScriptsPanel.prototype._stepIntoClicked):
+ (WebInspector.ScriptsPanel.prototype._stepOutClicked):
+
+2011-08-15 Vsevolod Vlasov <vsevik@chromium.org>
+
+ Web Inspector: Network panel: display the current search match index in the toolbar.
+ https://bugs.webkit.org/show_bug.cgi?id=66051
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/NetworkPanel.js:
+ (WebInspector.NetworkLogView.prototype._highlightNthMatchedResource):
+ (WebInspector.NetworkLogView.prototype.performSearch):
+ (WebInspector.NetworkPanel):
+ (WebInspector.NetworkPanel.prototype._onSearchCountUpdated):
+ (WebInspector.NetworkPanel.prototype._onSearchIndexUpdated):
+
+2011-08-10 Adam Roben <aroben@apple.com>
+
+ Clear up scale factor terminology
+
+ WebKit by and large deals with two scale factors: one intrinsic to the device on which the
+ software is running, and one that is per-Page and can be controlled via API calls. This
+ patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
+ code use those names. It should introduce no behavior changes.
+
+ Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
+ device scale factor
+
+ Reviewed by Simon Fraser.
+
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
+ Removed an unused member. This is unrelated to this patch.
+
+ * css/MediaQueryEvaluator.cpp:
+ * html/HTMLCanvasElement.cpp:
+ * html/HTMLCanvasElement.h:
+ * loader/EmptyClients.h:
+ * page/Chrome.cpp:
+ * page/Chrome.h:
+ * page/ChromeClient.h:
+ * page/DOMWindow.cpp:
+ * page/Frame.cpp:
+ * page/Frame.h:
+ * platform/graphics/GraphicsLayer.cpp:
+ * platform/graphics/GraphicsLayer.h:
+ * platform/graphics/GraphicsLayerClient.h:
+ * platform/graphics/ca/GraphicsLayerCA.cpp:
+ * rendering/RenderInline.cpp:
+ * rendering/RenderLayerBacking.cpp:
+ * rendering/RenderLayerBacking.h:
+ * rendering/RenderLayerCompositor.cpp:
+ * rendering/RenderLayerCompositor.h:
+ * rendering/RenderObject.cpp:
+
+2011-08-15 Oliver Varga <Varga.Oliver@stud.u-szeged.hu>
+
+ Reviewed by Nikolas Zimmermann.
+
+ Speed up SVGSMILElement::findInstanceTime.
+ https://bugs.webkit.org/show_bug.cgi?id=61025
+
+ Replace the linear search to binary search on ordered list because
+ the previous searches from the beginning was not efficient.
+ Out of index error fixed by Renata Hodovan.
+
+ No new tests this is only a performance tweak.
+
+ * svg/animation/SVGSMILElement.cpp:
+ (WebCore::extractTimeFromVector):
+ (WebCore::SVGSMILElement::findInstanceTime):
+
+2011-08-15 Hayato Ito <hayato@chromium.org>
+
+ Implement proper handling of focusin/focusout events in regard to shadow DOM boundaries.
+ https://bugs.webkit.org/show_bug.cgi?id=64249
+
+ Reviewed by Dimitri Glazkov.
+
+ Introduces FocusInEventDispatchMediator/FocusOutEventDispatchMediator so
+ that we can shrink ancestors of event target node considering shadow
+ DOM boundaries before dispatching focusin/focusout events.
+
+ Test: fast/dom/shadow/shadow-boundary-events.html
+
+ * dom/Document.cpp:
+ (WebCore::Document::setFocusedNode):
+ * dom/Node.cpp:
+ (WebCore::Node::dispatchFocusInEvent):
+ (WebCore::Node::dispatchFocusOutEvent):
+ (WebCore::Node::dispatchDOMActivateEvent):
+ (WebCore::Node::defaultEventHandler):
+ * dom/Node.h:
+ * dom/UIEvent.cpp:
+ (WebCore::FocusInEventDispatchMediator::create):
+ (WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
+ (WebCore::FocusInEventDispatchMediator::dispatchEvent):
+ (WebCore::FocusOutEventDispatchMediator::create):
+ (WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
+ (WebCore::FocusOutEventDispatchMediator::dispatchEvent):
+ * dom/UIEvent.h:
+
+2011-08-15 Pavel Feldman <pfeldman@google.com>
+
+ Web Inspector: not all of the properties have valid descriptors on all platforms.
+ Includes PropertyDescriptor protocol documentation fixes.
+ https://bugs.webkit.org/show_bug.cgi?id=66215
+
+ Activations, LocalStorage and some other properties potentially don't have
+ valid property descriptors. InjectedScript should use conservative getter in order to
+ mitigate this.
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/InjectedScriptSource.js:
+ * inspector/Inspector.json:
+
+2011-08-15 Pavel Feldman <pfeldman@google.com>
+
+ Web Inspector: context menu on the link in the console does not have standard link options.
+ https://bugs.webkit.org/show_bug.cgi?id=66214
+
+ Reviewed by Yury Semikhatsky.
+
+ * English.lproj/localizedStrings.js:
+ * inspector/front-end/ConsoleView.js:
+ * inspector/front-end/ElementsPanel.js:
+ * inspector/front-end/ElementsTreeOutline.js:
+ (WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
+ * inspector/front-end/NetworkPanel.js:
+ (WebInspector.NetworkLogView.prototype._contextMenu):
+ * inspector/front-end/StylesSidebarPane.js:
+ (WebInspector.StylesSidebarPane.prototype._contextMenuEventFired):
+ * inspector/front-end/inspector.js:
+ (WebInspector.openLinkExternallyLabel):
+ (WebInspector.copyLinkAddressLabel):
+ (WebInspector.populateHrefContextMenu):
+
+2011-08-14 Pavel Feldman <pfeldman@chromium.org>
+
+ Web Inspector: showContextMenu missing in Remote DevTools
+ https://bugs.webkit.org/show_bug.cgi?id=63725
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebCore.gypi:
+ * WebCore.vcproj/WebCore.vcproj:
+ * inspector/front-end/ConsoleView.js:
+ * inspector/front-end/SoftContextMenu.js: Added.
+ (.WebInspector.SoftContextMenu):
+ (.WebInspector.SoftContextMenu.prototype.show):
+ (.WebInspector.SoftContextMenu.prototype._createMenuItem):
+ (.WebInspector.SoftContextMenu.prototype._createSeparator):
+ (.WebInspector.SoftContextMenu.prototype._menuItemMouseDown):
+ (.WebInspector.SoftContextMenu.prototype._menuItemMouseUp):
+ (.WebInspector.SoftContextMenu.prototype._triggerAction):
+ (.WebInspector.SoftContextMenu.prototype._menuItemMouseOver):
+ (.WebInspector.SoftContextMenu.prototype._menuItemMouseOut):
+ (.WebInspector.SoftContextMenu.prototype._highlightMenuItem):
+ (.WebInspector.SoftContextMenu.prototype._highlightPrevious):
+ (.WebInspector.SoftContextMenu.prototype._highlightNext):
+ (.WebInspector.SoftContextMenu.prototype._menuKeyDown):
+ (.WebInspector.SoftContextMenu.prototype._glassPaneMouseUp):
+ (.WebInspector.SoftContextMenu.prototype._discardMenu):
+ (.InspectorFrontendHost.showContextMenu):
+ * inspector/front-end/WebKit.qrc:
+ * inspector/front-end/inspector.css:
+ (.soft-context-menu-glass-pane):
+ (.soft-context-menu):
+ (.soft-context-menu-item):
+ (.soft-context-menu-separator):
+ (.soft-context-menu-item-mouse-over):
+ * inspector/front-end/inspector.html:
+
+2011-08-13 Abhishek Arya <inferno@chromium.org>
+
+ Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody
+ https://bugs.webkit.org/show_bug.cgi?id=66187
+
+ Reviewed by Adam Barth.
+
+ RefPtr a few ContainerNodes to prevent premature deletion.
+
+ Test: fast/html/process-end-tag-for-inbody-crash.html
+
+ * html/parser/HTMLTreeBuilder.cpp:
+ (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
+ (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
+ (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
+
+2011-08-14 Kalev Lember <kalevlember@gmail.com>
+
+ Fix GTK Windows build after r92308.
+ https://bugs.webkit.org/show_bug.cgi?id=66140
+
+ Reviewed by Xan Lopez.
+
+ * config.h: Don't try to include WebCoreHeaderDetection.h for GTK.
+
+2011-08-13 Sam Weinig <sam@webkit.org>
+
+ Remove forward declaration of -[WebUndefined dealloc] to appease the bot gods.
+
+ * bindings/objc/WebScriptObject.mm:
+
+2011-08-13 Sam Weinig <sam@webkit.org>
+
+ Remove assertion from -[WebUndefined dealloc] to try to mollify the bots.
+
+ * bindings/objc/WebScriptObject.mm:
+ (-[WebUndefined dealloc]):
+
+2011-08-13 Sam Weinig <sam@webkit.org>
+
+ Remove unused variables from WebVideoFullscreenController.h
+ https://bugs.webkit.org/show_bug.cgi?id=66192
+
+ Reviewed by Dan Bernstein.
+
+ * platform/mac/WebVideoFullscreenController.h:
+ Remove _isWindowLoaded, _savedUIMode and _savedUIOptions which were not used.
+
+2011-08-13 Sam Weinig <sam@webkit.org>
+
+ Fix incorrect objective-c initialize in WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=66191
+
+ Reviewed by David Kilzer.
+
+ * accessibility/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper initWithAccessibilityObject:]):
+ * rendering/RenderThemeMac.mm:
+ (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
+ Correctly initialize by assigning to self and nil checking the result.
+
+2011-08-13 Adam Barth <abarth@webkit.org>
+
+ Fix clang build.
+
+ * platform/chromium/PopupMenuChromium.h:
+
+2011-08-13 David Kilzer <ddkilzer@apple.com>
+
+ <http://webkit.org/b/66188> WebCore.xcodeproj has duplicate entries again
+
+ Reviewed by Dan Bernstein.
+
+ * WebCore.xcodeproj/project.pbxproj: Remove duplicate entries
+ by using uniq. Originally noticed by Xcode 4.
+
+2011-08-12 Dan Bernstein <mitz@apple.com>
+
+ <rdar://problem/7337717> Add an option to automatically show tooltips (with the full text) over truncated text
+ https://bugs.webkit.org/show_bug.cgi?id=66178
+
+ Reviewed by Simon Fraser.
+
+ * WebCore.exp.in: Export setShowsToolTipOverTruncatedText().
+ * page/Chrome.cpp:
+ (WebCore::Chrome::setToolTip): If no title is found, and the page is set to show tooltips over
+ truncated text, try to set the tooltip to the full text of the truncated text, if any.
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings): Initialize new member variable.
+ (WebCore::Settings::setShowsToolTipOverTruncatedText): Added this setter.
+ * page/Settings.h:
+ (WebCore::Settings::showsToolTipOverTruncatedText): Added this getter.
+ * rendering/HitTestResult.cpp:
+ (WebCore::HitTestResult::innerTextIfTruncated): Added. If the inner node or its nearest enclosing
+ block has text-overflow: ellipsis and has truncated lines, return the node’s (full) inner text.
+ * rendering/HitTestResult.h:
+ * rendering/RootInlineBox.h:
+ (WebCore::RootInlineBox::hasEllipsisBox): Made this public.
+
+2011-08-12 Stephen White <senorblanco@chromium.org>
+
+ Ownership of canvas's GraphicsContext3D should be moved to PlatformContextSkia
+ https://bugs.webkit.org/show_bug.cgi?id=66154
+
+ Reviewed by Kenneth Russell.
+
+ Covered by existing tests in fast/canvas and canvas/philip.
+
+ * html/canvas/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::isAccelerated):
+ Plumb this call through GraphicsContext::isAcceleratedContext().
+ (WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer):
+ For the ACCELERATED_2D_CANVAS path, plumb this call through
+ (the new) GraphicsContext::paintsIntoCanvasBuffer().
+ (WebCore::CanvasRenderingContext2D::clearAcceleration):
+ (WebCore::CanvasRenderingContext2D::resetAcceleration):
+ Remove the use of the m_context3D member; use a temporary instead.
+ * html/canvas/CanvasRenderingContext2D.h:
+ Remove the m_context3D member.
+ * platform/graphics/GraphicsContext.cpp:
+ (WebCore::GraphicsContext::isAcceleratedContext):
+ (WebCore::GraphicsContext::paintsIntoImageBuffer):
+ Implement stub versions of these functions for other platforms.
+ * platform/graphics/GraphicsContext.h:
+ Expose isAcceleratedContext() to all platforms. Add
+ paintsIntoImageBuffer() member function.
+ * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
+ (WebCore::SharedGraphicsContext3D::create):
+ * platform/graphics/gpu/SharedGraphicsContext3D.h:
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::GraphicsContext::setGraphicsContext3D):
+ (WebCore::GraphicsContext::isAcceleratedContext):
+ (WebCore::GraphicsContext::paintsIntoImageBuffer):
+ Basically gut this class leaving only a static creation function.
+ * platform/graphics/skia/ImageSkia.cpp:
+ (WebCore::paintSkBitmap):
+ (WebCore::Image::drawPattern):
+ Use isAccelerated() in place of useSkiaGpu().
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
+ (WebCore::PlatformContextSkia::paintsIntoImageBuffer):
+ * platform/graphics/skia/PlatformContextSkia.h:
+ (WebCore::PlatformContextSkia::isAccelerated):
+ Rename useSkiaGpu() to isAccelerated(). Plumb through
+ paintsIntoImageBuffer() to GraphicsContext3D.
+
+2011-08-12 Sam Weinig <sam@webkit.org>
+
+ Use __builtin_trap() for CRASH when building with clang
+ https://bugs.webkit.org/show_bug.cgi?id=66152
+
+ Reviewed by Anders Carlsson.
+
+ * bindings/js/SerializedScriptValue.cpp:
+ (WebCore::CloneBase::fail):
+ * bindings/objc/WebScriptObject.mm:
+ * platform/mac/BlockExceptions.h:
+ * platform/text/cf/StringImplCF.cpp:
+ Add NO_RETURN_DUE_TO_ASSERT.
+
+ * bridge/IdentifierRep.h:
+ Don't define the destructor since it is never called,
+
+2011-08-12 Joseph Pecoraro <joepeck@webkit.org>
+
+ Abandoned Memory: Temporary CSS Fonts May Never Be Purged
+ https://bugs.webkit.org/show_bug.cgi?id=66153
+
+ Reviewed by Dan Bernstein.
+
+ No new tests, this is not a functional change.
+
+ * css/CSSFontFaceSource.cpp:
+ (WebCore::CSSFontFaceSource::getFontData):
+ If the CSS font-face is loading from a URL then immediately
+ fallback to a system font matching the description, since we
+ cannot determine a reasonable family name from the m_string
+ URL. The URL could be a dataURI.
+
+2011-08-12 Fady Samuel <fsamuel@chromium.org>
+
+ Refactoring of PopupMenuChromium For Readability and Maintainability
+ https://bugs.webkit.org/show_bug.cgi?id=66009
+
+ Reviewed by Darin Fisher.
+
+ Split PopupMenuChromium into three sets of files: PopupMenuChromium.{h|cpp}, PopupContainer.{h|cpp},
+ and PopupLisBox.{h|cpp} for readability and maintainability.
+
+ No new tests as there's no change in functionality.
+
+ * WebCore.gypi:
+ * platform/chromium/PopupContainer.cpp: Added.
+ (WebCore::constructRelativeMouseEvent):
+ (WebCore::constructRelativeWheelEvent):
+ (WebCore::PopupContainer::create):
+ (WebCore::PopupContainer::PopupContainer):
+ (WebCore::PopupContainer::~PopupContainer):
+ (WebCore::PopupContainer::layoutAndCalculateWidgetRect):
+ (WebCore::PopupContainer::showPopup):
+ (WebCore::PopupContainer::hidePopup):
+ (WebCore::PopupContainer::notifyPopupHidden):
+ (WebCore::PopupContainer::layoutAndGetRTLOffset):
+ (WebCore::PopupContainer::handleMouseDownEvent):
+ (WebCore::PopupContainer::handleMouseMoveEvent):
+ (WebCore::PopupContainer::handleMouseReleaseEvent):
+ (WebCore::PopupContainer::handleWheelEvent):
+ (WebCore::PopupContainer::handleTouchEvent):
+ (WebCore::PopupContainer::handleGestureEvent):
+ (WebCore::PopupContainer::handleKeyEvent):
+ (WebCore::PopupContainer::hide):
+ (WebCore::PopupContainer::paint):
+ (WebCore::PopupContainer::paintBorder):
+ (WebCore::PopupContainer::isInterestedInEventForKey):
+ (WebCore::PopupContainer::chromeClientChromium):
+ (WebCore::PopupContainer::showInRect):
+ (WebCore::PopupContainer::refresh):
+ (WebCore::PopupContainer::isRTL):
+ (WebCore::PopupContainer::selectedIndex):
+ (WebCore::PopupContainer::menuItemHeight):
+ (WebCore::PopupContainer::menuItemFontSize):
+ (WebCore::PopupContainer::menuStyle):
+ (WebCore::popupData):
+ (WebCore::PopupContainer::getSelectedItemToolTip):
+ * platform/chromium/PopupContainer.h: Added.
+ (WebCore::PopupContainer::listBox):
+ (WebCore::PopupContainer::popupType):
+ * platform/chromium/PopupListBox.cpp: Added.
+ (WebCore::PopupListBox::PopupListBox):
+ (WebCore::PopupListBox::handleMouseDownEvent):
+ (WebCore::PopupListBox::handleMouseMoveEvent):
+ (WebCore::PopupListBox::handleMouseReleaseEvent):
+ (WebCore::PopupListBox::handleWheelEvent):
+ (WebCore::PopupListBox::isInterestedInEventForKey):
+ (WebCore::PopupListBox::handleTouchEvent):
+ (WebCore::PopupListBox::handleGestureEvent):
+ (WebCore::isCharacterTypeEvent):
+ (WebCore::PopupListBox::handleKeyEvent):
+ (WebCore::PopupListBox::hostWindow):
+ (WebCore::stripLeadingWhiteSpace):
+ (WebCore::PopupListBox::typeAheadFind):
+ (WebCore::PopupListBox::paint):
+ (WebCore::PopupListBox::paintRow):
+ (WebCore::PopupListBox::getRowFont):
+ (WebCore::PopupListBox::abandon):
+ (WebCore::PopupListBox::pointToRowIndex):
+ (WebCore::PopupListBox::acceptIndex):
+ (WebCore::PopupListBox::selectIndex):
+ (WebCore::PopupListBox::setOriginalIndex):
+ (WebCore::PopupListBox::getRowHeight):
+ (WebCore::PopupListBox::getRowBounds):
+ (WebCore::PopupListBox::invalidateRow):
+ (WebCore::PopupListBox::scrollToRevealRow):
+ (WebCore::PopupListBox::isSelectableItem):
+ (WebCore::PopupListBox::clearSelection):
+ (WebCore::PopupListBox::selectNextRow):
+ (WebCore::PopupListBox::selectPreviousRow):
+ (WebCore::PopupListBox::adjustSelectedIndex):
+ (WebCore::PopupListBox::hidePopup):
+ (WebCore::PopupListBox::updateFromElement):
+ (WebCore::PopupListBox::setMaxWidthAndLayout):
+ (WebCore::PopupListBox::layout):
+ (WebCore::PopupListBox::clear):
+ (WebCore::PopupListBox::isPointInBounds):
+ * platform/chromium/PopupListBox.h: Added.
+ (WebCore::PopupItem::PopupItem):
+ (WebCore::PopupListBox::create):
+ (WebCore::PopupListBox::selectedIndex):
+ (WebCore::PopupListBox::numItems):
+ (WebCore::PopupListBox::setBaseWidth):
+ (WebCore::PopupListBox::setMaxHeight):
+ (WebCore::PopupListBox::setMaxWidth):
+ (WebCore::PopupListBox::disconnectClient):
+ (WebCore::PopupListBox::items):
+ (WebCore::PopupListBox::~PopupListBox):
+ (WebCore::PopupListBox::scrollToRevealSelection):
+ * platform/chromium/PopupMenuChromium.cpp:
+ * platform/chromium/PopupMenuChromium.h:
+
+2011-08-12 Mark Rowe <mrowe@apple.com>
+
+ Be more forward-looking in the choice of compiler.
+
+ Rubber-stamped by Jon Honeycutt.
+
+ * Configurations/CompilerVersion.xcconfig:
+
+2011-08-12 Nat Duca <nduca@chromium.org>
+
+ [chromium] Fix comile warning on CCLayerTreeHost
+
+ * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+ (WebCore::CCLayerTreeHost::CCLayerTreeHost):
+
+2011-08-12 Ryosuke Niwa <rniwa@webkit.org>
+
+ Apple-style-span class seems unnecessary
+ https://bugs.webkit.org/show_bug.cgi?id=12248
+
+ Reviewed by Justin Garcia.
+
+ Stop generating span or font elements with class="Apple-style-span" given WebKit's editing component
+ no longer depends on Apple-style-span since r92823 removed the dependency of copy and paste code on
+ style spans. WebKit continues to recognize Apple style spans to remove them.
+
+ Also renamed isSpanWithoutAttributesOrUnstyleStyleSpan to isSpanWithoutAttributesOrUnstyle*d*StyleSpan.
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::isLegacyAppleStyleSpan): Renamed from isStyleSpan.
+ (WebCore::isSpanWithoutAttributesOrUnstyledStyleSpan): Renamed from isSpanWithoutAttributesOr*Unstyle*StyleSpan.
+ (WebCore::createFontElement): No longer adds class="Apple-style-span".
+ (WebCore::createStyleSpanElement): Ditto.
+ (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Calls isSpanWithoutAttributesOrUnstyleStyleSpan
+ instead of isUnstyledStyleSpan since there won't be any Apple style spans.
+ (WebCore::dummySpanAncestorForNode):
+ (WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans): Ditto.
+ (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Ditto.
+ (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
+ (WebCore::ApplyStyleCommand::removeCSSStyle):
+ * editing/ApplyStyleCommand.h:
+ * editing/EditingStyle.cpp:
+ (WebCore::EditingStyle::removeStyleFromRulesAndContext): Ditto.
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Calls isLegacyAppleStyleSpan instead
+ of isStyleSpan.
+ (WebCore::handleStyleSpansBeforeInsertion): Ditto.
+ (WebCore::ReplaceSelectionCommand::handleStyleSpans): Ditto.
+ (WebCore::ReplaceSelectionCommand::doApply): Ditto.
+ * editing/markup.cpp:
+ (WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): No longer adds class="Apple-style-span".
+
+2011-08-12 Nat Duca <nduca@chromium.org>
+
+ [chromium] Fix compositor breakage due to duplicate context creation AND by context-lost
+ https://bugs.webkit.org/show_bug.cgi?id=66168
+
+ * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+ (WebCore::CCLayerTreeHost::CCLayerTreeHost):
+ (WebCore::CCLayerTreeHost::initialize):
+
+2011-08-12 Levi Weintraub <leviw@chromium.org>
+
+ Switch RenderMenuList, RenderListBox, and RenderFieldSet to new layout units
+ https://bugs.webkit.org/show_bug.cgi?id=66149
+
+ Reviewed by Eric Seidel.
+
+ Changing RenderMenuList, RenderListBox, and RenderFieldSet to the LayoutUnit
+ abstraction from ints.
+
+ No tests as no change in functionality.
+
+ * rendering/RenderFieldset.cpp:
+ (WebCore::RenderFieldset::layoutSpecialExcludedChild):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::numVisibleItems):
+ (WebCore::RenderListBox::listHeight):
+ (WebCore::RenderListBox::baselinePosition):
+ (WebCore::RenderListBox::itemBoundingBoxRect):
+ (WebCore::itemOffsetForAlignment):
+ (WebCore::RenderListBox::panScroll):
+ (WebCore::RenderListBox::scrollToward):
+ (WebCore::RenderListBox::autoscroll):
+ (WebCore::RenderListBox::scrollSize):
+ (WebCore::RenderListBox::scrollPosition):
+ (WebCore::RenderListBox::setScrollOffset):
+ (WebCore::RenderListBox::itemHeight):
+ (WebCore::RenderListBox::verticalScrollbarWidth):
+ (WebCore::RenderListBox::scrollWidth):
+ (WebCore::RenderListBox::scrollHeight):
+ (WebCore::RenderListBox::scrollLeft):
+ (WebCore::RenderListBox::setScrollLeft):
+ (WebCore::RenderListBox::scrollTop):
+ (WebCore::RenderListBox::setScrollTop):
+ (WebCore::RenderListBox::controlClipRect):
+ (WebCore::RenderListBox::invalidateScrollbarRect):
+ (WebCore::RenderListBox::convertFromScrollbarToContainingView):
+ (WebCore::RenderListBox::convertFromContainingViewToScrollbar):
+ (WebCore::RenderListBox::contentsSize):
+ (WebCore::RenderListBox::currentMousePosition):
+ * rendering/RenderListBox.h:
+ (WebCore::RenderListBox::scrollCornerRect):
+ (WebCore::RenderListBox::invalidateScrollCornerRect):
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::controlClipRect):
+ (WebCore::RenderMenuList::showPopup):
+ * rendering/RenderMenuList.h:
+
+2011-08-12 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=66133
+
+ Make hit testing work on RenderRegions. Pass off the hit testing to the RenderFlowThread
+ layer tree (just as we did with painting).
+
+ Reviewed by Sam Weinig.
+
+ Added hit-test-float.html to demonstrate basic hit testing of content flowed into regions.
+
+ * rendering/HitTestRequest.h:
+ (WebCore::HitTestRequest::type):
+ * rendering/RenderFlowThread.cpp:
+ (WebCore::RenderFlowThread::hitTestRegion):
+ * rendering/RenderFlowThread.h:
+ * rendering/RenderRegion.cpp:
+ (WebCore::RenderRegion::paintReplaced):
+ (WebCore::RenderRegion::nodeAtPoint):
+ * rendering/RenderRegion.h:
+
+2011-08-12 Levi Weintraub <leviw@chromium.org>
+
+ Switch RenderTable* to new layout types
+ https://bugs.webkit.org/show_bug.cgi?id=66146
+
+ Reviewed by Eric Seidel.
+
+ Converting RenderTable* classes to new LayoutUnits from ints.
+
+ No new tests as no new functionality.
+
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::firstLineBoxBaseline):
+ (WebCore::RenderTable::overflowClipRect):
+ * rendering/RenderTable.h:
+ (WebCore::RenderTable::columnPositions):
+ * rendering/RenderTableCol.cpp:
+ (WebCore::RenderTableCol::clippedOverflowRectForRepaint):
+ * rendering/RenderTableRow.cpp:
+ (WebCore::RenderTableRow::clippedOverflowRectForRepaint):
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::setCellLogicalWidths):
+ (WebCore::RenderTableSection::calcRowLogicalHeight):
+ (WebCore::RenderTableSection::layoutRows):
+ (WebCore::RenderTableSection::calcOuterBorderBefore):
+ (WebCore::RenderTableSection::calcOuterBorderAfter):
+ (WebCore::RenderTableSection::calcOuterBorderStart):
+ (WebCore::RenderTableSection::calcOuterBorderEnd):
+ (WebCore::RenderTableSection::firstLineBoxBaseline):
+ (WebCore::RenderTableSection::paintObject):
+ (WebCore::RenderTableSection::nodeAtPoint):
+ * rendering/RenderTableSection.h:
+ (WebCore::RenderTableSection::outerBorderBefore):
+ (WebCore::RenderTableSection::outerBorderAfter):
+ (WebCore::RenderTableSection::outerBorderStart):
+ (WebCore::RenderTableSection::outerBorderEnd):
+ (WebCore::RenderTableSection::getBaseline):
+
+2011-08-12 Adam Bergkvist <adam.bergkvist@ericsson.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ EventSource loader should not buffer data
+ https://bugs.webkit.org/show_bug.cgi?id=61863
+
+ Disabled buffering in the EventSource loader.
+
+ Added a manual test.
+
+ * manual-tests/eventsource/eventsource-loader-buffering.html: Added.
+ * manual-tests/eventsource/eventsource-loader-buffering.php: Added.
+ * page/EventSource.cpp:
+ (WebCore::EventSource::connect):
+
+2011-08-11 Pratik Solanki <psolanki@apple.com>
+
+ ResourceLoader::didReceiveDataArray() does not handle m_shouldBufferData correctly
+ https://bugs.webkit.org/show_bug.cgi?id=65926
+
+ Reviewed by Alexey Proskuryakov.
+
+ * loader/mac/ResourceLoaderMac.mm:
+ (WebCore::ResourceLoader::didReceiveDataArray): Make sure we call the client callbacks when
+ m_shouldBufferData is set to false.
+
+2011-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
+
+ Unreviewed, rolling out r92976.
+ http://trac.webkit.org/changeset/92976
+ https://bugs.webkit.org/show_bug.cgi?id=66159
+
+ Does not compile on chromium-win (Requested by abarth|gardener
+ on #webkit).
+
+ * WebCore.gypi:
+ * platform/chromium/PopupContainer.cpp: Removed.
+ * platform/chromium/PopupContainer.h: Removed.
+ * platform/chromium/PopupListBox.cpp: Removed.
+ * platform/chromium/PopupListBox.h: Removed.
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::PopupListBox::create):
+ (WebCore::PopupListBox::selectedIndex):
+ (WebCore::PopupListBox::numItems):
+ (WebCore::PopupListBox::setBaseWidth):
+ (WebCore::PopupListBox::setMaxHeight):
+ (WebCore::PopupListBox::setMaxWidth):
+ (WebCore::PopupListBox::disconnectClient):
+ (WebCore::PopupListBox::items):
+ (WebCore::PopupListBox::PopupListBox):
+ (WebCore::PopupListBox::~PopupListBox):
+ (WebCore::PopupListBox::scrollToRevealSelection):
+ (WebCore::constructRelativeMouseEvent):
+ (WebCore::constructRelativeWheelEvent):
+ (WebCore::PopupContainer::create):
+ (WebCore::PopupContainer::PopupContainer):
+ (WebCore::PopupContainer::~PopupContainer):
+ (WebCore::PopupContainer::layoutAndCalculateWidgetRect):
+ (WebCore::PopupContainer::showPopup):
+ (WebCore::PopupContainer::hidePopup):
+ (WebCore::PopupContainer::notifyPopupHidden):
+ (WebCore::PopupContainer::layoutAndGetRTLOffset):
+ (WebCore::PopupContainer::handleMouseDownEvent):
+ (WebCore::PopupContainer::handleMouseMoveEvent):
+ (WebCore::PopupContainer::handleMouseReleaseEvent):
+ (WebCore::PopupContainer::handleWheelEvent):
+ (WebCore::PopupContainer::handleTouchEvent):
+ (WebCore::PopupContainer::handleGestureEvent):
+ (WebCore::PopupContainer::handleKeyEvent):
+ (WebCore::PopupContainer::hide):
+ (WebCore::PopupContainer::paint):
+ (WebCore::PopupContainer::paintBorder):
+ (WebCore::PopupContainer::isInterestedInEventForKey):
+ (WebCore::PopupContainer::chromeClientChromium):
+ (WebCore::PopupContainer::showInRect):
+ (WebCore::PopupContainer::refresh):
+ (WebCore::PopupContainer::isRTL):
+ (WebCore::PopupContainer::selectedIndex):
+ (WebCore::PopupContainer::menuItemHeight):
+ (WebCore::PopupContainer::menuItemFontSize):
+ (WebCore::PopupContainer::menuStyle):
+ (WebCore::popupData):
+ (WebCore::PopupContainer::getSelectedItemToolTip):
+ (WebCore::PopupListBox::handleMouseDownEvent):
+ (WebCore::PopupListBox::handleMouseMoveEvent):
+ (WebCore::PopupListBox::handleMouseReleaseEvent):
+ (WebCore::PopupListBox::handleWheelEvent):
+ (WebCore::PopupListBox::isInterestedInEventForKey):
+ (WebCore::PopupListBox::handleTouchEvent):
+ (WebCore::PopupListBox::handleGestureEvent):
+ (WebCore::isCharacterTypeEvent):
+ (WebCore::PopupListBox::handleKeyEvent):
+ (WebCore::PopupListBox::hostWindow):
+ (WebCore::stripLeadingWhiteSpace):
+ (WebCore::PopupListBox::typeAheadFind):
+ (WebCore::PopupListBox::paint):
+ (WebCore::PopupListBox::paintRow):
+ (WebCore::PopupListBox::getRowFont):
+ (WebCore::PopupListBox::abandon):
+ (WebCore::PopupListBox::pointToRowIndex):
+ (WebCore::PopupListBox::acceptIndex):
+ (WebCore::PopupListBox::selectIndex):
+ (WebCore::PopupListBox::setOriginalIndex):
+ (WebCore::PopupListBox::getRowHeight):
+ (WebCore::PopupListBox::getRowBounds):
+ (WebCore::PopupListBox::invalidateRow):
+ (WebCore::PopupListBox::scrollToRevealRow):
+ (WebCore::PopupListBox::isSelectableItem):
+ (WebCore::PopupListBox::clearSelection):
+ (WebCore::PopupListBox::selectNextRow):
+ (WebCore::PopupListBox::selectPreviousRow):
+ (WebCore::PopupListBox::adjustSelectedIndex):
+ (WebCore::PopupListBox::hidePopup):
+ (WebCore::PopupListBox::updateFromElement):
+ (WebCore::PopupListBox::setMaxWidthAndLayout):
+ (WebCore::PopupListBox::layout):
+ (WebCore::PopupListBox::clear):
+ (WebCore::PopupListBox::isPointInBounds):
+ * platform/chromium/PopupMenuChromium.h:
+ (WebCore::PopupItem::PopupItem):
+ (WebCore::PopupContainer::listBox):
+ (WebCore::PopupContainer::popupType):
+
+2011-08-12 Andy Estes <aestes@apple.com>
+
+ Cancel in onbeforeunload dialog sometime causes a button to stop working.
+ https://bugs.webkit.org/show_bug.cgi?id=26211
+
+ Reviewed by Alexey Proskuryakov.
+
+ Test: fast/loader/form-submission-after-beforeunload-cancel.html
+
+ If an onbeforeunload handler cancels a navigation that was triggered by
+ a form submission, WebCore's multiple form submission protection
+ prevents the form from being submitted a second time even though no
+ first submission actually took place. Fix this by clearing
+ m_submittedFormURL if the onbeforeunload handler cancels the load. This
+ allows the submission to be retried.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::shouldClose): Set m_submittedFormURL to KURL()
+ if shouldClose() will return false.
+
+2011-08-12 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=66130
+
+ RenderRegions need to paint the entire RenderFlowThread layer tree. Instead of just calling
+ paintBlock, make sure RenderRegions paint the flow thread's layer tree instead with the appropriate
+ offset.
+
+ Fix RenderRegions to derive from RenderReplaced instead of RenderBox, since it simplifies the code.
+ They no longer have to subclass their own layout method or worry about all of the painting logic
+ for anything other than the content area.
+
+ Reviewed by Anders Carlsson.
+
+ Existing tests have a layer tree example, and so those results are updated to show the tree now.
+
+ * rendering/RenderFlowThread.cpp:
+ (WebCore::RenderFlowThread::createFlowThreadStyle):
+ (WebCore::RenderFlowThread::paintIntoRegion):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::collectLayers):
+ * rendering/RenderRegion.cpp:
+ (WebCore::RenderRegion::RenderRegion):
+ (WebCore::RenderRegion::paintReplaced):
+ (WebCore::RenderRegion::styleDidChange):
+ * rendering/RenderRegion.h:
+
+2011-08-12 Chris Rogers <crogers@google.com>
+
+ Fix mac build when web audio is enabled
+ https://bugs.webkit.org/show_bug.cgi?id=66150
+
+ Unreviewed build fix.
+
+ * platform/audio/mac/AudioFileReaderMac.cpp:
+ (WebCore::AudioFileReader::createBus):
+
+2011-08-12 Jeff Miller <jeffm@apple.com>
+
+ Need to handle kCACFContextNeedsFlushNotification notifications that arrive after the AVFWrapper has been disposed
+ https://bugs.webkit.org/show_bug.cgi?id=65724
+
+ Instead of using a pointer to the AVFWrapper object as the context for various callbacks, assign each object an
+ ID and use that instead. Keep track of the mapping between object IDs and AVFWrapper objects in a HashMap, and manage
+ access to this map using a Mutex since it can be accessed from multiple threads. This allows us to actually delete
+ AVFWrapper objects instead of leaking them (which we were doing before to prevent crashes).
+
+ Reviewed by Eric Carlson.
+
+ No new tests, uses existing media tests.
+
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
+ (WebCore::AVFWrapper::callbackContext): Added.
+ (WebCore::AVFWrapper::AVFWrapper): Initialize m_objectID and add it to the HashMap.
+ (WebCore::AVFWrapper::~AVFWrapper): Log object ID and remove obsolete assert.
+ (WebCore::AVFWrapper::mapLock): Added.
+ (WebCore::AVFWrapper::map): Added.
+ (WebCore::AVFWrapper::addToMap): Added.
+ (WebCore::AVFWrapper::removeFromMap): Added.
+ (WebCore::AVFWrapper::avfWrapperForCallbackContext): Added.
+ (WebCore::AVFWrapper::scheduleDisconnectAndDelete): Remove AVFWrapper from HashMap instead of zeroing m_owner.
+ (WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Use callbackContext(), delete the AVFWrapper here.
+ (WebCore::AVFWrapper::createPlayer): Use callbackContext().
+ (WebCore::AVFWrapper::createPlayerItem): Use callbackContext().
+ (WebCore::AVFWrapper::periodicTimeObserverCallback): Retrieve AVFWrapper using the HashMap.
+ (WebCore::AVFWrapper::notificationCallback): Retrieve AVFWrapper using the HashMap.
+ (WebCore::AVFWrapper::loadPlayableCompletionCallback): Retrieve AVFWrapper using the HashMap.
+ (WebCore::AVFWrapper::checkPlayability): Use callbackContext().
+ (WebCore::AVFWrapper::loadMetadataCompletionCallback): Retrieve AVFWrapper using the HashMap.
+ (WebCore::AVFWrapper::beginLoadingMetadata): Use callbackContext().
+ (WebCore::AVFWrapper::seekCompletedCallback): Retrieve AVFWrapper using the HashMap.
+ (WebCore::AVFWrapper::seekToTime): Use callbackContext().
+ (WebCore::AVFWrapper::platformLayer): Remove overly noisy LOG().
+
+2011-08-12 Fady Samuel <fsamuel@chromium.org>
+
+ Refactoring of PopupMenuChromium
+ https://bugs.webkit.org/show_bug.cgi?id=66009
+
+ Reviewed by Darin Fisher.
+
+ Split PopupMenuChromium into three sets of files: PopupMenuChromium.{h|cpp}, PopupContainer.{h|cpp}, and PopupLisBox.{h|cpp}
+ for readability and maintainability.
+
+ No new tests as no functionality has changed.
+
+ * WebCore.gypi:
+ * platform/chromium/PopupContainer.cpp: Added.
+ (WebCore::constructRelativeMouseEvent):
+ (WebCore::constructRelativeWheelEvent):
+ (WebCore::PopupContainer::create):
+ (WebCore::PopupContainer::PopupContainer):
+ (WebCore::PopupContainer::~PopupContainer):
+ (WebCore::PopupContainer::layoutAndCalculateWidgetRect):
+ (WebCore::PopupContainer::showPopup):
+ (WebCore::PopupContainer::hidePopup):
+ (WebCore::PopupContainer::notifyPopupHidden):
+ (WebCore::PopupContainer::layoutAndGetRTLOffset):
+ (WebCore::PopupContainer::handleMouseDownEvent):
+ (WebCore::PopupContainer::handleMouseMoveEvent):
+ (WebCore::PopupContainer::handleMouseReleaseEvent):
+ (WebCore::PopupContainer::handleWheelEvent):
+ (WebCore::PopupContainer::handleTouchEvent):
+ (WebCore::PopupContainer::handleGestureEvent):
+ (WebCore::PopupContainer::handleKeyEvent):
+ (WebCore::PopupContainer::hide):
+ (WebCore::PopupContainer::paint):
+ (WebCore::PopupContainer::paintBorder):
+ (WebCore::PopupContainer::isInterestedInEventForKey):
+ (WebCore::PopupContainer::chromeClientChromium):
+ (WebCore::PopupContainer::showInRect):
+ (WebCore::PopupContainer::refresh):
+ (WebCore::PopupContainer::isRTL):
+ (WebCore::PopupContainer::selectedIndex):
+ (WebCore::PopupContainer::menuItemHeight):
+ (WebCore::PopupContainer::menuItemFontSize):
+ (WebCore::PopupContainer::menuStyle):
+ (WebCore::popupData):
+ (WebCore::PopupContainer::getSelectedItemToolTip):
+ * platform/chromium/PopupContainer.h: Added.
+ (WebCore::PopupContainer::listBox):
+ (WebCore::PopupContainer::popupType):
+ * platform/chromium/PopupListBox.cpp: Added.
+ (WebCore::PopupListBox::PopupListBox):
+ (WebCore::PopupListBox::handleMouseDownEvent):
+ (WebCore::PopupListBox::handleMouseMoveEvent):
+ (WebCore::PopupListBox::handleMouseReleaseEvent):
+ (WebCore::PopupListBox::handleWheelEvent):
+ (WebCore::PopupListBox::isInterestedInEventForKey):
+ (WebCore::PopupListBox::handleTouchEvent):
+ (WebCore::PopupListBox::handleGestureEvent):
+ (WebCore::isCharacterTypeEvent):
+ (WebCore::PopupListBox::handleKeyEvent):
+ (WebCore::PopupListBox::hostWindow):
+ (WebCore::stripLeadingWhiteSpace):
+ (WebCore::PopupListBox::typeAheadFind):
+ (WebCore::PopupListBox::paint):
+ (WebCore::PopupListBox::paintRow):
+ (WebCore::PopupListBox::getRowFont):
+ (WebCore::PopupListBox::abandon):
+ (WebCore::PopupListBox::pointToRowIndex):
+ (WebCore::PopupListBox::acceptIndex):
+ (WebCore::PopupListBox::selectIndex):
+ (WebCore::PopupListBox::setOriginalIndex):
+ (WebCore::PopupListBox::getRowHeight):
+ (WebCore::PopupListBox::getRowBounds):
+ (WebCore::PopupListBox::invalidateRow):
+ (WebCore::PopupListBox::scrollToRevealRow):
+ (WebCore::PopupListBox::isSelectableItem):
+ (WebCore::PopupListBox::clearSelection):
+ (WebCore::PopupListBox::selectNextRow):
+ (WebCore::PopupListBox::selectPreviousRow):
+ (WebCore::PopupListBox::adjustSelectedIndex):
+ (WebCore::PopupListBox::hidePopup):
+ (WebCore::PopupListBox::updateFromElement):
+ (WebCore::PopupListBox::setMaxWidthAndLayout):
+ (WebCore::PopupListBox::layout):
+ (WebCore::PopupListBox::clear):
+ (WebCore::PopupListBox::isPointInBounds):
+ * platform/chromium/PopupListBox.h: Added.
+ (WebCore::PopupItem::PopupItem):
+ (WebCore::PopupListBox::create):
+ (WebCore::PopupListBox::selectedIndex):
+ (WebCore::PopupListBox::numItems):
+ (WebCore::PopupListBox::setBaseWidth):
+ (WebCore::PopupListBox::setMaxHeight):
+ (WebCore::PopupListBox::setMaxWidth):
+ (WebCore::PopupListBox::disconnectClient):
+ (WebCore::PopupListBox::items):
+ (WebCore::PopupListBox::~PopupListBox):
+ (WebCore::PopupListBox::scrollToRevealSelection):
+ * platform/chromium/PopupMenuChromium.cpp:
+ * platform/chromium/PopupMenuChromium.h:
+
+2011-08-12 Sam Weinig <sam@webkit.org>
+
+ Move compiler specific macros to their own header
+ https://bugs.webkit.org/show_bug.cgi?id=66119
+
+ Reviewed by Anders Carlsson.
+
+ * ForwardingHeaders/wtf/Compiler.h: Added.
+
+2011-08-12 No'am Rosenthal <noam.rosenthal@nokia.com>
+
+ [Qt][REGRESSION] composited content doesn't render since r92651
+ https://bugs.webkit.org/show_bug.cgi?id=66108
+
+ Reviewed by Benjamin Poulain.
+
+ Changed the signature for GraphicsLayerTextureMapper::syncCompositingState to match
+ the new signature in GraphicsLayer.h.
+
+ No new tests. This is a regression that's covered by existing pixel tests.
+
+ * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
+ (WebCore::GraphicsLayerTextureMapper::syncCompositingState):
+ * platform/graphics/texmap/GraphicsLayerTextureMapper.h:
+
+2011-08-12 Alexandru Chiculita <achicu@adobe.com>
+
+ Original patch by Mihnea Ovidenie <mihnea@adobe.com>.
+ Also contains some improvements done by Dave Hyatt <hyatt@apple.com>.
+
+ [CSSRegions]RenderFlowThread should display its content using RenderRegion
+ https://bugs.webkit.org/show_bug.cgi?id=65627
+
+ RenderFlowThread collects RenderObjects from a flow. These objects are displayed by means
+ of RenderRegion objects that get the content from the same flow.
+
+ Reviewed by David Hyatt.
+
+ Tests: fast/regions/content-flowed-into-regions-dynamically-added.html
+ fast/regions/content-flowed-into-regions-dynamically-removed.html
+ fast/regions/content-flowed-into-regions-with-dyn-index.html
+ fast/regions/content-flowed-into-regions-with-index-dom.html
+ fast/regions/content-flowed-into-regions-with-index.html
+ fast/regions/content-flowed-into-regions.html
+ fast/regions/flow-content-basic-vertical-rl.html
+ fast/regions/flow-content-basic-vertical.html
+
+ * dom/Node.cpp:
+ (WebCore::Node::diff):
+ * rendering/RenderFlowThread.cpp:
+ (WebCore::RenderFlowThread::RenderFlowThread):
+ (WebCore::RenderFlowThread::createFlowThreadStyle):
+ (WebCore::RenderFlowThread::styleDidChange):
+ (WebCore::compareRenderRegions):
+ (WebCore::RenderFlowThread::addRegionToThread):
+ (WebCore::RenderFlowThread::removeRegionFromThread):
+ (WebCore::RenderFlowThread::layout):
+ (WebCore::RenderFlowThread::computeLogicalWidth):
+ (WebCore::RenderFlowThread::computeLogicalHeight):
+ (WebCore::RenderFlowThread::paintIntoRegion):
+ * rendering/RenderFlowThread.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::createObject):
+ * rendering/RenderRegion.cpp:
+ (WebCore::RenderRegion::RenderRegion):
+ (WebCore::RenderRegion::~RenderRegion):
+ (WebCore::RenderRegion::paint):
+ (WebCore::RenderRegion::styleDidChange):
+ * rendering/RenderRegion.h:
+ (WebCore::RenderRegion::setRegionRect):
+ (WebCore::RenderRegion::regionRect):
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::writeLayers):
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::styleDidChange):
+ (WebCore::RenderView::renderFlowThreadWithName):
+ * rendering/RenderView.h:
+
+2011-08-12 Abhishek Arya <inferno@chromium.org>
+
+ Crash in WebCore::editingIgnoresContent
+ https://bugs.webkit.org/show_bug.cgi?id=66125
+
+ Reviewed by Ryosuke Niwa.
+
+ RefPtr a few nodes in case they get blown away in
+ dispatchEvent calls.
+
+ Test: editing/selection/select-start-remove-root-crash.html
+
+ * editing/FrameSelection.cpp:
+ (WebCore::FrameSelection::selectAll):
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplacementFragment::ReplacementFragment):
+
+2011-08-11 Pavel Podivilov <podivilov@chromium.org>
+
+ Web Inspector: properly update console message count in source frames and resources panel.
+ https://bugs.webkit.org/show_bug.cgi?id=57009
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/front-end/ConsoleView.js:
+ (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):
+ * inspector/front-end/SourceFrame.js:
+ (WebInspector.SourceFrame.prototype.show):
+ (WebInspector.SourceFrame.prototype.addMessageToSource):
+ (WebInspector.SourceFrame.prototype._updateMessageRepeatCount):
+
+2011-08-12 Pavel Feldman <pfeldman@google.com>
+
+ Not reviewed: follow up to inspector test breakage.
+
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):
+
+2011-08-12 Yury Semikhatsky <yurys@chromium.org>
+
+ Web Inspector: expand exception properties when wrapping it as object.
+ https://bugs.webkit.org/show_bug.cgi?id=66035
+
+ Use toString() value as a description for value thrown during eval.
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/InjectedScriptSource.js:
+ (.):
+
+2011-08-12 Pavel Feldman <pfeldman@google.com>
+
+ Web Inspector: make folders optional in the Scripts' panel file selector.
+ https://bugs.webkit.org/show_bug.cgi?id=66100
+
+ Reviewed by Yury Semikhatsky.
+
+ * English.lproj/localizedStrings.js:
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):
+ (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
+ (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
+ (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
+ (WebInspector.ScriptsPanel.prototype.reset):
+ (WebInspector.ScriptsPanel.prototype._resetFilesSelect):
+ * inspector/front-end/Settings.js:
+ (WebInspector.Settings):
+ * inspector/front-end/SettingsScreen.js:
+ (WebInspector.SettingsScreen):
+
+2011-08-12 Pavel Podivilov <podivilov@chromium.org>
+
+ Web Inspector: add space between error info and error message in source frame message bubble.
+ https://bugs.webkit.org/show_bug.cgi?id=65069
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/ConsoleView.js:
+ (WebInspector.ConsoleMessage.prototype._formatMessage):
+
+2011-08-12 Pavel Feldman <pfeldman@google.com>
+
+ Web Inspector: console loses focus upon reloading the page from the inspector.
+ https://bugs.webkit.org/show_bug.cgi?id=66068
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/front-end/AuditsPanel.js:
+ (WebInspector.AuditsPanel.prototype._auditFinishedCallback):
+ (WebInspector.AuditsPanel.prototype._clearButtonClicked):
+ * inspector/front-end/DataGrid.js:
+ (WebInspector.DataGrid.prototype.revealAndSelect):
+ (WebInspector.DataGridNode.prototype.revealAndSelect):
+ * inspector/front-end/DetailedHeapshotView.js:
+ (WebInspector.DetailedHeapshotView.prototype._jumpToSearchResult):
+ * inspector/front-end/ElementsPanel.js:
+ (WebInspector.ElementsPanel.this.treeOutline.selectedNodeChanged):
+ (WebInspector.ElementsPanel.get this):
+ (WebInspector.ElementsPanel):
+ (WebInspector.ElementsPanel.prototype._reset):
+ (WebInspector.ElementsPanel.prototype._setDocument.selectNode):
+ (WebInspector.ElementsPanel.prototype._setDocument.selectLastSelectedNode):
+ (WebInspector.ElementsPanel.prototype._setDocument):
+ (WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged):
+ (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
+ (WebInspector.ElementsPanel.prototype.switchToAndFocus):
+ (WebInspector.ElementsPanel.prototype.selectedDOMNode):
+ (WebInspector.ElementsPanel.prototype.selectDOMNode):
+ (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
+ (WebInspector.ElementsPanel.prototype.updateBreadcrumb.selectCrumbFunction):
+ (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
+ (WebInspector.ElementsPanel.prototype.updateStyles):
+ (WebInspector.ElementsPanel.prototype.updateMetrics):
+ (WebInspector.ElementsPanel.prototype.updateProperties):
+ (WebInspector.ElementsPanel.prototype.updateEventListeners):
+ (WebInspector.ElementsPanel.prototype.handleCopyEvent):
+ (WebInspector.ElementsPanel.prototype.updateFocusedNode):
+ * inspector/front-end/ElementsTreeOutline.js:
+ (WebInspector.ElementsTreeOutline):
+ (WebInspector.ElementsTreeOutline.prototype.selectedDOMNode):
+ (WebInspector.ElementsTreeOutline.prototype.selectDOMNode):
+ (WebInspector.ElementsTreeOutline.prototype.update):
+ (WebInspector.ElementsTreeOutline.prototype._revealAndSelectNode):
+ (WebInspector.ElementsTreeOutline.prototype._ondrop.callback):
+ (WebInspector.ElementsTreeOutline.prototype._ondrop):
+ (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
+ (WebInspector.ElementsTreeElement.prototype._updateChildren):
+ (WebInspector.ElementsTreeElement.prototype.onselect):
+ (WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
+ (WebInspector.ElementsTreeElement.prototype._startEditingTarget):
+ (WebInspector.ElementsTreeElement.prototype._startEditing):
+ * inspector/front-end/Panel.js:
+ (WebInspector.Panel.prototype.reset):
+ * inspector/front-end/ProfileView.js:
+ (WebInspector.CPUProfileView.prototype._jumpToSearchResult):
+ * inspector/front-end/ProfilesPanel.js:
+ (WebInspector.ProfilesPanel.prototype._addProfileHeader):
+ (WebInspector.ProfilesPanel.prototype.showProfile):
+ (WebInspector.ProfileSidebarTreeElement.prototype.onselect):
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype._initDefaultSelection.get if):
+ (WebInspector.ResourcesPanel.prototype._initDefaultSelection):
+ (WebInspector.ResourcesPanel.prototype.reset):
+ (WebInspector.ResourcesPanel.prototype.showResource):
+ * inspector/front-end/StylesSidebarPane.js:
+ (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
+ (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
+ * inspector/front-end/TimelinePanel.js:
+ (WebInspector.TimelinePanel.prototype._createTopPane):
+ * inspector/front-end/inspector.js:
+ * inspector/front-end/inspectorCommon.css:
+ (body):
+ * inspector/front-end/treeoutline.js:
+ (TreeOutline.prototype.revealAndSelect):
+ (TreeElement.prototype.selectOnMouseDown):
+ (TreeElement.prototype.revealAndSelect):
+ (TreeElement.prototype.select):
+
+2011-08-12 Yury Semikhatsky <yurys@chromium.org>
+
+ Unreviewed. Inspector clean-up: remove unused method declaration from InspectorAgent.h
+
+ * inspector/InspectorAgent.h:
+
+2011-08-12 Vsevolod Vlasov <vsevik@chromium.org>
+
+ Web Inspector: Network resource identifier should have RequestId type and requestId name in protocol.
+ https://bugs.webkit.org/show_bug.cgi?id=66061
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/ConsoleMessage.cpp:
+ (WebCore::ConsoleMessage::ConsoleMessage):
+ (WebCore::ConsoleMessage::addToFrontend):
+ * inspector/ConsoleMessage.h:
+ * inspector/IdentifiersFactory.cpp:
+ (WebCore::IdentifiersFactory::requestId):
+ * inspector/IdentifiersFactory.h:
+ * inspector/Inspector.json:
+ * inspector/InspectorConsoleAgent.cpp:
+ (WebCore::InspectorConsoleAgent::didReceiveResponse):
+ (WebCore::InspectorConsoleAgent::didFailLoading):
+ * inspector/InspectorResourceAgent.cpp:
+ (WebCore::InspectorResourceAgent::willSendRequest):
+ (WebCore::InspectorResourceAgent::markResourceAsCached):
+ (WebCore::InspectorResourceAgent::didReceiveResponse):
+ (WebCore::InspectorResourceAgent::didReceiveData):
+ (WebCore::InspectorResourceAgent::didFinishLoading):
+ (WebCore::InspectorResourceAgent::didFailLoading):
+ (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
+ (WebCore::InspectorResourceAgent::setInitialScriptContent):
+ (WebCore::InspectorResourceAgent::didReceiveScriptResponse):
+ (WebCore::InspectorResourceAgent::setInitialXHRContent):
+ (WebCore::InspectorResourceAgent::didReceiveXHRResponse):
+ (WebCore::InspectorResourceAgent::didCreateWebSocket):
+ (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
+ (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
+ (WebCore::InspectorResourceAgent::didCloseWebSocket):
+ (WebCore::InspectorResourceAgent::getResourceContent):
+ * inspector/InspectorResourceAgent.h:
+ * inspector/InspectorTimelineAgent.cpp:
+ (WebCore::InspectorTimelineAgent::willSendResourceRequest):
+ (WebCore::InspectorTimelineAgent::willReceiveResourceData):
+ (WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
+ (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
+ * inspector/NetworkResourcesData.cpp:
+ (WebCore::NetworkResourcesData::ResourceData::ResourceData):
+ (WebCore::NetworkResourcesData::resourceCreated):
+ (WebCore::NetworkResourcesData::responseReceived):
+ (WebCore::NetworkResourcesData::setResourceType):
+ (WebCore::NetworkResourcesData::resourceType):
+ (WebCore::NetworkResourcesData::setResourceContent):
+ (WebCore::NetworkResourcesData::maybeAddResourceData):
+ (WebCore::NetworkResourcesData::maybeDecodeDataToContent):
+ (WebCore::NetworkResourcesData::addCachedResource):
+ (WebCore::NetworkResourcesData::addResourceSharedBuffer):
+ (WebCore::NetworkResourcesData::data):
+ (WebCore::NetworkResourcesData::clear):
+ (WebCore::NetworkResourcesData::ensureNoDataForRequestId):
+ (WebCore::NetworkResourcesData::ensureFreeSpace):
+ * inspector/NetworkResourcesData.h:
+ (WebCore::NetworkResourcesData::ResourceData::requestId):
+ * inspector/TimelineRecordFactory.cpp:
+ (WebCore::TimelineRecordFactory::createResourceSendRequestData):
+ (WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
+ (WebCore::TimelineRecordFactory::createResourceFinishData):
+ (WebCore::TimelineRecordFactory::createReceiveResourceData):
+ * inspector/TimelineRecordFactory.h:
+ * inspector/front-end/ConsoleView.js:
+ (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
+ * inspector/front-end/ExtensionAPI.js:
+ (WebInspector.injectedExtensionAPI.Resources.prototype.getHAR):
+ * inspector/front-end/ExtensionServer.js:
+ (WebInspector.ExtensionServer):
+ (WebInspector.ExtensionServer.prototype._notifyResourceFinished):
+ (WebInspector.ExtensionServer.prototype._onGetHAR):
+ (WebInspector.ExtensionServer.prototype._requestId):
+ * inspector/front-end/NetworkManager.js:
+ (WebInspector.NetworkManager.prototype.requestContent):
+ (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
+ (WebInspector.NetworkDispatcher.prototype.resourceMarkedAsCached):
+ (WebInspector.NetworkDispatcher.prototype.responseReceived):
+ (WebInspector.NetworkDispatcher.prototype.dataReceived):
+ (WebInspector.NetworkDispatcher.prototype.loadingFinished):
+ (WebInspector.NetworkDispatcher.prototype.loadingFailed):
+ (WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
+ (WebInspector.NetworkDispatcher.prototype.webSocketCreated):
+ (WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
+ (WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
+ (WebInspector.NetworkDispatcher.prototype.webSocketClosed):
+ (WebInspector.NetworkDispatcher.prototype._appendRedirect):
+ (WebInspector.NetworkDispatcher.prototype._startResource):
+ (WebInspector.NetworkDispatcher.prototype._finishResource):
+ (WebInspector.NetworkDispatcher.prototype._createResource):
+ * inspector/front-end/NetworkPanel.js:
+ (WebInspector.NetworkLogView.prototype._appendResource):
+ (WebInspector.NetworkLogView.prototype._matchResource):
+ (WebInspector.NetworkLogView.prototype._updateSearchMatchedListAfterRequestIdChanged):
+ (WebInspector.NetworkLogView.prototype.performSearch):
+ * inspector/front-end/Resource.js:
+ (WebInspector.Resource):
+ * inspector/front-end/TimelinePanel.js:
+ (WebInspector.TimelinePanel.prototype._addRecordToTimeline):
+ (WebInspector.TimelinePanel.prototype._findParentRecord):
+ (WebInspector.TimelinePanel.FormattedRecord):
+
+2011-08-11 Hans Wennborg <hans@chromium.org>
+
+ IndexedDB: Object store records don't need to have keys in all indexes
+ https://bugs.webkit.org/show_bug.cgi?id=66049
+
+ Reviewed by Tony Chang.
+
+ Allow inserting records in an object store even though they don't
+ yield keys in some index. The spec has changed in this regard.
+
+ * storage/IDBObjectStoreBackendImpl.cpp:
+ (WebCore::IDBObjectStoreBackendImpl::putInternal):
+
+2011-08-10 Hans Wennborg <hans@chromium.org>
+
+ IndexedDB: Overwriting key in unique index should be possible
+ https://bugs.webkit.org/show_bug.cgi?id=65993
+
+ Reviewed by Tony Chang.
+
+ It should be possible to overwrite an object store record even if
+ there is a derived key for that record in an index with the unique flag set.
+
+ * storage/IDBBackingStore.h:
+ * storage/IDBIndexBackendImpl.cpp:
+ (WebCore::IDBIndexBackendImpl::addingKeyAllowed):
+ * storage/IDBIndexBackendImpl.h:
+ * storage/IDBLevelDBBackingStore.cpp:
+ (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
+ * storage/IDBLevelDBBackingStore.h:
+ * storage/IDBObjectStoreBackendImpl.cpp:
+ (WebCore::IDBObjectStoreBackendImpl::putInternal):
+ * storage/IDBSQLiteBackingStore.cpp:
+ (WebCore::IDBSQLiteBackingStore::keyExistsInIndex):
+ * storage/IDBSQLiteBackingStore.h:
+
+2011-08-11 Yuta Kitamura <yutak@chromium.org>
+
+ WebSocket: Implement "protocol" attribute
+ https://bugs.webkit.org/show_bug.cgi?id=65248
+
+ Reviewed by Kent Tamura.
+
+ Tests: http/tests/websocket/tests/hybi/no-subprotocol.html (added)
+ http/tests/websocket/tests/hybi/set-protocol.html (added)
+ http/tests/websocket/tests/hybi/workers/no-subprotocol.html (added)
+ http/tests/websocket/tests/hixie76/undefined-attributes.html (updated)
+ http/tests/websocket/tests/hybi/multiple-subprotocols.html (updated)
+ http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html (updated)
+
+ * websockets/ThreadableWebSocketChannel.h:
+ Added subprotocol() function. This function is named differently from the counterpart of
+ WebSocket class, because the name "protocol" can be confused with the WebSocket protocol.
+ Added m_useHixie76Protocol and m_subprotocol, because these value may be used after
+ m_channel has been released. Using bool should be fine, because boolean literals do not
+ appear in ambiguous context.
+ * websockets/ThreadableWebSocketChannelClientWrapper.cpp:
+ (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
+ (WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
+ (WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):
+ * websockets/ThreadableWebSocketChannelClientWrapper.h:
+ * websockets/WebSocket.cpp:
+ (WebCore::WebSocket::WebSocket):
+ (WebCore::WebSocket::connect):
+ (WebCore::WebSocket::protocol):
+ The "protocol" attribute is available only when the hybi-10 protocol is chosen.
+ (WebCore::WebSocket::binaryType):
+ (WebCore::WebSocket::setBinaryType):
+ (WebCore::WebSocket::didConnect):
+ * websockets/WebSocket.h:
+ * websockets/WebSocket.idl:
+ * websockets/WebSocketChannel.cpp:
+ (WebCore::WebSocketChannel::subprotocol):
+ * websockets/WebSocketChannel.h:
+ * websockets/WorkerThreadableWebSocketChannel.cpp:
+ (WebCore::WorkerThreadableWebSocketChannel::subprotocol):
+ (WebCore::workerContextDidConnect):
+ Subprotocol value is saved in the client wrapper object after the WebSocket connection is
+ established.
+ (WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect):
+ * websockets/WorkerThreadableWebSocketChannel.h:
+
+2011-08-11 Hayato Ito <hayato@chromium.org>
+
+ Implement proper handling of events with a related target in regard to shadow DOM boundaries.
+ https://bugs.webkit.org/show_bug.cgi?id=65899
+
+ Reviewed by Dimitri Glazkov.
+
+ Fixes issues in the following corner cases:
+ 1. When both a target node and a relatedTarget node are immediate children of
+ the same shadow root, an event is not dispatched.
+ 2. If a target node is an ancestor of a relatedTarget node, crossing
+ shadow boundaries, or vice verse, an event is not dispatched or wrongly
+ dispatched.
+
+ Test: fast/dom/shadow/shadow-boundary-events.html
+
+ * dom/EventDispatcher.cpp:
+ (WebCore::EventDispatcher::adjustToShadowBoundaries):
+
+2011-08-11 John Bauman <jbauman@chromium.org>
+
+ Readback composited webgl results for printing
+ https://bugs.webkit.org/show_bug.cgi?id=65658
+
+ Reviewed by James Robinson.
+
+ The real composited results may be locked inside the compositor
+ context's version of a texture because the drawing buffer was
+ automatically cleared, so read from there to get the actual presented
+ version to draw.
+
+ * html/canvas/WebGLRenderingContext.cpp:
+ (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
+ * platform/graphics/GraphicsContext3D.h:
+ * platform/graphics/chromium/Extensions3DChromium.h:
+ * platform/graphics/chromium/WebGLLayerChromium.cpp:
+ (WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
+ * platform/graphics/chromium/WebGLLayerChromium.h:
+ * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
+ (WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
+
+2011-08-11 Andrew Wason <rectalogic@rectalogic.com>
+
+ REGRESSION: Qt JavaScript bridge signal connection fails
+ https://bugs.webkit.org/show_bug.cgi?id=66097
+
+ Reviewed by Gavin Barraclough.
+
+ Tests in WebKit/qt/tests/qwebframe
+
+ Call toThisObject() on exec->lexicalGlobalObject() so the correct
+ object is passed to the JS signal handler.
+
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::QtRuntimeConnectionMethod::call):
+
+2011-08-11 Nico Weber <thakis@chromium.org>
+
+ Remove incorrect comment about m_wheelEventHandlerCount
+ https://bugs.webkit.org/show_bug.cgi?id=66117
+
+ Reviewed by Simon Fraser.
+
+ From what I can tell, this number is changed only in
+ Frame::notifyChromeClientWheelEventHandlerCountChanged(),
+ and there it just reads the number modified in
+ Document::didAdd/RemoveWheelEventHandler(). So this is just the number
+ of event handlers (and not related to horizontal scrollbars), and the
+ variable name expresses that already.
+
+ * dom/Document.h:
+
+2011-08-11 James Robinson <jamesr@chromium.org>
+
+ [chromium] Defer managed texture creation and destruction until updateCompositorResources
+ https://bugs.webkit.org/show_bug.cgi?id=64772
+
+ Reviewed by Kenneth Russell.
+
+ This adds support for deferring GraphicsContext3D calls for texture creation and destruction for managed
+ textures and defers these calls until updateCompositorResources() for contents textures. The primary benefit of
+ this change is that it decouples managing the texture budget for the next frame (which has to happen before
+ painting layer contents) from the actual GL calls that create/destroy textures. That way, in the threaded
+ compositing world we can continue to use textures from the previous frame while software painting contents for
+ the next frame into software buffers or SkPictures.
+
+ Also renames LayerTexture to ManagedTexture to better reflect what it is. Not all ManagedTextures we create are
+ necessarily associated with layers, but they are all managed by a TextureManager.
+
+ Covered by compositing/ layout tests.
+
+ * WebCore.gypi:
+ * platform/graphics/chromium/ContentLayerChromium.h:
+ * platform/graphics/chromium/ImageLayerChromium.cpp:
+ (WebCore::ImageLayerTextureUpdater::updateTextureRect):
+ * platform/graphics/chromium/LayerRendererChromium.cpp:
+ (WebCore::LayerRendererChromium::releaseTextures):
+ (WebCore::LayerRendererChromium::drawLayers):
+ (WebCore::LayerRendererChromium::updateLayers):
+ (WebCore::LayerRendererChromium::getOffscreenLayerTexture):
+ (WebCore::LayerRendererChromium::useRenderSurface):
+ (WebCore::LayerRendererChromium::initializeSharedObjects):
+ * platform/graphics/chromium/LayerRendererChromium.h:
+ * platform/graphics/chromium/LayerTextureUpdater.h:
+ * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
+ (WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
+ (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
+ * platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
+ * platform/graphics/chromium/LayerTilerChromium.cpp:
+ (WebCore::LayerTilerChromium::getSingleTexture):
+ (WebCore::LayerTilerChromium::createTile):
+ (WebCore::LayerTilerChromium::updateRect):
+ (WebCore::LayerTilerChromium::drawTiles):
+ * platform/graphics/chromium/LayerTilerChromium.h:
+ (WebCore::LayerTilerChromium::Tile::Tile):
+ (WebCore::LayerTilerChromium::Tile::texture):
+ * platform/graphics/chromium/ManagedTexture.cpp: Renamed from Source/WebCore/platform/graphics/chromium/LayerTexture.cpp.
+ (WebCore::ManagedTexture::ManagedTexture):
+ (WebCore::ManagedTexture::~ManagedTexture):
+ (WebCore::ManagedTexture::isValid):
+ (WebCore::ManagedTexture::reserve):
+ (WebCore::ManagedTexture::unreserve):
+ (WebCore::ManagedTexture::bindTexture):
+ (WebCore::ManagedTexture::framebufferTexture2D):
+ * platform/graphics/chromium/ManagedTexture.h: Renamed from Source/WebCore/platform/graphics/chromium/LayerTexture.h.
+ (WebCore::ManagedTexture::create):
+ (WebCore::ManagedTexture::format):
+ (WebCore::ManagedTexture::isReserved):
+ * platform/graphics/chromium/RenderSurfaceChromium.h:
+ * platform/graphics/chromium/TextureManager.cpp:
+ (WebCore::TextureManager::TextureManager):
+ (WebCore::TextureManager::deleteEvictedTextures):
+ (WebCore::TextureManager::removeTexture):
+ (WebCore::TextureManager::allocateTexture):
+ (WebCore::TextureManager::requestTexture):
+ * platform/graphics/chromium/TextureManager.h:
+ (WebCore::TextureManager::create):
+ (WebCore::TextureManager::setAssociatedContextDebugOnly):
+ (WebCore::TextureManager::associatedContextDebugOnly):
+ * platform/graphics/chromium/TiledLayerChromium.h:
+ * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
+ (WebCore::CCHeadsUpDisplay::draw):
+ * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
+ * platform/graphics/chromium/cc/CCRenderSurface.cpp:
+ (WebCore::CCRenderSurface::prepareContentsTexture):
+ (WebCore::CCRenderSurface::drawSurface):
+ * platform/graphics/chromium/cc/CCRenderSurface.h:
+ (WebCore::CCRenderSurface::contentsTexture):
+ * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
+ (WebCore::CCTiledLayerImpl::bindContentsTexture):
+
+2011-08-11 David Kilzer <ddkilzer@apple.com>
+
+ <http://webkit.org/b/66113> [CFNetwork] willCacheResponse() leaks CFCachedURLResponseRef if delegate changes CacheStoragePolicy
+
+ Reviewed by Joseph Pecoraro.
+
+ This first appeared in ToT WebKit r23462 (Windows merge).
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::willCacheResponse): Only retain cachedResponse if we
+ are returning the same object passed into the method, otherwise
+ we end up double-retaining the new object created.
+
+2011-08-05 Nat Duca <nduca@chromium.org>
+
+ [chromium] Make WebViewImpl point at CCLayerTreeHost and related separation
+ https://bugs.webkit.org/show_bug.cgi?id=65791
+
+ With this patch, LayerRendererChromium becomes increasingly responsible
+ for rendering, while render scheduling and tree hosting moves into the
+ CCLayerTreeHost.
+
+ Reviewed by James Robinson.
+
+ * platform/graphics/chromium/ContentLayerChromium.cpp:
+ (WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
+ * platform/graphics/chromium/LayerChromium.h:
+ * platform/graphics/chromium/LayerRendererChromium.cpp:
+ (WebCore::LayerRendererChromium::create):
+ (WebCore::LayerRendererChromium::LayerRendererChromium):
+ (WebCore::LayerRendererChromium::initialize):
+ (WebCore::LayerRendererChromium::releaseTextures):
+ (WebCore::LayerRendererChromium::updateRootLayerContents):
+ (WebCore::LayerRendererChromium::drawRootLayer):
+ (WebCore::LayerRendererChromium::invalidateRootLayerRect):
+ (WebCore::LayerRendererChromium::rootLayerChanged):
+ (WebCore::LayerRendererChromium::viewportChanged):
+ (WebCore::LayerRendererChromium::updateLayers):
+ (WebCore::LayerRendererChromium::drawLayers):
+ (WebCore::LayerRendererChromium::drawLayersInternal):
+ (WebCore::LayerRendererChromium::getFramebufferPixels):
+ (WebCore::LayerRendererChromium::getOffscreenLayerTexture):
+ (WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
+ (WebCore::LayerRendererChromium::useRenderSurface):
+ (WebCore::LayerRendererChromium::setScissorToRect):
+ (WebCore::LayerRendererChromium::layerTreeAsText):
+ (WebCore::LayerRendererChromium::dumpRenderSurfaces):
+ * platform/graphics/chromium/LayerRendererChromium.h:
+ (WebCore::LayerRendererChromium::settings):
+ (WebCore::LayerRendererChromium::owner):
+ (WebCore::LayerRendererChromium::rootLayer):
+ (WebCore::LayerRendererChromium::skiaContext):
+ * platform/graphics/chromium/WebGLLayerChromium.cpp:
+ (WebCore::WebGLLayerChromium::setTextureUpdated):
+ * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
+ (WebCore::CCHeadsUpDisplay::draw):
+ (WebCore::CCHeadsUpDisplay::enabled):
+ * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
+ * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+ (WebCore::CCLayerTreeHost::create):
+ (WebCore::CCLayerTreeHost::CCLayerTreeHost):
+ (WebCore::CCLayerTreeHost::initialize):
+ (WebCore::CCLayerTreeHost::animateAndLayout):
+ (WebCore::CCLayerTreeHost::createLayerTreeHostCommitter):
+ (WebCore::CCLayerTreeHost::createLayerTreeHostImpl):
+ (WebCore::CCLayerTreeHost::context):
+ (WebCore::CCLayerTreeHost::compositeAndReadback):
+ (WebCore::CCLayerTreeHost::createRootLayerPainter):
+ (WebCore::CCLayerTreeHost::finishAllRendering):
+ (WebCore::CCLayerTreeHost::invalidateRootLayerRect):
+ (WebCore::CCLayerTreeHost::setNeedsCommitAndRedraw):
+ (WebCore::CCLayerTreeHost::setNeedsRedraw):
+ (WebCore::CCLayerTreeHost::setRootLayer):
+ (WebCore::CCLayerTreeHost::setViewport):
+ (WebCore::CCLayerTreeHost::setVisible):
+ (WebCore::CCLayerTreeHost::doComposite):
+ (WebCore::CCLayerTreeHost::composite):
+ (WebCore::CCLayerTreeHost::reallocateRenderer):
+ * platform/graphics/chromium/cc/CCLayerTreeHost.h:
+ (WebCore::CCLayerTreeHost::animating):
+ (WebCore::CCLayerTreeHost::setAnimating):
+ (WebCore::CCLayerTreeHost::rootLayer):
+ (WebCore::CCLayerTreeHost::settings):
+ (WebCore::CCLayerTreeHost::viewportContentRect):
+ (WebCore::CCLayerTreeHost::viewportScrollPosition):
+ (WebCore::CCLayerTreeHost::viewportVisibleRect):
+ * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+ (WebCore::CCLayerTreeHostImpl::create):
+ (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
+ (WebCore::CCLayerTreeHostImpl::drawLayers):
+ (WebCore::CCLayerTreeHostImpl::drawLayersOnMainThread):
+ * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
+ * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:
+ (WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread):
+
+2011-08-11 Jeff Miller <jeffm@apple.com>
+
+ WebCore::AVFWrapper fails to remove observer for kCACFContextNeedsFlushNotification
+ https://bugs.webkit.org/show_bug.cgi?id=66116
+
+ We need to pass 0 as the object parameter to CFNotificationCenterRemoveObserver() when removing
+ kCACFContextNeedsFlushNotification to match what we do when we registered for the same
+ notification with CFNotificationCenterAddObserver().
+
+ Reviewed by John Sullivan.
+
+ No new tests, uses existing media tests.
+
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
+ (WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Pass 0 as the object parameter to CFNotificationCenterRemoveObserver().
+ (WebCore::AVFWrapper::notificationCallback): Remove obsolete FIXME comment.
+
+2011-08-11 Ryosuke Niwa <rniwa@webkit.org>
+
+ Share code between isStyleSpanOrSpanWithOnlyStyleAttribute, isUnstyledStyleSpan,
+ isSpanWithoutAttributesOrUnstyleStyleSpan and replaceWithSpanOrRemoveIfWithoutAttributes
+ https://bugs.webkit.org/show_bug.cgi?id=66091
+
+ Reviewed by Tony Chang.
+
+ Extracted common code as hasNoAttributeOrOnlyStyleAttribute. The only behavioral difference is that
+ replaceWithSpanOrRemoveIfWithoutAttributes will now remove elements with class="Apple-style-span",
+ for which I'm adding a test.
+
+ Test: editing/style/remove-styled-element-with-style-span.html
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::hasNoAttributeOrOnlyStyleAttribute):
+ (WebCore::isStyleSpanOrSpanWithOnlyStyleAttribute):
+ (WebCore::isUnstyledStyleSpan):
+ (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan):
+ (WebCore::ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes):
+
+2011-08-11 Tom Zakrajsek <tomz@codeaurora.org>
+
+ Add HTMLUnknownElement interface as defined in
+ http://www.w3.org/TR/html5/elements.html#elements-in-the-dom.
+ https://bugs.webkit.org/show_bug.cgi?id=41841
+
+ Reviewed by Adam Barth.
+
+ Test: fast/html/unknown-tag.html
+
+ * CMakeLists.txt:
+ * CodeGenerators.pri:
+ * DerivedSources.cpp:
+ * DerivedSources.make:
+ * GNUmakefile.list.am:
+ * WebCore.gypi:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (IsDOMNodeType):
+ * dom/make_names.pl:
+ (defaultParametersHash):
+ (buildConstructorMap):
+ (printJSElementIncludes):
+ (printElementIncludes):
+ (printWrapperFunctions):
+ (printWrapperFactoryCppFile):
+ * html/HTMLTagNames.in:
+ * html/HTMLUnknownElement.h: Added.
+ (WebCore::HTMLUnknownElement::create):
+ (WebCore::HTMLUnknownElement::HTMLUnknownElement):
+ * html/HTMLUnknownElement.idl: Added.
+ * mathml/mathtags.in:
+ * page/DOMWindow.idl:
+ * svg/svgtags.in:
+
+2011-08-11 Levi Weintraub <leviw@chromium.org>
+
+ Remove dead code: borderInnerRect
+ https://bugs.webkit.org/show_bug.cgi?id=66087
+
+ Reviewed by Adam Barth.
+
+ Removing an old and currently unused function: RenderObject::borderInnerRect.
+
+ No new tests since I'm just pruning dead code.
+
+ * rendering/RenderObject.cpp:
+ * rendering/RenderObject.h:
+
+2011-08-11 Simon Fraser <simon.fraser@apple.com>
+
+ Avoid adding the visible wash layer twice
+ https://bugs.webkit.org/show_bug.cgi?id=66098
+
+ Reviewed by Chris Marrin.
+
+ Fix two issues; only create a m_visibleTileWashLayer if we don't have one
+ already, and avoid adding multiple m_visibleTileWashLayers to the sublayers
+ array when flipping between tiled and non-tiled.
+
+ * platform/graphics/ca/GraphicsLayerCA.cpp:
+ (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
+
+2011-08-11 Benjamin Poulain <benjamin@webkit.org>
+
+ The PageSerializer should always use absolute URL
+ https://bugs.webkit.org/show_bug.cgi?id=66006
+
+ Reviewed by Adam Barth.
+
+ Page serializer resolves every URL for storing the resources.
+ The MarkupAccumulator used there should use the same rules in order to
+ create a valid file.
+
+ No new tests because the test infrastructure for this
+ does not exist with layout tests and the Chromium unit test for
+ the serializer are disabled.
+
+ * page/PageSerializer.cpp:
+ (WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator):
+
+2011-08-01 Adrienne Walker <enne@google.com>
+
+ Enable fast path scrolling for composited iframes
+ https://bugs.webkit.org/show_bug.cgi?id=65056
+
+ Reviewed by James Robinson.
+
+ iframes with composited layers for content should be able to do fast
+ path scrolling because they draw into their own backing. To enable
+ this, useSlowRepaints is modified to return true only for the cases
+ that apply to composited layers. The fast path scrolling function is
+ modified to send the invalidation to the backing itself rather than to
+ the window.
+
+ Renamed a number of "slow repaint" functions to be the more accurate
+ "cannot blit to window" as it will not always force slow path
+ scrolling.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::reset):
+ (WebCore::FrameView::useSlowRepaints):
+ (WebCore::FrameView::useSlowRepaintsIfNotOverlapped):
+ (WebCore::FrameView::contentsInCompositedLayer):
+ (WebCore::FrameView::setCannotBlitToWindow):
+ (WebCore::FrameView::scrollContentsFastPath):
+ (WebCore::FrameView::scrollContentsSlowPath):
+ * page/FrameView.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::cannotBlitToWindow):
+ * rendering/RenderLayer.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::paintBoxDecorations):
+
+2011-08-10 Adrienne Walker <enne@google.com>
+
+ Support creating compositing layers for scrollable frames and iframes
+ https://bugs.webkit.org/show_bug.cgi?id=55257
+
+ Reviewed by James Robinson.
+
+ When force compositing mode is turned on, iframes with overflow will
+ become composited (in order to enable faster scrolling).
+
+ This patch was originally by Daniel Sievers <sievers@chromium.org>.
+
+ Tests: platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html
+ platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html
+ platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html
+ platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html
+ platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html
+
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
+ (WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame):
+ * rendering/RenderLayerCompositor.h:
+
+2011-08-11 Yong Li <yoli@rim.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=65944
+ Replace QuotesData::operator==() with QuotesData::equal(const QuotesData*
+ , const QuotesData*) because QuotesData::operator==() were using non-standard
+ C++ code that is not supported by all compilers.
+
+ Reviewed by Alexey Proskuryakov.
+
+ No new tests because some existing test cases can show the issue,
+ for example, fast/css/content/content-quotes-01.html.
+
+ * rendering/RenderQuote.cpp:
+ (WebCore::RenderQuote::styleDidChange):
+ * rendering/style/QuotesData.cpp:
+ (WebCore::QuotesData::equal):
+ * rendering/style/QuotesData.h:
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::setQuotes):
+ * rendering/style/StyleRareInheritedData.cpp:
+ (WebCore::StyleRareInheritedData::operator==):
+
+2011-08-11 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=66075
+
+ Turn on regions and exclusions by default. Fix one stray ifdef that I missed.
+
+ Reviewed by James Robinson.
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::contentToCSSValue):
+
+2011-08-11 David Reveman <reveman@chromium.org>
+
+ [Chromium] Temporarily disable layer anti-aliasing on ChromeOS.
+ https://bugs.webkit.org/show_bug.cgi?id=65922
+
+ Reviewed by James Robinson.
+
+ No new tests.
+
+ * platform/graphics/chromium/LayerTilerChromium.cpp:
+ (WebCore::LayerTilerChromium::draw):
+
+2011-08-11 Benjamin Poulain <benjamin@webkit.org>
+
+ [Qt] PageSerializer is specific to MHTML, we should not compile it
+ https://bugs.webkit.org/show_bug.cgi?id=66054
+
+ Reviewed by Noam Rosenthal.
+
+ PageSerializer is specific to MHTML. Do not build PageSerializer unless MHTML is enabled.
+
+ * WebCore.pro:
+
+2011-08-11 Andrey Kosyakov <caseq@chromium.org>
+
+ Web Inspector: [refactoring] make tabbed pane a view
+ https://bugs.webkit.org/show_bug.cgi?id=66060
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/NetworkItemView.js:
+ (WebInspector.NetworkItemView):
+ (WebInspector.NetworkItemView.prototype.show):
+ (WebInspector.NetworkItemView.prototype._selectTab.get if):
+ (WebInspector.NetworkItemView.prototype._selectTab):
+ * inspector/front-end/TabbedPane.js:
+ (WebInspector.TabbedPane):
+ * inspector/front-end/inspector.html:
+
+2011-08-11 Andrey Kosyakov <caseq@chromium.org>
+
+ Web Inspector: source frame popover simetimes pops up after user switches from Scripts panel
+ https://bugs.webkit.org/show_bug.cgi?id=66057
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/SourceFrame.js: remove popover timer when removing popover.
+ (WebInspector.SourceFrame.prototype._mouseDown):
+ (WebInspector.SourceFrame.prototype._hidePopup):
+
+2011-08-11 Vsevolod Vlasov <vsevik@chromium.org>
+
+ Web Inspector: Scripts panel: display the current search match index in the toolbar.
+ https://bugs.webkit.org/show_bug.cgi?id=66048
+
+ Reviewed by Pavel Feldman.
+
+ * English.lproj/localizedStrings.js:
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
+ (WebInspector.ScriptsPanel.prototype.performSearch):
+ (WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
+ (WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
+ * inspector/front-end/SearchController.js:
+ (WebInspector.SearchController.prototype.updateSearchMatchesCount):
+ (WebInspector.SearchController.prototype.updateCurrentMatchIndex):
+ (WebInspector.SearchController.prototype.activePanelChanged.performPanelSearch):
+ (WebInspector.SearchController.prototype.activePanelChanged):
+ (WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):
+ (WebInspector.SearchController.prototype._performSearch):
+ * inspector/front-end/SourceFrame.js:
+ (WebInspector.SourceFrame.prototype.get currentSearchResultIndex):
+
+2011-08-11 Xan Lopez <xlopez@igalia.com>
+
+ [GTK] Add another missing file to GNUmakefile
+
+ Reviewed by Gustavo Noronha.
+
+ * GNUmakefile.list.am:
+
+2011-08-11 Xan Lopez <xlopez@igalia.com>
+
+ [GTK] Add missing files to GNUMakefile
+
+ Reviewed by Gustavo Noronha.
+
+ * GNUmakefile.am:
+ * GNUmakefile.list.am:
+
+2011-08-11 Yuta Kitamura <yutak@chromium.org>
+
+ WebSocket: Use PassRefPtr<> in function arguments in WorkerThreadableWebSocketChannel.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=66047
+
+ Reviewed by Kent Tamura.
+
+ It's safe to use PassRefPtr<> in these functions because:
+ - CrossThreadTask knows how to pass a RefPtr<> across threads, and
+ - Call sites do not pass the pointers to anywhere else.
+
+ No change in functionality, thus no new tests.
+
+ * websockets/WorkerThreadableWebSocketChannel.cpp:
+ (WebCore::workerContextDidSend):
+ (WebCore::workerContextDidGetBufferedAmount):
+ (WebCore::workerContextDidConnect):
+ (WebCore::workerContextDidReceiveMessage):
+ (WebCore::workerContextDidStartClosingHandshake):
+ (WebCore::workerContextDidClose):
+
+2011-08-11 Pavel Feldman <pfeldman@google.com>
+
+ Web Inspector: [Mac] search as you type does not work with the new indent in the script selector.
+ https://bugs.webkit.org/show_bug.cgi?id=66039
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
+ * inspector/front-end/inspector.css:
+ (select.status-bar-item):
+
+2011-08-11 Alexis Menard <alexis.menard@openbossa.org>
+
+ Unreviewed build fix for Qt.
+
+ Make sure we build when Qt is namespaced.
+
+ * platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
+
+2011-08-11 Pavel Podivilov <podivilov@chromium.org>
+
+ Web Inspector: use source-file-replaced instead of source-file-changed event.
+ https://bugs.webkit.org/show_bug.cgi?id=65551
+
+ Reviewed by Pavel Feldman.
+
+ Test: inspector/debugger/source-frame-count.html
+
+ * inspector/front-end/DebuggerPresentationModel.js:
+ (WebInspector.DebuggerPresentationModel.prototype._addScript):
+ (WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeReplaced):
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype._removeSourceFrame):
+ (WebInspector.ScriptsPanel.prototype._sourceFileReplaced):
+ * inspector/front-end/SourceFile.js:
+ (WebInspector.RawSourceCode):
+ (WebInspector.RawSourceCode.prototype.get uiSourceCode):
+ (WebInspector.RawSourceCode.prototype.reload):
+ * inspector/front-end/inspector.js:
+ (WebInspector._createPanels):
+
+2011-08-11 Vsevolod Vlasov <vsevik@chromium.org>
+
+ Web Inspector: [REGRESSION] Resources panel search fails when search result is found in a resource used in several frames.
+ https://bugs.webkit.org/show_bug.cgi?id=66007
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype.performSearch.callback):
+ (WebInspector.ResourcesPanel.prototype.performSearch):
+ (WebInspector.FrameTreeElement.prototype.resourceByURL):
+
+2011-08-11 Andras Becsi <abecsi@webkit.org>
+
+ [GTK] Fix the build after r92792.
+
+ Rubber-stamped by Csaba Osztrogonác.
+
+ No new tests needed.
+
+ * GNUmakefile.list.am: add missing
+ RenderFlowThread.{cpp|h}
+ RenderRegion.{cpp|h}
+
+2011-08-11 Renata Hodovan <reni@webkit.org>
+
+ [Qt] Fix WebGL on Windows after r92805
+ https://bugs.webkit.org/show_bug.cgi?id=66042
+
+ WEBGL is temporarly disabled, because it broked the bots.
+
+ * features.pri:
+
+2011-08-11 Pavel Feldman <pfeldman@google.com>
+
+ Web Inspector: do not evaluate watch expressions on load.
+ https://bugs.webkit.org/show_bug.cgi?id=66002
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype.show):
+ (WebInspector.ScriptsPanel.prototype.hide):
+ (WebInspector.ScriptsPanel.prototype.reset):
+ * inspector/front-end/WatchExpressionsSidebarPane.js:
+ (WebInspector.WatchExpressionsSidebarPane):
+ (WebInspector.WatchExpressionsSidebarPane.prototype.hide):
+ (WebInspector.WatchExpressionsSidebarPane.prototype.reset):
+ (WebInspector.WatchExpressionsSidebarPane.prototype.refreshExpressions):
+ (WebInspector.WatchExpressionsSidebarPane.prototype._refreshExpressionsIfNeeded):
+ (WebInspector.WatchExpressionsSidebarPane.prototype._refreshButtonClicked):
+
+2011-08-10 Ryosuke Niwa <rniwa@webkit.org>
+
+ Copying can result in span around block elements on the clipboard
+ https://bugs.webkit.org/show_bug.cgi?id=34564
+
+ Reviewed by Tony Chang.
+
+ Completely overhauled the way WebKit preserves style in copy and paste. Instead of wrapping the entire
+ serialized contents by a Apple style span, WebKit now adds inline style to the top level elements,
+ wrap top level text nodes by a style span.
+
+ * editing/EditingStyle.cpp:
+ (WebCore::EditingStyle::collapseTextDecorationProperties): Remove text-decoration property when the value
+ of -webkit-text-decorations-in-effect is none.
+ (WebCore::EditingStyle::removeStyleFromRulesAndContext): Since display: inline and float: none are now
+ added on copy, remove these properties on paste.
+ (WebCore::EditingStyle::removePropertiesInElementDefaultStyle): Takes Element* instead of StyledElement*.
+ (WebCore::EditingStyle::forceInline): Added.
+ (WebCore::getPropertiesNotIn): Remove properties only when the base style has them.
+ * editing/EditingStyle.h:
+ * editing/markup.cpp:
+ (WebCore::StyledMarkupAccumulator::shouldApplyWrappingStyle): Added.
+ (WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator): Takes highestNodeToBeSerialized.
+ (WebCore::StyledMarkupAccumulator::wrapWithStyleNode): Calls appendStyleNodeOpenTag and styleNodeCloseTag.
+ (WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): Extracted from wrapWithStyleNode.
+ (WebCore::StyledMarkupAccumulator::styleNodeCloseTag): Ditto.
+ (WebCore::StyledMarkupAccumulator::appendText): Wraps text node with a style span if needed.
+ Set display: inline and float: none so that it won't be converted to a block on paste side.
+ (WebCore::StyledMarkupAccumulator::appendElement): Add wrapping style if appropriate; Remove any properties
+ that are overridden by default style and any style that may conflict with the computed style of node to
+ avoid modifying the appearance of the serialized nodes.
+ (WebCore::StyledMarkupAccumulator::serializeNodes): Compute wrapping style; copies of this style are
+ modified as needed when serializing top-level elements or text nodes. We call traverseNodesForSerialization
+ with NodeTraversalMode set to DoNotEmitString first to compute the highest node to be serialized. The second
+ call to the function actually serialize the nodes.
+ (WebCore::StyledMarkupAccumulator::traverseNodesForSerialization): Extracted from serializeNodes.
+ Outputs string only if NodeTraversalMode is set to EmitString.
+ (WebCore::createMarkup): No longer adds wrapping spans.
+
+2011-08-10 Adam Barth <abarth@webkit.org>
+
+ Add tests of optional arguments for Geolocation
+ https://bugs.webkit.org/show_bug.cgi?id=65810
+
+ Reviewed by Sam Weinig.
+
+ Geolocation's treatment of not-enough-arguments almost matches the
+ spec. getCurrentPosition and watchPosition work properly, but, because
+ they are custom, we should use the prettier form of the [Optional]
+ attribute.
+
+ Before this series of patches, clearWatch argument was optional, but
+ that doesn't match the spec or other browsers. Calling this function
+ with zero arguments is pretty non-sensical, so there shouldn't be much
+ compat risk to tightening up our behavior here. Matching other
+ browsers and the spec seems like the bigger win. If we run into compat
+ problems, we can re-evaluate this decision.
+
+ Test: fast/dom/Geolocation/not-enough-arguments.html
+
+ * page/Geolocation.idl:
+
+2011-08-10 Tim Horton <timothy_horton@apple.com>
+
+ SVGAElement check for internal non-view anchors is inside ENABLE(SVG_ANIMATION)
+ https://bugs.webkit.org/show_bug.cgi?id=66026
+
+ Reviewed by Rob Buis.
+
+ Move only the SMIL-related code inside the ENABLE(SVG_ANIMATION) block.
+
+ No new tests, as it depends on the enabled features.
+
+ * svg/SVGAElement.cpp:
+ (WebCore::SVGAElement::defaultEventHandler):
+
+2011-08-10 Tim Horton <timothy_horton@apple.com>
+
+ Crash when clicking an SVG <a> link to the local document
+ https://bugs.webkit.org/show_bug.cgi?id=66019
+ <rdar://problem/9933311>
+
+ Reviewed by Rob Buis.
+
+ Check if the target element of an internal link is valid before
+ making use of it.
+
+ Test: svg/custom/click-internal-anchor-with-use-crash.xhtml
+
+ * svg/SVGAElement.cpp:
+ (WebCore::SVGAElement::defaultEventHandler):
+
+2011-08-10 No'am Rosenthal <noam.rosenthal@nokia.com>
+
+ [Qt] Enable WebGL by default for QtWebKit
+ https://bugs.webkit.org/show_bug.cgi?id=65998
+
+ Reviewed by Benjamin Poulain.
+
+ Make ENABLE_WEBGL true by default when Qt is configured with OpenGL.
+
+ No new tests. Build change only.
+
+ * features.pri:
+
+2011-08-10 Abhishek Arya <inferno@chromium.org>
+
+ Check that we do not need layout before trying to dirty
+ m_originatingLine for our floats.
+ https://bugs.webkit.org/show_bug.cgi?id=65938
+
+ Reviewed by Dave Hyatt.
+
+ Test: fast/block/float/float-originating-line-deleted-crash.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::removeFloatingObject):
+ (WebCore::RenderBlock::clearFloats):
+
+2011-08-10 David Hyatt <hyatt@apple.com>
+
+ Add missing regions/exclusions-related files to EFL.
+
+ * CMakeLists.txt:
+
+2011-08-10 David Hyatt <hyatt@apple.com>
+
+ Add missing regions/exclusions-related files to Chromium.
+
+ * WebCore.gypi:
+
+2011-08-10 David Hyatt <hyatt@apple.com>
+
+ Fix Qt build bustage. Add missing regions/exclusions-related files to their project.
+
+ * WebCore.pro:
+
+2011-08-10 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=66004
+
+ Remove ifdefs for CSS Exclusions (since the feature doesn't exist any longer and has morphed into positioned
+ floats instead). Go ahead and yank the ifdefs for CSS Regions also and just turn them on.
+
+ Reviewed by Adam Roben.
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue):
+ (WebCore::CSSParser::parseContent):
+ (WebCore::CSSParser::parseWrapShape):
+ (WebCore::CSSParser::parseFromFlowContent):
+ * css/CSSParser.h:
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::init):
+ (WebCore::CSSPrimitiveValue::cleanup):
+ (WebCore::CSSPrimitiveValue::getStringValue):
+ (WebCore::CSSPrimitiveValue::cssText):
+ * css/CSSPrimitiveValue.h:
+ (WebCore::CSSPrimitiveValue::getShapeValue):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::operator RegionOverflow):
+ * css/CSSPropertyNames.in:
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+ * css/CSSValueKeywords.in:
+ * css/CSSWrapShapes.cpp:
+ * css/CSSWrapShapes.h:
+ * css/SVGCSSValueKeywords.in:
+ * dom/Node.cpp:
+ (WebCore::Node::diff):
+ * dom/NodeRenderingContext.cpp:
+ (WebCore::NodeRenderingContext::NodeRenderingContext):
+ (WebCore::NodeRenderingContext::setStyle):
+ (WebCore::NodeRenderingContext::nextRenderer):
+ (WebCore::NodeRenderingContext::previousRenderer):
+ (WebCore::NodeRenderingContext::parentRenderer):
+ (WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
+ (WebCore::NodeRendererFactory::createRendererIfNeeded):
+ * dom/NodeRenderingContext.h:
+ * rendering/RenderFlowThread.cpp:
+ * rendering/RenderFlowThread.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::collectLayers):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::createObject):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::isRenderRegion):
+ (WebCore::RenderObject::isRenderFlowThread):
+ * rendering/RenderRegion.cpp:
+ * rendering/RenderRegion.h:
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::writeLayers):
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::renderFlowThreadWithName):
+ * rendering/RenderView.h:
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::diff):
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::regionOverflow):
+ (WebCore::InheritedFlags::setRegionOverflow):
+ (WebCore::InheritedFlags::initialWrapShape):
+ (WebCore::InheritedFlags::initialRegionOverflow):
+ * rendering/style/RenderStyleConstants.h:
+ * rendering/style/StyleRareNonInheritedData.cpp:
+ (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
+ (WebCore::StyleRareNonInheritedData::operator==):
+ * rendering/style/StyleRareNonInheritedData.h:
+
+2011-08-10 Abhishek Arya <inferno@chromium.org>
+
+ Don't create html renderer for SVG <glyphRef>
+ https://bugs.webkit.org/show_bug.cgi?id=66000
+
+ Reviewed by David Hyatt.
+
+ Test: svg/text/glyphref-renderer-create-crash.html
+
+ * svg/SVGGlyphRefElement.h:
+
+2011-08-10 Scott Graham <scottmg@google.com>
+
+ OpenTypeSanitizer in chromium gyp files is linked twice
+ https://bugs.webkit.org/show_bug.cgi?id=65927
+
+ Reviewed by Adam Barth.
+
+ No new tests, should just build and link properly on all platforms.
+
+ * WebCore.gyp/WebCore.gyp:
+
+2011-08-10 Oliver Hunt <oliver@apple.com>
+
+ Make GC checks more aggressive in release builds
+ https://bugs.webkit.org/show_bug.cgi?id=66001
+
+ Reviewed by Gavin Barraclough.
+
+ Fix GC bugs found while testing increased validation logic
+
+ * bindings/js/JSDOMWindowShell.cpp:
+ (WebCore::JSDOMWindowShell::JSDOMWindowShell):
+ * bindings/js/JSDOMWindowShell.h:
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::createWindowShell):
+ * bridge/objc/ObjCRuntimeObject.h:
+ (JSC::Bindings::ObjCRuntimeObject::create):
+ * bridge/objc/ObjCRuntimeObject.mm:
+ (JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
+ * bridge/objc/objc_instance.mm:
+
+2011-08-10 Ben Wells <benwells@chromium.org>
+
+ [skia] Move calls to makeGrContextCurrent into clipPathAntiAliased from callers
+ https://bugs.webkit.org/show_bug.cgi?id=65733
+
+ This protects against callers of clipPathAntiAliased forgetting to call makeGrContextCurrent.
+
+ Reviewed by James Robinson.
+
+ No change in functionality, no new tests.
+
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::GraphicsContext::addInnerRoundedRectClip):
+ (WebCore::GraphicsContext::clip):
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (WebCore::PlatformContextSkia::clipPathAntiAliased):
+
+2011-08-10 Benjamin Poulain <ikipou@gmail.com>
+
+ MarkupAccumulator: make resolution of URLs implicit to appendQuotedURLAttributeValue()
+ https://bugs.webkit.org/show_bug.cgi?id=65990
+
+ Reviewed by Ryosuke Niwa.
+
+ Instead of resolving the URLs in the call site of appendQuotedURLAttributeValue(),
+ the URL is now resolved if necessary in appendQuotedURLAttributeValue().
+
+ * editing/MarkupAccumulator.cpp:
+ (WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
+ (WebCore::MarkupAccumulator::appendAttribute):
+ * editing/MarkupAccumulator.h:
+
+2011-08-10 Kenichi Ishibashi <bashi@chromium.org>
+
+ [Chromium] Implement text shaping with font-feature-settings on Linux
+ https://bugs.webkit.org/show_bug.cgi?id=65903
+
+ - Modifies Font::codePath() to return Complex when there is font feature settings CSS property.
+ - Implements OpenType advanced typography feature using Harfbuzz on Chromium Linux port.
+
+ Reviewed by Adam Barth.
+
+ Test: css3/font-feature-settings-rendering.html
+
+ * platform/graphics/Font.cpp:
+ (WebCore::Font::codePath): Returns Complex when fontFeatureSettings exists.
+ * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
+ (WebCore::setupFontFeatures): Added.
+ (WebCore::ComplexTextController::setupFontForScriptRun): Calls setupFontFeatures().
+
+2011-08-10 Tony Gentilcore <tonyg@chromium.org>
+
+ [chromium] Notify MemoryCache of decoded data access
+ https://bugs.webkit.org/show_bug.cgi?id=65859
+
+ Reviewed by James Robinson.
+
+ This causes us to call CachedImage::didDraw() which calls CachedResource::didAccessDecodedData()
+ which updates the LRU for decoded image data and potentially prunes the cache. This is already done
+ by almost all of the other ports.
+
+ The decoded bitmaps obviously use quite a bit of memory, so pruning them when necessary is important.
+ In my tests, this saves several MB on many popular web pages.
+
+ No new tests because no observable difference in functionality.
+
+ * platform/graphics/skia/ImageSkia.cpp:
+ (WebCore::BitmapImage::draw):
+ (WebCore::BitmapImageSingleFrameSkia::draw):
+
+2011-08-10 Vsevolod Vlasov <vsevik@chromium.org>
+
+ Web Inspector: Remove Network.initialContentSet from protocol, store workers content on backend.
+ https://bugs.webkit.org/show_bug.cgi?id=65929
+
+ Reviewed by Pavel Feldman.
+
+ Tests: http/tests/inspector/network/network-shared-worker.html
+ http/tests/inspector/network/network-worker.html
+
+ * inspector/Inspector.json:
+ * inspector/InspectorInstrumentation.cpp:
+ (WebCore::InspectorInstrumentation::didReceiveScriptResponseImpl):
+ * inspector/InspectorInstrumentation.h:
+ (WebCore::InspectorInstrumentation::didReceiveScriptResponse):
+ * inspector/InspectorResourceAgent.cpp:
+ (WebCore::InspectorResourceAgent::didReceiveResponse):
+ (WebCore::InspectorResourceAgent::setInitialScriptContent):
+ (WebCore::InspectorResourceAgent::didReceiveScriptResponse):
+ * inspector/InspectorResourceAgent.h:
+ * inspector/front-end/NetworkManager.js:
+ * inspector/front-end/Resource.js:
+ * workers/DefaultSharedWorkerRepository.cpp:
+ (WebCore::SharedWorkerScriptLoader::didReceiveResponse):
+ * workers/Worker.cpp:
+ (WebCore::Worker::didReceiveResponse):
+ * workers/Worker.h:
+ * workers/WorkerScriptLoader.cpp:
+ (WebCore::WorkerScriptLoader::didReceiveResponse):
+ * workers/WorkerScriptLoaderClient.h:
+ (WebCore::WorkerScriptLoaderClient::didReceiveResponse):
+
+2011-08-10 Vsevolod Vlasov <vsevik@chromium.org>
+
+ Web Inspector: [Network] Filtering by stylesheet does not update the # reqs, filesizes.
+ https://bugs.webkit.org/show_bug.cgi?id=65515
+
+ Reviewed by Pavel Feldman.
+
+ * English.lproj/localizedStrings.js:
+ * inspector/front-end/NetworkPanel.js:
+ (WebInspector.NetworkLogView.prototype._updateSummaryBar):
+ (WebInspector.NetworkLogView.prototype._updateFilter):
+
+2011-08-10 Vsevolod Vlasov <vsevik@chromium.org>
+
+ Web Inspector: console messages markers are lost in Resources panel after page reload
+ https://bugs.webkit.org/show_bug.cgi?id=60701
+
+ Reviewed by Pavel Feldman.
+
+ Test: http/tests/inspector/resource-tree/resource-tree-errors-reload.html
+
+ * inspector/front-end/ResourceTreeModel.js:
+ (WebInspector.ResourceTreeModel):
+ (WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
+ (WebInspector.ResourceTreeModel.prototype._addPendingConsoleMessage):
+ (WebInspector.ResourceTreeModel.prototype._addPendingConsoleMessagesToResource):
+ (WebInspector.ResourceTreeModel.prototype._addConsoleMessageToResource):
+ (WebInspector.ResourceTreeModel.prototype._consoleCleared):
+ (WebInspector.ResourceTreeModel.prototype._bindResourceURL):
+
+2011-08-10 Lars Knudsen <lars.knudsen@nokia.com>
+
+ Add device specific settings to support viewport computing
+ https://bugs.webkit.org/show_bug.cgi?id=65984
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Based on patch by Zalan Bujtas.
+
+ Added settings for device size, dpi and layout fallback width
+ to support viewport computing.
+
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ * page/Settings.h:
+ (WebCore::Settings::setLayoutFallbackWidth):
+ (WebCore::Settings::layoutFallbackWidth):
+ (WebCore::Settings::setDeviceWidth):
+ (WebCore::Settings::deviceWidth):
+ (WebCore::Settings::setDeviceHeight):
+ (WebCore::Settings::deviceHeight):
+ (WebCore::Settings::setDeviceDPI):
+ (WebCore::Settings::deviceDPI):
+
+2011-08-10 Benjamin Poulain <benjamin@webkit.org>
+
+ Unify the way we generate HTML for an image in the Clipboard
+ https://bugs.webkit.org/show_bug.cgi?id=58043
+
+ Reviewed by Ryosuke Niwa.
+
+ Unify the way we generate the markup when dragging and image.
+
+ Previously, the code was using the special function imageToMarkup() that was
+ spread from the Chromium port.
+ That function ignores some edge cases so this patch replace it by the
+ more generic MarkupAccumulator (which is also used by the other pasteboard
+ actions).
+
+ The MarkupAccumulator was modified because following r61178, the local filepath
+ are treated differently (the enum was changed to make this behavior
+ explicit).
+
+ Tests: fast/drag-and-drop/drag-and-drop-image-contenteditable.html
+ fast/drag-and-drop/drag-and-drop-inputimage-contenteditable.html
+ fast/drag-and-drop/drag-and-drop-objectimage-contenteditable.html
+
+ * editing/MarkupAccumulator.cpp:
+ (WebCore::MarkupAccumulator::MarkupAccumulator):
+ (WebCore::MarkupAccumulator::resolveURLIfNeeded):
+ (WebCore::MarkupAccumulator::appendAttribute):
+ * editing/MarkupAccumulator.h:
+ * editing/markup.cpp:
+ * editing/markup.h:
+ * page/PageSerializer.cpp:
+ (WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator):
+ * platform/chromium/ClipboardChromium.cpp:
+ (WebCore::ClipboardChromium::declareAndWriteDragImage):
+ (WebCore::ClipboardChromium::writeRange):
+ * platform/chromium/PasteboardChromium.cpp:
+ (WebCore::Pasteboard::writeSelection):
+ * platform/gtk/ClipboardGtk.cpp:
+ (WebCore::ClipboardGtk::declareAndWriteDragImage):
+ (WebCore::ClipboardGtk::writeRange):
+ * platform/gtk/DataObjectGtk.cpp:
+ (WebCore::DataObjectGtk::markup):
+ * platform/gtk/PasteboardGtk.cpp:
+ (WebCore::Pasteboard::writeSelection):
+ (WebCore::Pasteboard::writeImage):
+ * platform/haiku/PasteboardHaiku.cpp:
+ (WebCore::Pasteboard::writeSelection):
+ * platform/qt/ClipboardQt.cpp:
+ (WebCore::ClipboardQt::declareAndWriteDragImage):
+ (WebCore::ClipboardQt::writeRange):
+ * platform/qt/PasteboardQt.cpp:
+ (WebCore::Pasteboard::writeSelection):
+ * platform/win/ClipboardWin.cpp:
+ (WebCore::ClipboardWin::declareAndWriteDragImage):
+
+2011-08-10 Pavel Feldman <pfeldman@google.com>
+
+ Web Inspector: auto-completion for string literals doesn't work
+ https://bugs.webkit.org/show_bug.cgi?id=65701
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/InjectedScript.cpp:
+ (WebCore::InjectedScript::evaluateOnCallFrame):
+ * inspector/InjectedScript.h:
+ * inspector/InjectedScriptSource.js:
+ (.):
+ ():
+ * inspector/Inspector.json:
+ * inspector/InspectorDebuggerAgent.cpp:
+ (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
+ * inspector/InspectorDebuggerAgent.h:
+ * inspector/front-end/ConsoleView.js:
+ (WebInspector.ConsoleView.prototype._completions.evaluated.getCompletions):
+ (WebInspector.ConsoleView.prototype._completions.evaluated):
+ (WebInspector.ConsoleView.prototype._completions.receivedPropertyNamesFromEval):
+ (WebInspector.ConsoleView.prototype._completions.receivedPropertyNames):
+ (WebInspector.ConsoleView.prototype._completions):
+ (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
+ * inspector/front-end/DebuggerPresentationModel.js:
+ (WebInspector.PresenationCallFrame.prototype.evaluate):
+ * inspector/front-end/RemoteObject.js:
+ (WebInspector.RemoteObject):
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
+ (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):
+
+2011-08-10 Pavel Feldman <pfeldman@google.com>
+
+ Web Inspector: CSS editing file containing tabs leads to the whole file change in revision history.
+ https://bugs.webkit.org/show_bug.cgi?id=65959
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/front-end/SourceFrame.js:
+ (WebInspector.SourceFrame):
+ * inspector/front-end/TextEditorModel.js:
+ (WebInspector.TextEditorModel.prototype._innerSetText):
+
+2011-08-10 Pavel Feldman <pfeldman@chromium.org>
+
+ Web Inspector: there should be a way to tell what properties are non-enumerable when expanding objects.
+ https://bugs.webkit.org/show_bug.cgi?id=65518
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/InjectedScript.cpp:
+ (WebCore::InjectedScript::getProperties):
+ * inspector/InjectedScript.h:
+ * inspector/InjectedScriptSource.js:
+ (.):
+ * inspector/Inspector.json:
+ * inspector/InspectorRuntimeAgent.cpp:
+ (WebCore::InspectorRuntimeAgent::getProperties):
+ * inspector/InspectorRuntimeAgent.h:
+ * inspector/front-end/ObjectPropertiesSection.js:
+ (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
+ (WebInspector.ObjectPropertyTreeElement.prototype.update):
+ * inspector/front-end/RemoteObject.js:
+ (WebInspector.RemoteObject.prototype.getOwnProperties):
+ (WebInspector.RemoteObject.prototype.getAllProperties):
+ (WebInspector.RemoteObjectProperty):
+ * inspector/front-end/inspector.css:
+ (.section .properties .dimmed):
+
2011-08-10 Alexander Pavlov <apavlov@chromium.org>
Web Inspector: [REGRESSION] Editor lost after committing a CSS property value for inline style
« no previous file with comments | « no previous file | Source/WebCore/inspector/InspectorDebuggerAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698