Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: Makefile.android

Issue 770783003: Improved Makefile.android's readability a bit. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 20 matching lines...) Expand all
31 31
32 # Generates all combinations of ANDROID ARCHES and MODES, 32 # Generates all combinations of ANDROID ARCHES and MODES,
33 # e.g. "android_ia32.release" or "android_arm.release" 33 # e.g. "android_ia32.release" or "android_arm.release"
34 ANDROID_BUILDS = $(foreach mode,$(MODES), \ 34 ANDROID_BUILDS = $(foreach mode,$(MODES), \
35 $(addsuffix .$(mode),$(ANDROID_ARCHES))) 35 $(addsuffix .$(mode),$(ANDROID_ARCHES)))
36 36
37 HOST_OS = $(shell uname -s | sed -e 's/Linux/linux/;s/Darwin/mac/') 37 HOST_OS = $(shell uname -s | sed -e 's/Linux/linux/;s/Darwin/mac/')
38 ANDROID_NDK_HOST_ARCH ?= $(shell uname -m | sed -e 's/i[3456]86/x86/') 38 ANDROID_NDK_HOST_ARCH ?= $(shell uname -m | sed -e 's/i[3456]86/x86/')
39 ifeq ($(HOST_OS), linux) 39 ifeq ($(HOST_OS), linux)
40 TOOLCHAIN_DIR = linux-$(ANDROID_NDK_HOST_ARCH) 40 TOOLCHAIN_DIR = linux-$(ANDROID_NDK_HOST_ARCH)
41 else ifeq ($(HOST_OS), mac)
42 TOOLCHAIN_DIR = darwin-$(ANDROID_NDK_HOST_ARCH)
41 else 43 else
42 ifeq ($(HOST_OS), mac) 44 $(error Host platform "${HOST_OS}" is not supported)
43 TOOLCHAIN_DIR = darwin-$(ANDROID_NDK_HOST_ARCH)
44 else
45 $(error Host platform "${HOST_OS}" is not supported)
46 endif
47 endif 45 endif
48 46
49 ifeq ($(ARCH), android_arm) 47 ifeq ($(ARCH), android_arm)
50 DEFINES = target_arch=arm v8_target_arch=arm android_target_arch=arm android_ target_platform=14 48 DEFINES = target_arch=arm v8_target_arch=arm android_target_arch=arm android_ target_platform=14
51 DEFINES += arm_neon=0 arm_version=7 49 DEFINES += arm_neon=0 arm_version=7
52 TOOLCHAIN_ARCH = arm-linux-androideabi 50 TOOLCHAIN_ARCH = arm-linux-androideabi
53 TOOLCHAIN_PREFIX = $(TOOLCHAIN_ARCH) 51 TOOLCHAIN_PREFIX = $(TOOLCHAIN_ARCH)
54 TOOLCHAIN_VER = 4.8 52 TOOLCHAIN_VER = 4.8
53 else ifeq ($(ARCH), android_arm64)
54 DEFINES = target_arch=arm64 v8_target_arch=arm64 android_target_arch=arm64 an droid_target_platform=L
55 TOOLCHAIN_ARCH = aarch64-linux-android
56 TOOLCHAIN_PREFIX = $(TOOLCHAIN_ARCH)
57 TOOLCHAIN_VER = 4.9
58 else ifeq ($(ARCH), android_mipsel)
59 DEFINES = target_arch=mipsel v8_target_arch=mipsel android_target_platform=14
60 DEFINES += android_target_arch=mips mips_arch_variant=mips32r2
61 TOOLCHAIN_ARCH = mipsel-linux-android
62 TOOLCHAIN_PREFIX = $(TOOLCHAIN_ARCH)
63 TOOLCHAIN_VER = 4.8
64 else ifeq ($(ARCH), android_ia32)
65 DEFINES = target_arch=ia32 v8_target_arch=ia32 android_target_arch=x86 android _target_platform=14
66 TOOLCHAIN_ARCH = x86
67 TOOLCHAIN_PREFIX = i686-linux-android
68 TOOLCHAIN_VER = 4.8
69 else ifeq ($(ARCH), android_x87)
70 DEFINES = target_arch=x87 v8_target_arch=x87 android_target_arch=x86 android_t arget_platform=14
71 TOOLCHAIN_ARCH = x86
72 TOOLCHAIN_PREFIX = i686-linux-android
73 TOOLCHAIN_VER = 4.8
55 else 74 else
56 ifeq ($(ARCH), android_arm64) 75 $(error Target architecture "${ARCH}" is not supported)
57 DEFINES = target_arch=arm64 v8_target_arch=arm64 android_target_arch=arm64 android_target_platform=L
58 TOOLCHAIN_ARCH = aarch64-linux-android
59 TOOLCHAIN_PREFIX = $(TOOLCHAIN_ARCH)
60 TOOLCHAIN_VER = 4.9
61 else
62 ifeq ($(ARCH), android_mipsel)
63 DEFINES = target_arch=mipsel v8_target_arch=mipsel android_target_platfor m=14
64 DEFINES += android_target_arch=mips mips_arch_variant=mips32r2
65 TOOLCHAIN_ARCH = mipsel-linux-android
66 TOOLCHAIN_PREFIX = $(TOOLCHAIN_ARCH)
67 TOOLCHAIN_VER = 4.8
68
69 else
70 ifeq ($(ARCH), android_ia32)
71 DEFINES = target_arch=ia32 v8_target_arch=ia32 android_target_arch=x86 a ndroid_target_platform=14
72 TOOLCHAIN_ARCH = x86
73 TOOLCHAIN_PREFIX = i686-linux-android
74 TOOLCHAIN_VER = 4.8
75 else
76 ifeq ($(ARCH), android_x87)
77 DEFINES = target_arch=x87 v8_target_arch=x87 android_target_arch=x86 a ndroid_target_platform=14
78 TOOLCHAIN_ARCH = x86
79 TOOLCHAIN_PREFIX = i686-linux-android
80 TOOLCHAIN_VER = 4.8
81 » else
82 $(error Target architecture "${ARCH}" is not supported)
83 endif
84 endif
85 endif
86 endif
87 endif 76 endif
88 77
89 TOOLCHAIN_PATH = \ 78 TOOLCHAIN_PATH = \
90 ${ANDROID_NDK_ROOT}/toolchains/${TOOLCHAIN_ARCH}-${TOOLCHAIN_VER}/prebuilt 79 ${ANDROID_NDK_ROOT}/toolchains/${TOOLCHAIN_ARCH}-${TOOLCHAIN_VER}/prebuilt
91 ANDROID_TOOLCHAIN ?= ${TOOLCHAIN_PATH}/${TOOLCHAIN_DIR} 80 ANDROID_TOOLCHAIN ?= ${TOOLCHAIN_PATH}/${TOOLCHAIN_DIR}
92 81
93 ifeq ($(wildcard $(ANDROID_TOOLCHAIN)),) 82 ifeq ($(wildcard $(ANDROID_TOOLCHAIN)),)
94 $(error Cannot find Android toolchain in "${ANDROID_TOOLCHAIN}". Please \ 83 $(error Cannot find Android toolchain in "${ANDROID_TOOLCHAIN}". Please \
95 check that ANDROID_NDK_ROOT and ANDROID_NDK_HOST_ARCH are set \ 84 check that ANDROID_NDK_ROOT and ANDROID_NDK_HOST_ARCH are set \
96 correctly) 85 correctly)
(...skipping 20 matching lines...) Expand all
117 ANDROID_MAKEFILES = $(addprefix $(OUTDIR)/Makefile.,$(ANDROID_BUILDS)) 106 ANDROID_MAKEFILES = $(addprefix $(OUTDIR)/Makefile.,$(ANDROID_BUILDS))
118 $(ANDROID_MAKEFILES): 107 $(ANDROID_MAKEFILES):
119 GYP_GENERATORS=make-android \ 108 GYP_GENERATORS=make-android \
120 GYP_DEFINES="${DEFINES}" \ 109 GYP_DEFINES="${DEFINES}" \
121 CC="${ANDROID_TOOLCHAIN}/bin/${TOOLCHAIN_PREFIX}-gcc" \ 110 CC="${ANDROID_TOOLCHAIN}/bin/${TOOLCHAIN_PREFIX}-gcc" \
122 CXX="${ANDROID_TOOLCHAIN}/bin/${TOOLCHAIN_PREFIX}-g++" \ 111 CXX="${ANDROID_TOOLCHAIN}/bin/${TOOLCHAIN_PREFIX}-g++" \
123 PYTHONPATH="$(shell pwd)/tools/generate_shim_headers:$(shell pwd)/build: $(PYTHONPATH)" \ 112 PYTHONPATH="$(shell pwd)/tools/generate_shim_headers:$(shell pwd)/build: $(PYTHONPATH)" \
124 build/gyp/gyp --generator-output="${OUTDIR}" build/all.gyp \ 113 build/gyp/gyp --generator-output="${OUTDIR}" build/all.gyp \
125 -Ibuild/standalone.gypi --depth=. -Ibuild/android.gypi \ 114 -Ibuild/standalone.gypi --depth=. -Ibuild/android.gypi \
126 -S$(suffix $(basename $@))$(suffix $@) ${GYPFLAGS} 115 -S$(suffix $(basename $@))$(suffix $@) ${GYPFLAGS}
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698