Issue 770723004: Files.app: Remove unused 'internal' type from MetadataCache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 770723004: Files.app: Remove unused 'internal' type from MetadataCache. (Closed)

Created:
6 years ago by hirono

Modified:
6 years ago

Reviewers:
fukino

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Files.app: Remove unused 'internal' type from MetadataCache. The cache type is introduced for the 'undo' feature that has been removed. https://chromiumcodereview.appspot.com/10914075/diff/8001/chrome/browser/resources/file_manager/js/directory_contents.js BUG=439329 TEST=manually Committed: https://crrev.com/43fbf91a382cee529d9ec730872dcf2041f25ffb Cr-Commit-Position: refs/heads/master@{#307392}

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -18 lines)			Patch
M	ui/file_manager/file_manager/foreground/js/directory_contents.js	View	1 chunk	+1 line, -15 lines	0 comments	Download
M	ui/file_manager/file_manager/foreground/js/file_manager.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js	View	2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/770723004/1

6 years ago (2014-12-09 01:12:57 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-09 01:21:30 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/43fbf91a382cee529d9ec730872dcf2041f25ffb
Cr-Commit-Position: refs/heads/master@{#307392}