Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 770713005: FakeVideoCaptureDevice: add 1080p resolution (Closed)

Created:
6 years ago by mcasas
Modified:
6 years ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

FakeVideoCaptureDevice: add 1080p resolution TEST= Run Chrome with flag --use-fake-device-for-media-stream, navigate to http://goo.gl/s2XhGB and see the rolling pacman correctly displayed. Committed: https://crrev.com/0309b1db84a6afa509abbc0d49622e0db5ce552d Cr-Commit-Position: refs/heads/master@{#306675}

Patch Set 1 #

Patch Set 2 : Sorted out content_browsertests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M content/browser/media/webrtc_browsertest.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/media/webrtc_getusermedia_browsertest.cc View 1 2 chunks +14 lines, -1 line 0 comments Download
M media/video/capture/fake_video_capture_device.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/video/capture/fake_video_capture_device_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/video/capture/fake_video_capture_device_unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
mcasas
perkj@ PTAL
6 years ago (2014-12-01 22:10:58 UTC) #2
perkj_chrome
lgtm please remove bug= or file one.
6 years ago (2014-12-02 13:51:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/770713005/1
6 years ago (2014-12-02 18:57:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/10686) win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/builds/16170)
6 years ago (2014-12-02 19:49:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/770713005/20001
6 years ago (2014-12-03 21:02:43 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-03 21:06:24 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-03 21:07:27 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0309b1db84a6afa509abbc0d49622e0db5ce552d
Cr-Commit-Position: refs/heads/master@{#306675}

Powered by Google App Engine
This is Rietveld 408576698