Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 77063004: JSON schema compiler: remove SOURCE_BASE_PATH hack from bundle generator. (Closed)

Created:
7 years, 1 month ago by Yoyo Zhou
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

JSON schema compiler: remove SOURCE_BASE_PATH hack from bundle generator. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236308

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M tools/json_schema_compiler/compiler.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/json_schema_compiler/cpp_bundle_generator.py View 5 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yoyo Zhou
7 years, 1 month ago (2013-11-20 01:52:41 UTC) #1
not at google - send to devlin
lgtm
7 years, 1 month ago (2013-11-20 02:16:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/77063004/1
7 years, 1 month ago (2013-11-20 16:44:01 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-20 21:44:31 UTC) #4
Message was sent while issue was closed.
Change committed as 236308

Powered by Google App Engine
This is Rietveld 408576698