Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 770613003: Don't throw an exception when model is changed. (Closed)

Created:
6 years ago by scheglov
Modified:
6 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't throw an exception when model is changed. I don't add much information, just 'return false;' is enough. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 4 chunks +13 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years ago (2014-12-03 23:10:38 UTC) #1
Brian Wilkerson
LGTM
6 years ago (2014-12-03 23:15:56 UTC) #2
scheglov
6 years ago (2014-12-03 23:21:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42094 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698