Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 7706004: Unify UpdateSlotsOnPage and SweepPrecisely. (Closed)

Created:
9 years, 4 months ago by Michael Starzinger
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Unify UpdateSlotsOnPage and SweepPrecisely. R=vegorov@chromium.org BUG=v8:1610 Committed: http://code.google.com/p/v8/source/detail?r=8995

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use enum instead of boolean to distinguish modes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -55 lines) Patch
M src/mark-compact.cc View 1 5 chunks +22 lines, -55 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
9 years, 4 months ago (2011-08-22 16:26:13 UTC) #1
Vyacheslav Egorov (Chromium)
LGTM http://codereview.chromium.org/7706004/diff/1/src/mark-compact.cc File src/mark-compact.cc (left): http://codereview.chromium.org/7706004/diff/1/src/mark-compact.cc#oldcode2615 src/mark-compact.cc:2615: PagedSpace* space = static_cast<PagedSpace*>(p->owner()); I prefer enums to ...
9 years, 4 months ago (2011-08-22 17:00:37 UTC) #2
Michael Starzinger
9 years, 4 months ago (2011-08-23 07:48:48 UTC) #3
Added new patch set.

http://codereview.chromium.org/7706004/diff/1/src/mark-compact.cc
File src/mark-compact.cc (left):

http://codereview.chromium.org/7706004/diff/1/src/mark-compact.cc#oldcode2615
src/mark-compact.cc:2615: PagedSpace* space =
static_cast<PagedSpace*>(p->owner());
On 2011/08/22 17:00:37, Vyacheslav Egorov wrote:
> I prefer enums to booleans they make callsites clearer.

Done.

Powered by Google App Engine
This is Rietveld 408576698