Issue 7706004: Unify UpdateSlotsOnPage and SweepPrecisely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7706004: Unify UpdateSlotsOnPage and SweepPrecisely. (Closed)

Created:
9 years, 4 months ago by Michael Starzinger

Modified:
9 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/gc

Visibility:
Public.

Description

Unify UpdateSlotsOnPage and SweepPrecisely. R=vegorov@chromium.org BUG=v8:1610 Committed: http://code.google.com/p/v8/source/detail?r=8995

Patch Set 2 : Use enum instead of boolean to distinguish modes. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -55 lines)			Patch
	M	src/mark-compact.cc	View	1	5 chunks	+22 lines, -55 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM http://codereview.chromium.org/7706004/diff/1/src/mark-compact.cc File src/mark-compact.cc (left): http://codereview.chromium.org/7706004/diff/1/src/mark-compact.cc#oldcode2615 src/mark-compact.cc:2615: PagedSpace* space = static_cast<PagedSpace*>(p->owner()); I prefer enums to ...

9 years, 4 months ago (2011-08-22 17:00:37 UTC) #2

Michael Starzinger

9 years, 4 months ago (2011-08-23 07:48:48 UTC) #3

Added new patch set.

http://codereview.chromium.org/7706004/diff/1/src/mark-compact.cc
File src/mark-compact.cc (left):

http://codereview.chromium.org/7706004/diff/1/src/mark-compact.cc#oldcode2615
src/mark-compact.cc:2615: PagedSpace* space =
static_cast<PagedSpace*>(p->owner());
On 2011/08/22 17:00:37, Vyacheslav Egorov wrote:
> I prefer enums to booleans they make callsites clearer.

Done.

Expand Messages | Collapse Messages

Issue 7706004: Unify UpdateSlotsOnPage and SweepPrecisely. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Use enum instead of boolean to distinguish modes. #

Messages