Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: src/heap/incremental-marking.h

Issue 770453003: Use just one marking deque. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/incremental-marking.h
diff --git a/src/heap/incremental-marking.h b/src/heap/incremental-marking.h
index 132eff224b8445910c8c2c88cefdfb4b7fbbcdb7..e2cf651ee4638aedc74d5449ae1ccfcb014aec40 100644
--- a/src/heap/incremental-marking.h
+++ b/src/heap/incremental-marking.h
@@ -28,8 +28,6 @@ class IncrementalMarking {
static void Initialize();
- void TearDown();
-
State state() {
DCHECK(state_ == STOPPED || FLAG_incremental_marking);
return state_;
@@ -144,10 +142,6 @@ class IncrementalMarking {
SetNewSpacePageFlags(chunk, IsMarking());
}
- MarkingDeque* marking_deque() { return &marking_deque_; }
-
- bool IsMarkingDequeEmpty() { return marking_deque_.IsEmpty(); }
-
bool IsCompacting() { return IsMarking() && is_compacting_; }
void ActivateGeneratedStub(Code* stub);
@@ -170,8 +164,6 @@ class IncrementalMarking {
void LeaveNoMarkingScope() { no_marking_scope_depth_--; }
- void UncommitMarkingDeque();
-
void NotifyIncompleteScanOfObject(int unscanned_bytes) {
unscanned_bytes_of_large_object_ = unscanned_bytes;
}
@@ -202,13 +194,9 @@ class IncrementalMarking {
static void SetNewSpacePageFlags(NewSpacePage* chunk, bool is_marking);
- void EnsureMarkingDequeIsCommitted();
-
- INLINE(void ProcessMarkingDeque());
-
INLINE(intptr_t ProcessMarkingDeque(intptr_t bytes_to_process));
- INLINE(void VisitObject(Map* map, HeapObject* obj, int size));
+ void VisitObject(Map* map, HeapObject* obj, int size);
void IncrementIdleMarkingDelayCounter();
@@ -217,10 +205,6 @@ class IncrementalMarking {
State state_;
bool is_compacting_;
- base::VirtualMemory* marking_deque_memory_;
- bool marking_deque_memory_committed_;
- MarkingDeque marking_deque_;
-
int steps_count_;
int64_t old_generation_space_available_at_start_of_incremental_;
int64_t old_generation_space_used_at_start_of_incremental_;
@@ -236,6 +220,8 @@ class IncrementalMarking {
int unscanned_bytes_of_large_object_;
+ friend class MarkCompactCollector;
+
DISALLOW_IMPLICIT_CONSTRUCTORS(IncrementalMarking);
};
}
« no previous file with comments | « src/heap/heap.cc ('k') | src/heap/incremental-marking.cc » ('j') | src/heap/mark-compact.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698