Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11308)

Unified Diff: content/browser/push_messaging/push_messaging_message_filter.h

Issue 770423003: Fix thread-safety of PushMessagingMessageFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mvan-fromworker
Patch Set: Tweak comment Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/push_messaging/push_messaging_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/push_messaging/push_messaging_message_filter.h
diff --git a/content/browser/push_messaging/push_messaging_message_filter.h b/content/browser/push_messaging/push_messaging_message_filter.h
index f9812704783d08628ebf4637bbca0d98f7105514..752c6ca361c8087f567e152030b56c2cbdac16f6 100644
--- a/content/browser/push_messaging/push_messaging_message_filter.h
+++ b/content/browser/push_messaging/push_messaging_message_filter.h
@@ -87,7 +87,10 @@ class PushMessagingMessageFilter : public BrowserMessageFilter {
// Owned by the content embedder's browsing context.
PushMessagingService* service_;
- base::WeakPtrFactory<PushMessagingMessageFilter> weak_factory_;
+ // Should only be used for asynchronous calls to the PushMessagingService on
+ // the UI thread, which may have external dependencies that supersede the
+ // lifetime of this messaging filter.
+ base::WeakPtrFactory<PushMessagingMessageFilter> weak_factory_ui_to_ui_;
DISALLOW_COPY_AND_ASSIGN(PushMessagingMessageFilter);
};
« no previous file with comments | « no previous file | content/browser/push_messaging/push_messaging_message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698