Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 770373002: CheckPrototypes uses weak cells to embed maps. (Closed)

Created:
6 years ago by ulan
Modified:
6 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

CheckPrototypes uses weak cells to embed maps. BUG=v8:3629 LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -19 lines) Patch
M src/ic/arm/handler-compiler-arm.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 3 chunks +13 lines, -6 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ulan
PTAL
6 years ago (2014-12-02 16:25:23 UTC) #2
Jakob Kummerow
lgtm
6 years ago (2014-12-03 12:05:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/770373002/1
6 years ago (2014-12-03 12:08:43 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-03 12:34:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698