LayoutTests/crypto/importKey-deserialized.html - Issue 770363002: [WebCrypto] Crypto tests updated to use KeyUsage

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/crypto/importKey-deserialized.html

Issue 770363002: [WebCrypto] Crypto tests updated to use KeyUsage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../resources/js-test.js"></script>

	5 <script src="resources/common.js"></script>

	6 </head>

	7 <body>

	8 <script>

	9

	10 description("Check already imported key, with empty usage can be deserialized.") ;
	eroman 2014/12/16 20:23:53 "Check that an already imported key with empty usa "Check that an already imported key with empty usages can be deserialized." Also please provide some additional commentary explaining why this is relevant. You can take a look at this test as an example: https://chromium.googlesource.com/chromium/blink/+/master/LayoutTests/crypto/... (Years from now it will not be obvious why this use case needs to be supported). Habib Virji 2014/12/17 11:54:36 Done. Show quoted text On 2014/12/16 20:23:53, eroman wrote: > "Check that an already imported key with empty usages can be deserialized." > > Also please provide some additional commentary explaining why this is relevant. > > You can take a look at this test as an example: > > https://chromium.googlesource.com/chromium/blink/+/master/LayoutTests/crypto/... > > (Years from now it will not be obvious why this use case needs to be supported). Done.
	11 jsTestIsAsync = true;
	eroman 2014/12/16 20:23:53 This test can be synchronous. Take a look at clone This test can be synchronous. Take a look at clone-hmacKey-empty.html as an example Habib Virji 2014/12/17 11:54:36 Done. Show quoted text On 2014/12/16 20:23:53, eroman wrote: > This test can be synchronous. Take a look at clone-hmacKey-empty.html as an > example Done.
	12

	13 var importedKey = "ff073f004b010110011030112233445566778899aabbccddeeff";

	14 var deserializedBuffer = internals.deserializeBuffer(hexStringToUint8Array(impor tedKey).buffer);

	15 shouldBe("deserializedBuffer.usages", "[]");
	eroman 2014/12/16 20:23:53 Please add some other assertions for the key type, Please add some other assertions for the key type, algorithm name, extractability etc. (The interesting point is to see that it is a secret or private key, with empty usages). Habib Virji 2014/12/17 11:54:36 Done. Show quoted text On 2014/12/16 20:23:53, eroman wrote: > Please add some other assertions for the key type, algorithm name, > extractability etc. > > (The interesting point is to see that it is a secret or private key, with empty > usages). Done.
	16

	17 finishJSTest();
	eroman 2014/12/16 20:23:53 If the test is made synchronous this is not needed If the test is made synchronous this is not needed Habib Virji 2014/12/17 11:54:36 Done. Show quoted text On 2014/12/16 20:23:53, eroman wrote: > If the test is made synchronous this is not needed Done.
	18

	19 </script>

	20 </body>

	21 </html>

	22

OLD	NEW

« no previous file with comments | « LayoutTests/crypto/import-jwk.html ('k') | LayoutTests/crypto/importKey-deserialized-expected.txt » ('j') | no next file with comments »