components/autofill/core/browser/personal_data_manager.cc - Issue 770333006: Autofill - change presentation of credit card suggestions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/personal_data_manager.cc

Issue 770333006: Autofill - change presentation of credit card suggestions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: resolve merge conflict Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/credit_card_unittest.cc ('k') | components/autofill/core/browser/personal_data_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/personal_data_manager.cc

diff --git a/components/autofill/core/browser/personal_data_manager.cc b/components/autofill/core/browser/personal_data_manager.cc

index f71abc2fde9b85b087ee4602b65c0594cafad046..5fd2da79dc0495a504253203336e44420b08d2d5 100644

--- a/components/autofill/core/browser/personal_data_manager.cc

+++ b/components/autofill/core/browser/personal_data_manager.cc

@@ -659,7 +659,7 @@ std::vector<Suggestion> PersonalDataManager::GetCreditCardSuggestions(

// Otherwise the label is the card number, or if that is empty the

// cardholder name. The label should never repeat the value.

if (type.GetStorableType() == CREDIT_CARD_NUMBER) {

- creditcard_field_value = credit_card->ObfuscatedNumber();

+ creditcard_field_value = credit_card->TypeAndLastFourDigits();

suggestion->label = credit_card->GetInfo(

AutofillType(CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR), app_locale_);

} else if (credit_card->number().empty()) {