Autofill - change presentation of credit card suggestions.

components/autofill/core/browser/autofill_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/format_macros.h"
 #include "base/memory/ref_counted.h"
@@ skipping 841 matching lines @@
   FormFieldData field = form.fields[1];
   GetAutofillSuggestions(form, field);
 
   // No suggestions provided, so send an empty vector as the results.
   // This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<base::string16>());
 
   // Test that we sent the right values to the external delegate.
   external_delegate_->CheckSuggestions(
       kDefaultPageID,
-      Suggestion("************3456", "04/12", kVisaCard,
+      Suggestion("Visa - 3456", "04/12", kVisaCard,
                  autofill_manager_->GetPackedCreditCardID(4)),
-      Suggestion("************8765", "10/14", kMasterCard,
+      Suggestion("MasterCard - 8765", "10/14", kMasterCard,
                  autofill_manager_->GetPackedCreditCardID(5)));
 }
 
 // Test that we return only matching credit card profile suggestions when the
 // selected form field has been partially filled out.
 TEST_F(AutofillManagerTest, GetCreditCardSuggestionsMatchCharacter) {
   // Set up our form data.
   FormData form;
   CreateTestCreditCardFormData(&form, true, false);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   FormFieldData field;
   test::CreateTestFormField("Card Number", "cardnumber", "78", "text", &field);
   GetAutofillSuggestions(form, field);
 
   // No suggestions provided, so send an empty vector as the results.
   // This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<base::string16>());
 
   // Test that we sent the right values to the external delegate.
   external_delegate_->CheckSuggestions(
       kDefaultPageID,
-      Suggestion("************3456", "04/12", kVisaCard,
+      Suggestion("Visa - 3456", "04/12", kVisaCard,
                  autofill_manager_->GetPackedCreditCardID(4)));
 }
 
 // Test that we return credit card profile suggestions when the selected form
 // field is not the credit card number field.
 TEST_F(AutofillManagerTest, GetCreditCardSuggestionsNonCCNumber) {
   // Set up our form data.
   FormData form;
   CreateTestCreditCardFormData(&form, true, false);
   std::vector<FormData> forms(1, form);
@@ skipping 83 matching lines @@
   FormFieldData field = form.fields[1];
   GetAutofillSuggestions(form, field);
 
   // No suggestions provided, so send an empty vector as the results.
   // This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<base::string16>());
 
   // Test that we sent the right values to the external delegate.
   external_delegate_->CheckSuggestions(
       kDefaultPageID,
-      Suggestion("************3456", "04/12", kVisaCard,
+      Suggestion("Visa - 3456", "04/12", kVisaCard,
                  autofill_manager_->GetPackedCreditCardID(4)),
-      Suggestion("************8765", "10/14", kMasterCard,
+      Suggestion("MasterCard - 8765", "10/14", kMasterCard,
                  autofill_manager_->GetPackedCreditCardID(5)),
-      Suggestion("************3456", "05/12", kMasterCard,
+      Suggestion("MasterCard - 3456", "05/12", kMasterCard,
                  autofill_manager_->GetPackedCreditCardID(7)));
 }
 
 // Test that we return profile and credit card suggestions for combined forms.
 TEST_F(AutofillManagerTest, GetAddressAndCreditCardSuggestions) {
   // Set up our form data.
   FormData form;
   test::CreateTestAddressFormData(&form);
   CreateTestCreditCardFormData(&form, true, false);
   std::vector<FormData> forms(1, form);
@@ skipping 16 matching lines @@
   test::CreateTestFormField("Card Number", "cardnumber", "", "text", &field);
   GetAutofillSuggestions(kPageID2, form, field);
 
   // No suggestions provided, so send an empty vector as the results.
   // This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<base::string16>());
 
   // Test that we sent the credit card suggestions to the external delegate.
   external_delegate_->CheckSuggestions(
       kPageID2,
-      Suggestion("************3456", "04/12", kVisaCard,
+      Suggestion("Visa - 3456", "04/12", kVisaCard,
                  autofill_manager_->GetPackedCreditCardID(4)),
-      Suggestion("************8765", "10/14", kMasterCard,
+      Suggestion("MasterCard - 8765", "10/14", kMasterCard,
                  autofill_manager_->GetPackedCreditCardID(5)));
 }
 
 // Test that for non-https forms with both address and credit card fields, we
 // only return address suggestions. Instead of credit card suggestions, we
 // should return a warning explaining that credit card profile suggestions are
 // unavailable when the form is not https.
 TEST_F(AutofillManagerTest, GetAddressAndCreditCardSuggestionsNonHttps) {
   // Set up our form data.
   FormData form;
@@ skipping 1878 matching lines @@
 
   // Get the suggestions for already filled credit card |number_field|.
   GetAutofillSuggestions(form, number_field);
 
   // No autocomplete suggestions provided, so send an empty vector as the
   // results. This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<base::string16>());
 
   external_delegate_->CheckSuggestions(
       kDefaultPageID,
-      Suggestion("************3456", "04/12", kVisaCard,
+      Suggestion("Visa - 3456", "04/12", kVisaCard,
                  autofill_manager_->GetPackedCreditCardID(4)));
 }
 
 }  // namespace autofill