Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: src/harmony-regexp.js

Issue 770333005: Implement the `RegExp.prototype.flags` getter (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/harmony-regexp.js
diff --git a/src/harmony-regexp.js b/src/harmony-regexp.js
new file mode 100644
index 0000000000000000000000000000000000000000..2090aab4ec1cd43a84a2c4ba41384379cc56984b
--- /dev/null
+++ b/src/harmony-regexp.js
@@ -0,0 +1,33 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
Dmitry Lomov (no reviews) 2014/12/10 16:06:29 style nit: 'use strict'
+var $RegExp = global.RegExp;
+
+// -------------------------------------------------------------------
+
+// ES6 draft 12-06-13, section 21.2.5.3
+// + https://bugs.ecmascript.org/show_bug.cgi?id=3423
+var RegExpGetFlags = function() {
Dmitry Lomov (no reviews) 2014/12/10 16:06:29 style nit: just use function RegExpGetFlags here.
+ if (!IS_SPEC_OBJECT(this)) {
+ throw MakeTypeError('flags_getter_non_object',
+ [%ToString(this)]);
+ }
+ var result = '';
+ if (this.global) result += 'g';
+ if (this.ignoreCase) result += 'i';
+ if (this.multiline) result += 'm';
+ if (this.unicode) result += 'u';
+ if (this.sticky) result += 'y';
+ return result;
+};
+
+function ExtendRegExpPrototype() {
+ %CheckIsBootstrapping();
+
+ %DefineAccessorPropertyUnchecked($RegExp.prototype, 'flags', RegExpGetFlags,
+ null, DONT_ENUM | DONT_DELETE);
+ %SetNativeFlag(RegExpGetFlags);
+}
+
+ExtendRegExpPrototype();
« no previous file with comments | « src/bootstrapper.cc ('k') | src/messages.js » ('j') | test/mjsunit/harmony/regexp-flags.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698