Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Side by Side Diff: src/harmony-regexp.js

Issue 770333005: Implement the `RegExp.prototype.flags` getter (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Move to separate harmony-regexp.js file Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 var $RegExp = global.RegExp;
6
7 // -------------------------------------------------------------------
8
9 function ExtendRegExpPrototype() {
10 var NoOpSetter = function(ignored) {};
11
12
13 // ES6 draft 12-06-13, section 21.2.5.3
14 // + https://bugs.ecmascript.org/show_bug.cgi?id=3423
15 var RegExpGetFlags = function() {
arv (Not doing code reviews) 2014/12/10 02:54:50 Move this out of ExtendRegExpPrototype.
16 if (!IS_SPEC_OBJECT(this)) {
17 throw MakeTypeError('home_object_non_object',
Dmitry Lomov (no reviews) 2014/12/09 23:39:13 Wrong error message.
18 'RegExp.prototype.flags',
19 [%ToString(this)]);
20 }
21 var result = '';
22 if (this.global) result += 'g';
23 if (this.ignoreCase) result += 'i';
24 if (this.multiline) result += 'm';
25 if (this.unicode) result += 'u';
26 if (this.sticky) result += 'y';
27 return result;
28 };
29
30 %DefineAccessorPropertyUnchecked($RegExp.prototype, 'flags', RegExpGetFlags,
Dmitry Lomov (no reviews) 2014/12/09 23:39:13 You should pass 'undefined' here instead of NoOpSe
31 NoOpSetter, DONT_DELETE);
32 %SetNativeFlag(RegExpGetFlags);
33 }
34
35 ExtendRegExpPrototype();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698