runtime/vm/intermediate_language_ia32.cc - Issue 770303002: Support non-deoptimizing version of UnboxInt32 for integer definitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 770303002: Support non-deoptimizing version of UnboxInt32 for integer definitions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/vm/intermediate_language_arm.cc ('K') | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | runtime/vm/intermediate_language_mips.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/vm/intermediate_language_ia32.cc

diff --git a/runtime/vm/intermediate_language_ia32.cc b/runtime/vm/intermediate_language_ia32.cc

index ccf4a25ee3494cd324e7b04d0327546e73522cf0..bac20ec9fb06c8d5f0217d4774960ce3a1edc45d 100644

--- a/runtime/vm/intermediate_language_ia32.cc

+++ b/runtime/vm/intermediate_language_ia32.cc

@@ -3674,6 +3674,13 @@ void UnboxInteger32Instr::EmitNativeCode(FlowGraphCompiler* compiler) {

FieldAddress(value, hi_offset),

temp,

out_of_range);

+ } else if (!CanDeoptimize()) {

+ ASSERT(value == result);

+ Label done;

+ __ SmiUntag(value);

+ __ j(NOT_CARRY, &done);

+ __ movl(value, Address(value, TIMES_2, lo_offset));

+ __ Bind(&done);

} else {

ASSERT(value == result);

Label done;