Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 770253002: Fix [Exposed=..., RuntimeEnabled=...] IDL code generation. (Closed)

Created:
6 years ago by yhirano
Modified:
6 years ago
Reviewers:
haraken, Jens Widell, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix [Exposed=..., RuntimeEnabled=...] IDL code generation. Previously RuntimeEnabled extended attribute was ignored when specified with Exposed. This CL fixes the problem. This is a preparation for https://crbug.com/436770 BUG=436770 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -0 lines) Patch
M Source/bindings/templates/methods.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/core/TestInterface.idl View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 2 chunks +98 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yhirano
6 years ago (2014-12-02 11:31:59 UTC) #2
Jens Widell
LGTM
6 years ago (2014-12-02 11:40:20 UTC) #4
haraken
LGTM
6 years ago (2014-12-02 13:20:12 UTC) #5
bashi
LGTM
6 years ago (2014-12-02 23:28:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/770253002/1
6 years ago (2014-12-03 00:34:37 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-03 01:26:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186357

Powered by Google App Engine
This is Rietveld 408576698