Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 770223002: Remove lots of code from the WebWidget/WebView/WebFrame layer. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
ojan, eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove lots of code from the WebWidget/WebView/WebFrame layer. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8196b6edb14a20c02018e264523357815698c017

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -647 lines) Patch
M sky/engine/core/page/Page.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/page/Page.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/platform/scroll/ScrollAnimator.h View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.h View 2 chunks +0 lines, -6 lines 1 comment Download
M sky/engine/platform/scroll/ScrollableArea.cpp View 2 chunks +0 lines, -19 lines 0 comments Download
M sky/engine/public/web/WebFrame.h View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/public/web/WebView.h View 7 chunks +0 lines, -63 lines 0 comments Download
M sky/engine/public/web/WebWidget.h View 5 chunks +22 lines, -92 lines 0 comments Download
M sky/engine/public/web/WebWidgetClient.h View 1 chunk +0 lines, -15 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 10 chunks +4 lines, -55 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 19 chunks +0 lines, -359 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
6 years ago (2014-12-02 08:22:34 UTC) #2
eseidel
lgtm https://codereview.chromium.org/770223002/diff/1/sky/engine/platform/scroll/ScrollableArea.h File sky/engine/platform/scroll/ScrollableArea.h (left): https://codereview.chromium.org/770223002/diff/1/sky/engine/platform/scroll/ScrollableArea.h#oldcode86 sky/engine/platform/scroll/ScrollableArea.h:86: bool inLiveResize() const { return m_inLiveResize; } I ...
6 years ago (2014-12-02 08:25:05 UTC) #3
esprehn
6 years ago (2014-12-02 09:03:43 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8196b6edb14a20c02018e264523357815698c017.

Powered by Google App Engine
This is Rietveld 408576698