Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: content/browser/push_messaging/push_messaging_message_filter.cc

Issue 770023002: Push registration should read a "gcm_user_visible_only" key from the Manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/push_messaging/push_messaging_message_filter.cc
diff --git a/content/browser/push_messaging/push_messaging_message_filter.cc b/content/browser/push_messaging/push_messaging_message_filter.cc
index e3edeaf4685ece54968d06e28ed78d3f5ef6a175..ed179303bba698cc150eee5f6698b5236c97bcfe 100644
--- a/content/browser/push_messaging/push_messaging_message_filter.cc
+++ b/content/browser/push_messaging/push_messaging_message_filter.cc
@@ -62,7 +62,7 @@ void PushMessagingMessageFilter::OnRegisterFromDocument(
int render_frame_id,
int request_id,
const std::string& sender_id,
- bool user_gesture,
+ bool user_visible_only,
int service_worker_provider_id) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
// TODO(mvanouwerkerk): Validate arguments?
@@ -81,11 +81,13 @@ void PushMessagingMessageFilter::OnRegisterFromDocument(
// TODO(mvanouwerkerk): Persist sender id in Service Worker storage.
// https://crbug.com/437298
+ // TODO(peter): Persist |user_visible_only| in Service Worker storage.
+
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::Bind(&PushMessagingMessageFilter::RegisterFromDocumentOnUI,
weak_factory_.GetWeakPtr(), render_frame_id, request_id,
- sender_id, user_gesture,
+ sender_id, user_visible_only,
service_worker_host->active_version()->scope().GetOrigin(),
service_worker_host->active_version()->registration_id()));
}
@@ -160,7 +162,7 @@ void PushMessagingMessageFilter::RegisterFromDocumentOnUI(
int render_frame_id,
int request_id,
const std::string& sender_id,
- bool user_gesture,
+ bool user_visible_only,
const GURL& requesting_origin,
int64 service_worker_registration_id) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
@@ -174,7 +176,7 @@ void PushMessagingMessageFilter::RegisterFromDocumentOnUI(
}
service()->RegisterFromDocument(
requesting_origin, service_worker_registration_id, sender_id,
- render_process_id_, render_frame_id, user_gesture,
+ render_process_id_, render_frame_id, user_visible_only,
base::Bind(&PushMessagingMessageFilter::DidRegisterFromDocument,
weak_factory_.GetWeakPtr(), render_frame_id, request_id));
}

Powered by Google App Engine
This is Rietveld 408576698