content/browser/push_messaging/push_messaging_message_filter.h - Issue 770023002: Push registration should read a "gcm_user_visible_only" key from the Manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/push_messaging/push_messaging_message_filter.h

Issue 770023002: Push registration should read a "gcm_user_visible_only" key from the Manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/services/gcm/push_messaging_service_impl.cc ('k') | content/browser/push_messaging/push_messaging_message_filter.cc » ('j') | content/renderer/manifest/manifest_parser_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/push_messaging/push_messaging_message_filter.h

diff --git a/content/browser/push_messaging/push_messaging_message_filter.h b/content/browser/push_messaging/push_messaging_message_filter.h

index f9812704783d08628ebf4637bbca0d98f7105514..29cc57bf501f609a8e9b6057d4beb758f64757a7 100644

--- a/content/browser/push_messaging/push_messaging_message_filter.h

+++ b/content/browser/push_messaging/push_messaging_message_filter.h

@@ -35,7 +35,7 @@ class PushMessagingMessageFilter : public BrowserMessageFilter {

void OnRegisterFromDocument(int render_frame_id,

int request_id,

const std::string& sender_id,

- bool user_gesture,

+ bool user_visible_only,

int service_worker_provider_id);

void OnRegisterFromWorker(int request_id,

@@ -53,7 +53,7 @@ class PushMessagingMessageFilter : public BrowserMessageFilter {

void RegisterFromDocumentOnUI(int render_frame_id,

int request_id,

const std::string& sender_id,

- bool user_gesture,

+ bool user_visible_only,

const GURL& requesting_origin,

int64 service_worker_registration_id);