chrome/browser/services/gcm/push_messaging_service_impl.h - Issue 770023002: Push registration should read a "gcm_user_visible_only" key from the Manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/services/gcm/push_messaging_service_impl.h

Issue 770023002: Push registration should read a "gcm_user_visible_only" key from the Manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/services/gcm/push_messaging_service_impl.h

diff --git a/chrome/browser/services/gcm/push_messaging_service_impl.h b/chrome/browser/services/gcm/push_messaging_service_impl.h

index 6598e99631c92aa7cf1e85a9a4dd3bc55fdf8498..801f55ba4c97822fabf188752b37b352008e466a 100644

--- a/chrome/browser/services/gcm/push_messaging_service_impl.h

+++ b/chrome/browser/services/gcm/push_messaging_service_impl.h

@@ -57,7 +57,7 @@ class PushMessagingServiceImpl : public content::PushMessagingService,

const std::string& sender_id,

int renderer_id,

int render_frame_id,

- bool user_gesture,

+ bool user_visible_only,

const content::PushMessagingService::RegisterCallback& callback) override;

void RegisterFromWorker(

const GURL& requesting_origin,

« no previous file with comments | « no previous file | chrome/browser/services/gcm/push_messaging_service_impl.cc » ('j') | content/renderer/manifest/manifest_parser_unittest.cc » ('J')