chrome/browser/services/gcm/push_messaging_service_impl.cc - Issue 770023002: Push registration should read a "gcm_user_visible_only" key from the Manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/services/gcm/push_messaging_service_impl.cc

Issue 770023002: Push registration should read a "gcm_user_visible_only" key from the Manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment fix Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/services/gcm/push_messaging_service_impl.h ('K') | « chrome/browser/services/gcm/push_messaging_service_impl.h ('k') | content/browser/push_messaging/push_messaging_message_filter.h » ('j') | content/browser/push_messaging/push_messaging_message_filter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/services/gcm/push_messaging_service_impl.cc

diff --git a/chrome/browser/services/gcm/push_messaging_service_impl.cc b/chrome/browser/services/gcm/push_messaging_service_impl.cc

index 15b1b701e4b1a248174f0b0afa53db2c2564d081..0387b5a2cc447de73efab35af21b5743e3c23c6d 100644

--- a/chrome/browser/services/gcm/push_messaging_service_impl.cc

+++ b/chrome/browser/services/gcm/push_messaging_service_impl.cc

@@ -207,6 +207,7 @@ void PushMessagingServiceImpl::Register(

const GURL& origin,

int64 service_worker_registration_id,

const std::string& sender_id,

+ bool user_visible_only,

int renderer_id,

int render_frame_id,

bool user_gesture,

@@ -265,6 +266,8 @@ void PushMessagingServiceImpl::Register(

return;

}

+ // TODO(miguelg): Consider the value of |user_visible_only| when making

+ // the permission request.

permission_context->RequestPermission(

web_contents,

id,